GovOPlaN/govoplan-addresses
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

Clean Addresses audit and test resources

Browse Source
This commit is contained in:
Albrecht Degering
2026-07-21 03:16:38 +02:00
parent 22d12d674b
commit b13e5760c8
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/govoplan_addresses/backend/service.py
View File

@@ -99,7 +99,7 @@ REMOTE_SYNC_ACTIONS = {"remote_create", "remote_update", "remote_delete"}
ADDRESS_MODULE_ID = "addresses" ADDRESS_MODULE_ID = "addresses"
ADDRESS_CONTACTS_COLLECTION = "addresses.contacts" ADDRESS_CONTACTS_COLLECTION = "addresses.contacts"
ADDRESS_CONTACT_RESOURCE = "address_contact" ADDRESS_CONTACT_RESOURCE = "address_contact"
CARDDAV_SECRET_ENV_PREFIX = "env:" CARDDAV_SECRET_ENV_PREFIX = "env:" # noqa: S105 # nosec B105 - reference prefix, not a credential.
def _trim(value: str | None) -> str | None: def _trim(value: str | None) -> str | None:

11
tests/test_addresses_service.py
View File

@@ -158,9 +158,9 @@ class AddressBookAdminPrincipal(NoGroupPrincipal):
class AddressServiceTest(unittest.TestCase): class AddressServiceTest(unittest.TestCase):
def setUp(self) -> None: def setUp(self) -> None:
engine = create_engine("sqlite:///:memory:") self.engine = create_engine("sqlite:///:memory:")
Base.metadata.create_all( Base.metadata.create_all(
engine, self.engine,
tables=[ tables=[
AddressBook.__table__, AddressBook.__table__,
AddressList.__table__, AddressList.__table__,
@@ -176,9 +176,14 @@ class AddressServiceTest(unittest.TestCase):
ChangeSequenceEntry.__table__, ChangeSequenceEntry.__table__,
], ],
) )
self.session = sessionmaker(bind=engine)() self.session = sessionmaker(bind=self.engine)()
self.principal = Principal() self.principal = Principal()
def tearDown(self) -> None:
self.session.close()
Base.metadata.drop_all(bind=self.engine)
self.engine.dispose()
def test_group_book_creation_requires_membership_or_admin_scope(self) -> None: def test_group_book_creation_requires_membership_or_admin_scope(self) -> None:
with self.assertRaisesRegex(AddressBookError, "selected group is not visible"): with self.assertRaisesRegex(AddressBookError, "selected group is not visible"):
create_address_book( create_address_book(