GovOPlaN/govoplan-campaign
1
0
Fork 0
Code Issues 46 Pull Requests Actions Packages Projects Releases Wiki Activity

Use the central Dialog for Campaign previews

Browse Source
This commit is contained in:
Albrecht Degering
2026-07-21 03:17:11 +02:00
parent 35b3cc151d
commit 04c214b149
4 changed files with 33 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
webui/tests/message-preview-overlay-structure.test.mjs
View File

@@ -15,8 +15,10 @@ assert(
"message previews expose their responsive backdrop hook"
);
assert(
overlaySource.includes('type="button" className="modal-close" aria-label={closeLabel} title={closeLabel}'),
"the close control has stable button semantics, an accessible name, and a tooltip"
overlaySource.includes("<Dialog") &&
overlaySource.includes("closeLabel={closeLabel}") &&
overlaySource.includes('dataset.dialogStackState !== "topmost"'),
"message previews use the central stacked Dialog with an accessible close label"
);
assert(
styles.includes("height: min(780px, calc(100dvh - 48px));"),

2
webui/tests/review-preview-ui.test.ts
View File

@@ -103,7 +103,7 @@ for (const [key, english, german] of newTranslations) {
const overlaySource = readFileSync("src/features/campaigns/components/MessagePreviewOverlay.tsx", "utf8");
assert(overlaySource.includes("message-preview-backdrop"), "message previews expose a layout-specific responsive backdrop hook");
assert(overlaySource.includes("{actions && <div"), "built-message footer actions remain in the stable shared preview footer");
assert(overlaySource.includes('aria-label={closeLabel}'), "the preview close control has an accessible label");
assert(overlaySource.includes("<Dialog") && overlaySource.includes("closeLabel={closeLabel}"), "the preview uses the central Dialog and its accessible close label");
const styles = readFileSync("src/styles/campaign-workspace.css", "utf8");
assert(styles.includes("height: min(780px, calc(100dvh - 48px));"), "desktop previews use a stable responsive height");