GovOPlaN/govoplan-campaign
1
0
Fork 0
Code Issues 46 Pull Requests Actions Packages Projects Releases Wiki Activity

Clean Campaign audit and test resources

Browse Source
This commit is contained in:
Albrecht Degering
2026-07-21 03:17:11 +02:00
parent c54fec4cc3
commit 35b3cc151d
4 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/govoplan_campaign/backend/campaign/models.py
View File

@@ -31,7 +31,7 @@ class FieldType(StrEnum):
INTEGER = "integer" INTEGER = "integer"
DOUBLE = "double" DOUBLE = "double"
DATE = "date" DATE = "date"
PASSWORD = "password" PASSWORD = "password" # noqa: S105 # nosec B105 - field type vocabulary.
class RecipientType(StrEnum): class RecipientType(StrEnum):

2
src/govoplan_campaign/backend/reports/campaigns.py
View File

@@ -81,7 +81,7 @@ def _load_delivery_info(version: CampaignVersion | None, jobs: list[CampaignJob]
"execution_snapshot_hash": None, "execution_snapshot_hash": None,
"execution_snapshot_at": None, "execution_snapshot_at": None,
"snapshot_version": None, "snapshot_version": None,
"build_token": None, "build_token": None, # nosec B105 - absent report value, not a credential.
"built_at": None, "built_at": None,
"job_manifest_sha256": None, "job_manifest_sha256": None,
"job_count": 0, "job_count": 0,

2
src/govoplan_campaign/backend/services/zip_service.py
View File

@@ -41,7 +41,7 @@ def _normalized_members(files: Iterable[Path | ArchiveMember]) -> list[ArchiveMe
def create_zip_archive( def create_zip_archive(
output_path: Path, output_path: Path,
files: Iterable[Path | ArchiveMember], files: Iterable[Path | ArchiveMember],
password: str = "", password: str = "", # nosec B107 - empty means an unencrypted archive.
method: str = ZIP_METHOD_AES, method: str = ZIP_METHOD_AES,
) -> Path: ) -> Path:
"""Create a ZIP archive, optionally using AES or legacy ZipCrypto encryption.""" """Create a ZIP archive, optionally using AES or legacy ZipCrypto encryption."""

8
tests/test_access_provider.py
View File

@@ -21,6 +21,7 @@ GROUP_ID = "group-1"
class CampaignAccessProviderTests(unittest.TestCase): class CampaignAccessProviderTests(unittest.TestCase):
def test_campaign_access_provider_explains_owner_share_admin_and_missing_resources(self) -> None: def test_campaign_access_provider_explains_owner_share_admin_and_missing_resources(self) -> None:
session = _session() session = _session()
self.addCleanup(_close_session, session)
_seed_access_subjects(session) _seed_access_subjects(session)
owned = Campaign(id="campaign-owned", tenant_id=TENANT_ID, owner_user_id=USER_ID, external_id="owned", name="Owned campaign") owned = Campaign(id="campaign-owned", tenant_id=TENANT_ID, owner_user_id=USER_ID, external_id="owned", name="Owned campaign")
shared = Campaign(id="campaign-shared", tenant_id=TENANT_ID, owner_user_id=OTHER_USER_ID, external_id="shared", name="Shared campaign") shared = Campaign(id="campaign-shared", tenant_id=TENANT_ID, owner_user_id=OTHER_USER_ID, external_id="shared", name="Shared campaign")
@@ -46,6 +47,7 @@ class CampaignAccessProviderTests(unittest.TestCase):
def test_campaign_access_provider_requires_write_share_for_write_actions(self) -> None: def test_campaign_access_provider_requires_write_share_for_write_actions(self) -> None:
session = _session() session = _session()
self.addCleanup(_close_session, session)
_seed_access_subjects(session) _seed_access_subjects(session)
campaign = Campaign(id="campaign-write", tenant_id=TENANT_ID, owner_user_id=OTHER_USER_ID, external_id="write", name="Write campaign") campaign = Campaign(id="campaign-write", tenant_id=TENANT_ID, owner_user_id=OTHER_USER_ID, external_id="write", name="Write campaign")
session.add_all([ session.add_all([
@@ -74,6 +76,12 @@ def _session():
return sessionmaker(bind=engine, future=True)() return sessionmaker(bind=engine, future=True)()
def _close_session(session) -> None:
engine = session.get_bind()
session.close()
engine.dispose()
def _seed_access_subjects(session) -> None: def _seed_access_subjects(session) -> None:
session.add_all([ session.add_all([
Account(id="account-1", email="one@example.test", normalized_email="one@example.test"), Account(id="account-1", email="one@example.test", normalized_email="one@example.test"),