fix(campaign): query reports before pagination

2026-07-22 08:31:43 +02:00
parent 60efd1cb5d
commit aa4ec66b7b
9 changed files with 603 additions and 131 deletions
--- a/webui/src/api/campaigns.ts
+++ b/webui/src/api/campaigns.ts
@@ -1,5 +1,6 @@
 import type { ApiSettings, CampaignListItem, DeltaDeletedItem } from "../types";
 import { apiDownload, apiFetch } from "./client";
+import { campaignJobsQueryParams, type CampaignJobsQueryParameters } from "../features/campaigns/utils/jobListQuery";
 export { fetchResourceAccessExplanation } from "@govoplan/core-webui";
 export type {
  AccessDecisionProvenanceItem,
@@ -404,16 +405,7 @@ export type CampaignSendJobPayload = {
 };


-export type CampaignJobsQuery = {
-  versionId?: string;
-  page?: number;
-  pageSize?: number;
-  cursor?: string | null;
-  sendStatus?: string[];
-  validationStatus?: string[];
-  imapStatus?: string[];
-  query?: string;
-};
+export type CampaignJobsQuery = Omit<CampaignJobsQueryParameters, "since" | "limit">;

 export type CampaignJobsResponse = {
  jobs: Record<string, unknown>[];
@@ -801,15 +793,7 @@ settings: ApiSettings,
 campaignId: string,
 options: CampaignJobsQuery = {})
 : Promise<CampaignJobsResponse> {
-  const params = new URLSearchParams();
-  if (options.versionId) params.set("version_id", options.versionId);
-  if (options.page) params.set("page", String(options.page));
-  if (options.pageSize) params.set("page_size", String(options.pageSize));
-  if (options.cursor) params.set("cursor", options.cursor);
-  for (const value of options.sendStatus ?? []) params.append("send_status", value);
-  for (const value of options.validationStatus ?? []) params.append("validation_status", value);
-  for (const value of options.imapStatus ?? []) params.append("imap_status", value);
-  if (options.query?.trim()) params.set("q", options.query.trim());
+  const params = campaignJobsQueryParams(options);
  const suffix = params.size > 0 ? `?${params.toString()}` : "";
  return apiFetch<CampaignJobsResponse>(settings, `/api/v1/campaigns/${campaignId}/jobs${suffix}`);
 }
@@ -819,17 +803,7 @@ settings: ApiSettings,
 campaignId: string,
 options: CampaignJobsQuery & {since?: string | null;limit?: number;} = {})
 : Promise<CampaignJobsDeltaResponse> {
-  const params = new URLSearchParams();
-  if (options.versionId) params.set("version_id", options.versionId);
-  if (options.page) params.set("page", String(options.page));
-  if (options.pageSize) params.set("page_size", String(options.pageSize));
-  if (options.cursor) params.set("cursor", options.cursor);
-  for (const value of options.sendStatus ?? []) params.append("send_status", value);
-  for (const value of options.validationStatus ?? []) params.append("validation_status", value);
-  for (const value of options.imapStatus ?? []) params.append("imap_status", value);
-  if (options.query?.trim()) params.set("q", options.query.trim());
-  if (options.since) params.set("since", options.since);
-  if (options.limit) params.set("limit", String(options.limit));
+  const params = campaignJobsQueryParams(options);
  const suffix = params.size > 0 ? `?${params.toString()}` : "";
  return apiFetch<CampaignJobsDeltaResponse>(settings, `/api/v1/campaigns/${campaignId}/jobs/delta${suffix}`);
 }
--- a/webui/src/features/campaigns/CampaignReportPage.tsx
+++ b/webui/src/features/campaigns/CampaignReportPage.tsx
@@ -5,7 +5,7 @@ import {
  downloadCampaignJobsCsv,
  emailCampaignReport,
  getCampaignJobDetail,
-  getCampaignJobsDelta,
+  getCampaignJobs,
  resolveCampaignJobOutcome,
  retryCampaignJobs,
  sendCampaignJob,
@@ -16,16 +16,18 @@ import {
 import { Card } from "@govoplan/core-webui";
 import { Button } from "@govoplan/core-webui";
 import { ConfirmDialog } from "@govoplan/core-webui";
-import { DataGrid, type DataGridColumn, type DataGridListOption } from "@govoplan/core-webui";
+import { DataGrid, type DataGridColumn, type DataGridListOption, type DataGridQueryState } from "@govoplan/core-webui";
 import { Dialog } from "@govoplan/core-webui";
 import { DismissibleAlert } from "@govoplan/core-webui";
+import { FormField } from "@govoplan/core-webui";
 import { PageTitle } from "@govoplan/core-webui";
 import { StatusBadge } from "@govoplan/core-webui";
 import VersionLine from "./components/VersionLine";
-import { LoadingFrame, TableActionGroup, ToggleSwitch, i18nMessage, useDeltaWatermarks } from "@govoplan/core-webui";
+import { LoadingFrame, TableActionGroup, ToggleSwitch, i18nMessage } from "@govoplan/core-webui";
 import { useCampaignWorkspaceData } from "./hooks/useCampaignWorkspaceData";
 import { asRecord, formatDateTime, humanize } from "./utils/campaignView";
-import { emptyCampaignJobsResponse, mergeCampaignJobsDelta } from "./utils/jobDeltas";
+import { emptyCampaignJobsResponse } from "./utils/jobDeltas";
+import type { CampaignJobSortColumn } from "./utils/jobListQuery";

 const SEND_STATUS_OPTIONS: DataGridListOption[] = [
 "not_queued",
@@ -43,16 +45,37 @@ map((value) => ({ value, label: humanize(value) }));
 const IMAP_STATUS_OPTIONS: DataGridListOption[] = [
 "not_requested",
 "pending",
+"appending",
 "appended",
+"outcome_unknown",
 "failed",
 "skipped"].
 map((value) => ({ value, label: humanize(value) }));

+const VALIDATION_STATUS_OPTIONS: DataGridListOption[] = [
+"ready",
+"warning",
+"needs_review",
+"blocked",
+"excluded",
+"inactive"].
+map((value) => ({ value, label: humanize(value) }));
+
+const QUEUE_STATUS_OPTIONS: DataGridListOption[] = [
+"draft",
+"queued",
+"sending",
+"paused",
+"cancelled"].
+map((value) => ({ value, label: humanize(value) }));
+
+const DEFAULT_JOB_GRID_SORT = { columnId: "number", direction: "asc" as const };
+const JOB_GRID_QUERY_DELAY_MS = 300;
+
 type ReconcileRequest = {jobId: string;decision: "smtp_accepted" | "not_sent";} | null;

 export default function CampaignReportPage({ settings, campaignId }: {settings: ApiSettings;campaignId: string;}) {
  const { data, loading, error, reload } = useCampaignWorkspaceData(settings, campaignId, { includeSummary: true });
-  const { getDeltaWatermark, setDeltaWatermark, resetDeltaWatermark } = useDeltaWatermarks();
  const version = data.currentVersion;
  const cards = data.summary?.cards;
  const delivery = asRecord(data.summary?.delivery);
@@ -60,14 +83,19 @@ export default function CampaignReportPage({ settings, campaignId }: {settings:
  const imapPolicy = asRecord(delivery.imap_append_sent);

  const [jobs, setJobs] = useState<CampaignJobsResponse>(() => emptyCampaignJobsResponse());
-  const jobsRef = useRef<CampaignJobsResponse>(emptyCampaignJobsResponse());
-  const jobPageCursorsRef = useRef<Record<number, string | null>>({ 1: null });
+  const jobsRequestRef = useRef(0);
  const [jobsLoading, setJobsLoading] = useState(false);
  const [page, setPage] = useState(1);
-  const [sendStatus, setSendStatus] = useState("");
-  const [imapStatus, setImapStatus] = useState("");
-  const [query, setQuery] = useState("");
-  const [appliedQuery, setAppliedQuery] = useState("");
+  const [pageSize, setPageSize] = useState(50);
+  const [initialGridFilters] = useState<Record<string, string | string[]>>(() => initialReportGridFilters());
+  const initialGridQuery = useMemo<DataGridQueryState>(() => ({
+    sort: DEFAULT_JOB_GRID_SORT,
+    filters: serializeInitialGridFilters(initialGridFilters)
+  }), [initialGridFilters]);
+  const [jobGridQuery, setJobGridQuery] = useState<DataGridQueryState>(initialGridQuery);
+  const [appliedJobGridQuery, setAppliedJobGridQuery] = useState<DataGridQueryState>(initialGridQuery);
+  const [query, setQuery] = useState(() => initialReportQuery());
+  const [appliedQuery, setAppliedQuery] = useState(query.trim());
  const [actionMessage, setActionMessage] = useState("");
  const [actionError, setActionError] = useState("");
  const [busyAction, setBusyAction] = useState("");
@@ -81,86 +109,46 @@ export default function CampaignReportPage({ settings, campaignId }: {settings:
  useEffect(() => {
    const handle = window.setTimeout(() => {
      setAppliedQuery(query.trim());
+      setAppliedJobGridQuery((current) => dataGridQueriesEqual(current, jobGridQuery) ? current : jobGridQuery);
      setPage(1);
-    }, 350);
+    }, JOB_GRID_QUERY_DELAY_MS);
    return () => window.clearTimeout(handle);
-  }, [query]);
+  }, [query, jobGridQuery]);

-  const jobsQueryKey = useMemo(
-    () => JSON.stringify({
-      campaignId,
-      versionId: version?.id ?? null,
-      page,
-      pageSize: 50,
-      sendStatus,
-      imapStatus,
-      appliedQuery,
-      apiBaseUrl: settings.apiBaseUrl,
-      apiKey: settings.apiKey,
-      accessToken: settings.accessToken
-    }),
-    [campaignId, version?.id, page, sendStatus, imapStatus, appliedQuery, settings.apiBaseUrl, settings.apiKey, settings.accessToken]
-  );
-
-  useEffect(() => {
-    jobPageCursorsRef.current = { 1: null };
-  }, [campaignId, version?.id, sendStatus, imapStatus, appliedQuery, settings.apiBaseUrl, settings.apiKey, settings.accessToken]);
+  const handleJobGridQuery = useCallback((next: DataGridQueryState) => {
+    setJobGridQuery((current) => dataGridQueriesEqual(current, next) ? current : next);
+  }, []);

  const loadJobs = useCallback(async () => {
    if (!campaignId) return;
+    const requestId = ++jobsRequestRef.current;
    setJobsLoading(true);
    setActionError("");
    try {
-      let nextWatermark = getDeltaWatermark(jobsQueryKey);
-      let merged = jobsRef.current;
-      let hasMore = false;
-      const pageCursor = page === 1 ? null : jobPageCursorsRef.current[page];
-      do {
-        const response = await getCampaignJobsDelta(settings, campaignId, {
-          versionId: version?.id,
-          page,
-          pageSize: 50,
-          cursor: pageCursor,
-          sendStatus: sendStatus ? [sendStatus] : undefined,
-          imapStatus: imapStatus ? [imapStatus] : undefined,
-          query: appliedQuery || undefined,
-          since: nextWatermark
-        });
-        merged = mergeCampaignJobsDelta(merged, response);
-        if (response.cursor !== undefined) jobPageCursorsRef.current[page] = response.cursor ?? null;
-        if (response.next_cursor !== undefined) {
-          if (response.next_cursor) jobPageCursorsRef.current[page + 1] = response.next_cursor;
-          else delete jobPageCursorsRef.current[page + 1];
-        }
-        nextWatermark = response.watermark ?? null;
-        hasMore = response.has_more;
-      } while (hasMore);
-      setDeltaWatermark(jobsQueryKey, nextWatermark);
-      jobsRef.current = merged;
-      setJobs(merged);
-      if (merged.pages > 0 && page > merged.pages) setPage(merged.pages);
+      const response = await getCampaignJobs(settings, campaignId, {
+        versionId: version?.id,
+        page,
+        pageSize,
+        query: appliedQuery || undefined,
+        sortBy: campaignJobSortColumn(appliedJobGridQuery.sort?.columnId),
+        sortDirection: appliedJobGridQuery.sort?.direction ?? "asc",
+        filters: appliedJobGridQuery.filters
+      });
+      if (requestId !== jobsRequestRef.current) return;
+      setJobs(response);
+      if (response.pages > 0 && page > response.pages) setPage(response.pages);
    } catch (err) {
-      setActionError(err instanceof Error ? err.message : String(err));
+      if (requestId === jobsRequestRef.current) setActionError(err instanceof Error ? err.message : String(err));
    } finally {
-      setJobsLoading(false);
+      if (requestId === jobsRequestRef.current) setJobsLoading(false);
    }
-  }, [settings, campaignId, version?.id, page, sendStatus, imapStatus, appliedQuery, jobsQueryKey, getDeltaWatermark, setDeltaWatermark]);
-
-  useEffect(() => {
-    resetDeltaWatermark(jobsQueryKey);
-    jobsRef.current = emptyCampaignJobsResponse();
-    setJobs(emptyCampaignJobsResponse());
-  }, [jobsQueryKey, resetDeltaWatermark]);
+  }, [settings, campaignId, version?.id, page, pageSize, appliedQuery, appliedJobGridQuery]);

  useEffect(() => {
    void loadJobs();
  }, [loadJobs]);

  async function reloadAll() {
-    resetDeltaWatermark(jobsQueryKey);
-    jobPageCursorsRef.current = { 1: null };
-    jobsRef.current = emptyCampaignJobsResponse();
-    setJobs(emptyCampaignJobsResponse());
    await Promise.all([reload({ force: true }), loadJobs()]);
  }

@@ -327,10 +315,10 @@ export default function CampaignReportPage({ settings, campaignId }: {settings:
    value: (row) => String(row.recipient_email ?? "—")
  },
  { id: "subject", header: "i18n:govoplan-campaign.subject.8d183dbd", width: "minmax(260px, 1fr)", resizable: true, sortable: true, filterable: true, value: (row) => String(row.subject ?? "—") },
-  { id: "validation", header: "i18n:govoplan-campaign.validation.dd74d182", width: 145, sortable: true, filterable: true, render: (row) => <StatusBadge status={String(row.validation_status ?? "unknown")} />, value: (row) => String(row.validation_status ?? "unknown") },
-  { id: "queue", header: "i18n:govoplan-campaign.queue.d325fcd9", width: 130, sortable: true, filterable: true, render: (row) => <StatusBadge status={String(row.queue_status ?? "unknown")} />, value: (row) => String(row.queue_status ?? "unknown") },
+  { id: "validation", header: "i18n:govoplan-campaign.validation.dd74d182", width: 145, sortable: true, filterable: true, columnType: "from-list", list: { options: VALIDATION_STATUS_OPTIONS, display: "pill" }, render: (row) => <StatusBadge status={String(row.validation_status ?? "unknown")} />, value: (row) => String(row.validation_status ?? "unknown") },
+  { id: "queue", header: "i18n:govoplan-campaign.queue.d325fcd9", width: 130, sortable: true, filterable: true, columnType: "from-list", list: { options: QUEUE_STATUS_OPTIONS, display: "pill" }, render: (row) => <StatusBadge status={String(row.queue_status ?? "unknown")} />, value: (row) => String(row.queue_status ?? "unknown") },
  { id: "send", header: "i18n:govoplan-campaign.smtp.efff9cca", width: 160, sortable: true, filterable: true, columnType: "from-list", list: { options: SEND_STATUS_OPTIONS, display: "pill" }, render: (row) => <StatusBadge status={String(row.send_status ?? "unknown")} />, value: (row) => String(row.send_status ?? "unknown") },
-  { id: "imap", header: "i18n:govoplan-campaign.imap.271f9ef2", width: 130, sortable: true, filterable: true, render: (row) => <StatusBadge status={String(row.imap_status ?? "unknown")} />, value: (row) => String(row.imap_status ?? "unknown") },
+  { id: "imap", header: "i18n:govoplan-campaign.imap.271f9ef2", width: 130, sortable: true, filterable: true, columnType: "from-list", list: { options: IMAP_STATUS_OPTIONS, display: "pill" }, render: (row) => <StatusBadge status={String(row.imap_status ?? "unknown")} />, value: (row) => String(row.imap_status ?? "unknown") },
  { id: "attempts", header: "i18n:govoplan-campaign.attempts.5a29585e", width: 105, align: "right", sortable: true, filterType: "integer", value: (row) => Number(row.attempt_count ?? 0) },
  {
    id: "evidence",
@@ -351,7 +339,6 @@ export default function CampaignReportPage({ settings, campaignId }: {settings:
    header: "i18n:govoplan-campaign.last_result.110b888b",
    width: "minmax(220px, 1fr)",
    resizable: true,
-    filterable: true,
    render: (row) => <span className={row.last_error ? "recipient-outcome-error" : "muted"} title={String(row.last_error ?? "")}>{String(row.last_error ?? "—")}</span>,
    value: (row) => String(row.last_error ?? "—")
  },
@@ -428,32 +415,37 @@ export default function CampaignReportPage({ settings, campaignId }: {settings:
        <Card title="i18n:govoplan-campaign.recipient_delivery_jobs.52492608">
          <div className="page-heading split">
            <div className="button-row compact-actions">
-              <input value={query} onChange={(event) => setQuery(event.target.value)} placeholder="i18n:govoplan-campaign.search_recipient_subject_or_entry_id.6d6544f5" />
-              <select value={sendStatus} onChange={(event) => {setSendStatus(event.target.value);setPage(1);}}>
-                <option value="">i18n:govoplan-campaign.all_smtp_states.739597b1</option>
-                {SEND_STATUS_OPTIONS.map((option) => <option key={option.value} value={option.value}>{option.label}</option>)}
-              </select>
-              <select value={imapStatus} onChange={(event) => {setImapStatus(event.target.value);setPage(1);}}>
-                <option value="">i18n:govoplan-campaign.all_imap_states.8546b84c</option>
-                {IMAP_STATUS_OPTIONS.map((option) => <option key={option.value} value={option.value}>{option.label}</option>)}
-              </select>
+              <FormField label="i18n:govoplan-campaign.search_recipient_subject_or_entry_id.6d6544f5">
+                <input value={query} onChange={(event) => setQuery(event.target.value)} />
+              </FormField>
            </div>
            <span className="muted">{jobs.total} i18n:govoplan-campaign.matching_of.66a3778e {jobs.total_unfiltered} i18n:govoplan-campaign.total_job_s.c94b7d20</span>
          </div>
          <LoadingFrame loading={jobsLoading} label="i18n:govoplan-campaign.loading_delivery_jobs.20ecc37e">
            <DataGrid<Record<string, unknown>>
-              id={`campaign-report-jobs-${campaignId}`}
+              id={`campaign-report-jobs-v2-${campaignId}`}
              rows={jobs.jobs}
              columns={columns}
              getRowKey={(row: Record<string, unknown>) => String(row.id ?? "")}
-              emptyText="i18n:govoplan-campaign.no_jobs_match_the_current_filters.b1501ff5" />
+              emptyText="i18n:govoplan-campaign.no_jobs_match_the_current_filters.b1501ff5"
+              initialFilters={initialGridFilters}
+              initialSort={DEFAULT_JOB_GRID_SORT}
+              pagination={{
+                mode: "server",
+                page,
+                pageSize,
+                totalRows: jobs.total,
+                pageSizeOptions: [25, 50, 100, 200],
+                disabled: jobsLoading,
+                onPageChange: setPage,
+                onPageSizeChange: (nextPageSize) => {
+                  setPageSize(nextPageSize);
+                  setPage(1);
+                }
+              }}
+              onQueryChange={handleJobGridQuery} />
            
          </LoadingFrame>
-          <div className="button-row compact-actions">
-            <Button onClick={() => setPage((value) => Math.max(1, value - 1))} disabled={page <= 1 || jobsLoading}>i18n:govoplan-campaign.previous.50f94286</Button>
-            <span>i18n:govoplan-campaign.page.fb06270f {jobs.pages === 0 ? 0 : jobs.page} of {jobs.pages}</span>
-            <Button onClick={() => setPage((value) => Math.min(jobs.pages || 1, value + 1))} disabled={page >= jobs.pages || jobsLoading}>i18n:govoplan-campaign.next.bc981983</Button>
-          </div>
        </Card>
      </LoadingFrame>

@@ -545,6 +537,58 @@ function AttemptHistoryTable({ kind, rows }: {kind: "smtp" | "imap";rows: Record

 }

+function initialReportGridFilters(): Record<string, string | string[]> {
+  if (typeof window === "undefined") return {};
+  const params = new URLSearchParams(window.location.search);
+  const result: Record<string, string | string[]> = {};
+  const send = statusParameters(params, "send_status", SEND_STATUS_OPTIONS);
+  const imap = statusParameters(params, "imap_status", IMAP_STATUS_OPTIONS);
+  const validation = statusParameters(params, "validation_status", VALIDATION_STATUS_OPTIONS);
+  if (send.length > 0) result.send = send;
+  if (imap.length > 0) result.imap = imap;
+  if (validation.length > 0) result.validation = validation;
+  return result;
+}
+
+function initialReportQuery(): string {
+  if (typeof window === "undefined") return "";
+  return new URLSearchParams(window.location.search).get("q")?.trim() ?? "";
+}
+
+function statusParameters(params: URLSearchParams, name: string, options: DataGridListOption[]): string[] {
+  const allowed = new Set(options.map((option) => option.value));
+  return [...new Set(
+    params.getAll(name).
+    flatMap((value) => value.split(",")).
+    map((value) => value.trim()).
+    filter((value) => allowed.has(value))
+  )];
+}
+
+function serializeInitialGridFilters(filters: Record<string, string | string[]>): Record<string, string> {
+  return Object.fromEntries(Object.entries(filters).map(([columnId, value]) => [
+    columnId,
+    Array.isArray(value) ? `list:${JSON.stringify([...new Set(value)])}` : value
+  ]));
+}
+
+function campaignJobSortColumn(value?: string): CampaignJobSortColumn {
+  if (value === "recipient" || value === "subject" || value === "validation" || value === "queue" || value === "send" || value === "imap" || value === "attempts" || value === "updated") {
+    return value;
+  }
+  return "number";
+}
+
+function dataGridQueriesEqual(left: DataGridQueryState, right: DataGridQueryState): boolean {
+  if ((left.sort?.columnId ?? "") !== (right.sort?.columnId ?? "")) return false;
+  if ((left.sort?.direction ?? "") !== (right.sort?.direction ?? "")) return false;
+  const keys = new Set([...Object.keys(left.filters), ...Object.keys(right.filters)]);
+  for (const key of keys) {
+    if ((left.filters[key] ?? "") !== (right.filters[key] ?? "")) return false;
+  }
+  return true;
+}
+
 function retryableFailedStatus(status: string): boolean {
  return status === "failed_temporary" || status === "failed_permanent";
 }
--- a/webui/src/features/campaigns/utils/jobListQuery.ts
+++ b/webui/src/features/campaigns/utils/jobListQuery.ts
@@ -0,0 +1,58 @@
+export type CampaignJobSortColumn =
+  | "number"
+  | "recipient"
+  | "subject"
+  | "validation"
+  | "queue"
+  | "send"
+  | "imap"
+  | "attempts"
+  | "updated";
+
+export type CampaignJobsQueryParameters = {
+  versionId?: string;
+  page?: number;
+  pageSize?: number;
+  cursor?: string | null;
+  sendStatus?: string[];
+  validationStatus?: string[];
+  imapStatus?: string[];
+  query?: string;
+  sortBy?: CampaignJobSortColumn;
+  sortDirection?: "asc" | "desc";
+  filters?: Record<string, string>;
+  since?: string | null;
+  limit?: number;
+};
+
+const FILTER_PARAMETERS: Record<string, string> = {
+  recipient: "filter_recipient",
+  subject: "filter_subject",
+  validation: "filter_validation",
+  queue: "filter_queue",
+  send: "filter_send",
+  imap: "filter_imap",
+  attempts: "filter_attempts",
+  evidence: "filter_evidence"
+};
+
+export function campaignJobsQueryParams(options: CampaignJobsQueryParameters = {}): URLSearchParams {
+  const params = new URLSearchParams();
+  if (options.versionId) params.set("version_id", options.versionId);
+  if (options.page) params.set("page", String(options.page));
+  if (options.pageSize) params.set("page_size", String(options.pageSize));
+  if (options.cursor) params.set("cursor", options.cursor);
+  for (const value of options.sendStatus ?? []) params.append("send_status", value);
+  for (const value of options.validationStatus ?? []) params.append("validation_status", value);
+  for (const value of options.imapStatus ?? []) params.append("imap_status", value);
+  if (options.query?.trim()) params.set("q", options.query.trim());
+  if (options.sortBy) params.set("sort_by", options.sortBy);
+  if (options.sortDirection) params.set("sort_direction", options.sortDirection);
+  for (const [columnId, value] of Object.entries(options.filters ?? {})) {
+    const parameter = FILTER_PARAMETERS[columnId];
+    if (parameter && value.trim()) params.set(parameter, value);
+  }
+  if (options.since) params.set("since", options.since);
+  if (options.limit) params.set("limit", String(options.limit));
+  return params;
+}