feat: harden campaign delivery and editing

src/govoplan_campaign/backend/routes/delivery.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import logging
 
 from fastapi import APIRouter, Depends, HTTPException, status
 from sqlalchemy.orm import Session
@@ -74,6 +75,7 @@ from govoplan_campaign.backend.route_support import (
 )
 
 router = APIRouter(prefix="/campaigns", tags=["campaigns"])
+logger = logging.getLogger(__name__)
 
 
 @router.get(
@@ -236,13 +238,25 @@ def send_unattempted_campaign_jobs(
 def send_single_campaign_job_endpoint(
     campaign_id: str,
     job_id: str,
-    payload: CampaignSendJobRequest | None = None,
+    payload: CampaignSendJobRequest,
     session: Session = Depends(get_session),
-    principal: ApiPrincipal = Depends(require_scope("campaigns:campaign:send")),
+    principal: ApiPrincipal = Depends(
+        require_any_scope(
+            "campaigns:campaign:send",
+            "campaigns:campaign:send_test",
+        )
+    ),
 ):
     _get_campaign_for_principal(session, campaign_id, principal, write=True)
     _require_permission(principal, "campaigns:recipient:read")
-    payload = payload or CampaignSendJobRequest()
+    _require_permission(
+        principal,
+        (
+            "campaigns:campaign:send_test"
+            if payload.kind == "test"
+            else "campaigns:campaign:send"
+        ),
+    )
     _require_campaign_profile_use_if_needed(session, principal, campaign_id, None)
     try:
         result = send_single_campaign_job(
@@ -250,17 +264,20 @@ def send_single_campaign_job_endpoint(
             tenant_id=principal.tenant_id,
             campaign_id=campaign_id,
             job_id=job_id,
+            kind=payload.kind,
+            idempotency_key=payload.idempotency_key,
+            actor_user_id=principal.user.id,
+            actor_api_key_id=getattr(principal, "api_key_id", None),
+            reason=payload.reason,
+            action_context=payload.context,
             include_warnings=payload.include_warnings,
-            dry_run=payload.dry_run,
             use_rate_limit=payload.use_rate_limit,
             enqueue_imap_task=payload.enqueue_imap_task,
         )
         audit_from_principal(
             session,
             principal,
-            action="campaign.single_message_sent"
-            if not payload.dry_run
-            else "campaign.single_message_send_dry_run",
+            action=f"campaign.message_{payload.kind}",
             object_type="campaign_job",
             object_id=job_id,
             details=result,
@@ -272,8 +289,17 @@ def send_single_campaign_job_endpoint(
             status_code=status.HTTP_422_UNPROCESSABLE_CONTENT, detail=str(exc)
         ) from exc
     except Exception as exc:
+        logger.exception(
+            "Unexpected single-message campaign action failure",
+            extra={
+                "campaign_id": campaign_id,
+                "job_id": job_id,
+                "action_kind": payload.kind,
+            },
+        )
         raise HTTPException(
-            status_code=status.HTTP_422_UNPROCESSABLE_CONTENT, detail=str(exc)
+            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+            detail="The message action failed because of an internal error.",
         ) from exc