feat: harden campaign delivery and editing

src/govoplan_campaign/backend/routes/reports.py

@@ -25,9 +25,11 @@ from govoplan_campaign.backend.reports.emailing import (
     send_campaign_report_email,
 )
 from govoplan_campaign.backend.integrations import (
+    MailDeliveryCommandError,
     MailProfileError,
     SmtpConfigurationError,
     SmtpSendError,
+    mail_integration,
 )
 
 
@@ -41,6 +43,24 @@ router = APIRouter(prefix="/campaigns", tags=["campaigns"])
 logger = logging.getLogger(__name__)
 
 
+def _enqueue_mail_command() -> None:
+    try:
+        from govoplan_core.celery_app import celery
+        from govoplan_core.settings import settings
+
+        if settings.celery_enabled:
+            celery.send_task(
+                "govoplan.mail.dispatch_outbox",
+                args=[None, 25],
+                queue="mail",
+            )
+    except Exception:
+        logger.warning(
+            "Mail delivery command is durable but immediate worker wake-up failed",
+            exc_info=True,
+        )
+
+
 @router.get("/{campaign_id}/summary")
 def campaign_summary(
     campaign_id: str,
@@ -164,18 +184,22 @@ def email_campaign_report(
             attach_jobs_csv=payload.attach_jobs_csv,
             attach_report_json=payload.attach_report_json,
             dry_run=payload.dry_run,
+            idempotency_key=payload.idempotency_key,
+            created_by_user_id=principal.user.id,
         )
         audit_from_principal(
             session,
             principal,
-            action="report.email_sent"
+            action="report.email_requested"
             if not payload.dry_run
             else "report.email_dry_run",
             object_type="campaign",
             object_id=campaign_id,
-            details=result.as_dict(),
+            details=result.audit_dict(),
             commit=True,
         )
+        if not payload.dry_run:
+            _enqueue_mail_command()
         return ReportEmailResponse(result=result.as_dict())
     except CampaignReportError as exc:
         raise HTTPException(
@@ -184,6 +208,7 @@ def email_campaign_report(
     except (
         CampaignReportEmailError,
         MailProfileError,
+        MailDeliveryCommandError,
         SmtpConfigurationError,
         SmtpSendError,
     ) as exc:
@@ -196,3 +221,37 @@ def email_campaign_report(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
             detail="Campaign report email could not be completed.",
         ) from exc
+
+
+@router.get(
+    "/{campaign_id}/report/email/{command_id}",
+    response_model=ReportEmailResponse,
+)
+def campaign_report_email_status(
+    campaign_id: str,
+    command_id: str,
+    session: Session = Depends(get_session),
+    principal: ApiPrincipal = Depends(require_scope("campaigns:report:read")),
+):
+    _get_campaign_for_principal(session, campaign_id, principal)
+    try:
+        result = mail_integration().delivery_command_summary(
+            session,
+            tenant_id=principal.tenant_id,
+            command_id=command_id,
+        )
+    except MailDeliveryCommandError as exc:
+        raise HTTPException(
+            status_code=status.HTTP_404_NOT_FOUND,
+            detail=str(exc),
+        ) from exc
+    if (
+        result.get("source_module") != "campaigns"
+        or result.get("source_resource_type") != "campaign"
+        or result.get("source_resource_id") != campaign_id
+    ):
+        raise HTTPException(
+            status_code=status.HTTP_404_NOT_FOUND,
+            detail="Campaign report delivery not found",
+        )
+    return ReportEmailResponse(result=result)