GovOPlaN/govoplan-campaign
2
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

[Feature] Add approval workflow and separation-of-duties gates #22

New Issue
Closed
opened 2026-07-06 11:23:58 +02:00 by zemion · 2 comments
zemion commented 2026-07-06 11:23:58 +02:00
Owner
Copy Link
Copy Source

Imported from the consolidated GovOPlaN product backlog.

  • Source: /mnt/DATA/Nextcloud/ADD ideas UG/Products/govoplan/backlog.md
  • Line: 177
  • Section: Milestones > Milestone 10 - Collaboration And Advanced Governance
  • Source status: PARTIAL.

Imported backlog item:

- [ ] Add approval workflow and separation-of-duties gates.
<!-- codex-backlog-fingerprint:55958ead110c40a257ac82cf --> Imported from the consolidated GovOPlaN product backlog. - Source: `/mnt/DATA/Nextcloud/ADD ideas UG/Products/govoplan/backlog.md` - Line: `177` - Section: `Milestones > Milestone 10 - Collaboration And Advanced Governance` - Source status: `PARTIAL.` Imported backlog item: ```markdown - [ ] Add approval workflow and separation-of-duties gates. ```
zemion added this to the Milestone 10 - Collaboration And Advanced Governance milestone 2026-07-06 13:14:37 +02:00
zemion commented 2026-07-31 22:54:25 +02:00
Author
Owner
Copy Link
Copy Source

Evaluation and bounded evidence work completed in GovOPlaN/govoplan-campaign@82ddc0c.

Campaign validation and build summaries now record actor/timestamp provenance; review already records the reviewer, immutable build token, message digest, inspected keys, and per-exception reasons. This is enough evidence for a future separation-of-duties decision, but it is not itself an approval.

A Campaign-local approve switch would duplicate the existing module boundary. Generic chains, eligible authority, quorum, delegation/substitution, escalation, expiry, and signatures belong to the currently scaffold-only Approvals module. I created Approvals #1 with the runtime acceptance criteria and remaining policy decisions. Keep this issue open as the Campaign consumer/gate integration after that capability exists.

Evaluation and bounded evidence work completed in GovOPlaN/govoplan-campaign@82ddc0c. Campaign validation and build summaries now record actor/timestamp provenance; review already records the reviewer, immutable build token, message digest, inspected keys, and per-exception reasons. This is enough evidence for a future separation-of-duties decision, but it is not itself an approval. A Campaign-local approve switch would duplicate the existing module boundary. Generic chains, eligible authority, quorum, delegation/substitution, escalation, expiry, and signatures belong to the currently scaffold-only Approvals module. I created [Approvals #1](https://git.add-ideas.de/GovOPlaN/govoplan-approvals/issues/1) with the runtime acceptance criteria and remaining policy decisions. Keep this issue open as the Campaign consumer/gate integration after that capability exists.
zemion added
status
needs-info
 and removed
status
triage
 labels 2026-07-31 22:54:51 +02:00
zemion commented 2026-08-01 21:02:42 +02:00
Author
Owner
Copy Link
Copy Source

Codex State: done

Summary

  • Implemented an optional exact-execution-snapshot Approval gate with Campaign actor evidence, configurable authority/quorum/signature and separation-of-duties exclusions, UI request/status flow, and enforcement across synchronous, queued, retry, and single-message live delivery.
  • Campaign remains usable without Approvals; a configured gate fails closed if the capability is unavailable or the execution changes. Pushed as GovOPlaN/govoplan-campaign@2afdd38.

Changed Files

  • src/govoplan_campaign/backend/approval_gate.py
  • src/govoplan_campaign/backend/routes/delivery.py
  • webui/src/features/campaigns/ReviewSendPage.tsx

Verification

  • All 80 Campaign backend tests passed.
  • Approval integration tests passed (2 tests); full WebUI module permutations passed.
## Codex State: done ### Summary - Implemented an optional exact-execution-snapshot Approval gate with Campaign actor evidence, configurable authority/quorum/signature and separation-of-duties exclusions, UI request/status flow, and enforcement across synchronous, queued, retry, and single-message live delivery. - Campaign remains usable without Approvals; a configured gate fails closed if the capability is unavailable or the execution changes. Pushed as GovOPlaN/govoplan-campaign@2afdd38. ### Changed Files - `src/govoplan_campaign/backend/approval_gate.py` - `src/govoplan_campaign/backend/routes/delivery.py` - `webui/src/features/campaigns/ReviewSendPage.tsx` ### Verification - `All 80 Campaign backend tests passed.` - `Approval integration tests passed (2 tests); full WebUI module permutations passed.`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
HTTP API contracts, routers, schemas, or API smoke behavior.
 area/auth
Authentication, sessions, access bootstrap, or login behavior.
 area/db
Database sessions, models, transactions, or persistence primitives.
 area/devex
Local developer workflow, scripts, tests, tooling, or release helpers.
 area/docs
Durable documentation and project guidance.
 area/governance
Governance policy, audit, privacy, retention, or compliance behavior.
 area/marketing
Public website, product messaging, publication copy, or legal page content.
 area/migrations
Alembic migrations, schema bootstrap, or persistence evolution.
 area/module-system
Module discovery, manifests, capabilities, routing, or optional integrations.
 area/rbac
Permissions, roles, delegation, or authorization policy.
 area/release
Versioning, release locks, tags, packaging, or dependency pins.
 area/security
Security posture, static analysis, supply-chain hardening, or vulnerability remediation.
 area/tenancy
Tenant boundaries, provisioning, or tenant-scoped data behavior.
 area/webui
Shared WebUI shell, frontend components, routing, or frontend tests.
 audit/complexity
Complexity finding from Radon, Xenon, or equivalent maintainability scans.
 audit/duplication
Duplicated-code finding from jscpd or equivalent similarity scans.
 audit/false-positive
Audit finding reviewed as a narrow false positive or acceptable risk.
 audit/needs-design
Audit finding that needs an architectural or product decision before implementation.
 audit/quick-fix
Audit finding that appears narrow and directly fixable.
 audit/structural
Audit finding that needs design, refactoring, or behavior review.
 codex/needs-human
Needs an explicit human decision before Codex should implement.
 codex/ready
Suitable for Codex to pick up with the existing issue context.
 module/access
GovOPlaN access, identity, authentication, RBAC, and administration behavior.
 module/addresses
GovOPlaN Addresses module behavior or integration.
 module/admin
GovOPlaN Admin module behavior or integration.
 module/appointments
GovOPlaN Appointments module behavior or integration.
 module/approvals
GovOPlaN Approvals module behavior or integration.
 module/audit
GovOPlaN Audit module behavior or integration.
 module/calendar
GovOPlaN Calendar module behavior or integration.
 module/campaign
GovOPlaN campaign module behavior or integration.
 module/cases
GovOPlaN Cases module behavior or integration.
 module/committee
GovOPlaN Committee module behavior or integration.
 module/connectors
GovOPlaN Connectors module behavior or integration.
 module/core
GovOPlaN core runner, shared primitives, shell, or extension points.
 module/dashboard
GovOPlaN Dashboard module behavior or integration.
 module/dataflow
GovOPlaN Dataflow module behavior or integration.
 module/datasources
GovOPlaN governed datasource contracts, catalogs, and integrations.
 module/decisions
GovOPlaN formal Decisions module behavior or integration.
 module/dist-lists
GovOPlaN Distribution Lists module behavior or integration.
 module/dms
GovOPlaN Dms module behavior or integration.
 module/docs
GovOPlaN Docs module behavior or integration.
 module/encryption
GovOPlaN Encryption key custody, cryptographic policy, and E2EE integration.
 module/erp
GovOPlaN Erp module behavior or integration.
 module/evaluation
GovOPlaN Evaluation module behavior or integration.
 module/files
GovOPlaN files module behavior or integration.
 module/fit-connect
GovOPlaN Fit Connect module behavior or integration.
 module/forms
GovOPlaN Forms module behavior or integration.
 module/forms-runtime
GovOPlaN Forms Runtime module behavior or integration.
 module/helpdesk
GovOPlaN Helpdesk module behavior or integration.
 module/identity
GovOPlaN Identity module behavior or integration.
 module/identity-trust
GovOPlaN Identity Trust module behavior or integration.
 module/idm
GovOPlaN Idm module behavior or integration.
 module/ledger
GovOPlaN Ledger module behavior or integration.
 module/mail
GovOPlaN mail module behavior or integration.
 module/mandates
GovOPlaN Mandates, jurisdiction, responsibility, and authority behavior or integration.
 module/notifications
GovOPlaN Notifications module behavior or integration.
 module/ops
GovOPlaN Ops module behavior or integration.
 module/organizations
GovOPlaN Organizations module behavior or integration.
 module/parties
GovOPlaN procedure Parties, representation, and delivery-authority behavior or integration.
 module/payments
GovOPlaN Payments module behavior or integration.
 module/permits
GovOPlaN Permits module behavior or integration.
 module/policy
GovOPlaN Policy module behavior or integration.
 module/poll
GovOPlaN Poll module behavior or integration.
 module/portal
GovOPlaN Portal module behavior or integration.
 module/postbox
GovOPlaN Postbox module behavior or integration.
 module/projects
GovOPlaN Projects module behavior or integration.
 module/quick-access
GovOPlaN configurable task-local Quick Access behavior and integrations.
 module/records
GovOPlaN Records and eAkte lifecycle behavior or integration.
 module/reporting
GovOPlaN Reporting module behavior or integration.
 module/risk-compliance
GovOPlaN Risk Compliance module behavior or integration.
 module/scheduling
GovOPlaN Scheduling module behavior or integration.
 module/search
GovOPlaN Search module behavior or integration.
 module/services
GovOPlaN versioned institutional Services behavior or integration.
 module/tasks
GovOPlaN Tasks module behavior or integration.
 module/templates
GovOPlaN Templates module behavior or integration.
 module/tenancy
GovOPlaN Tenancy module behavior or integration.
 module/tickets
GovOPlaN Tickets module behavior or integration.
 module/views
GovOPlaN governed task views, interface projections, and workflow view integration.
 module/voting
GovOPlaN Voting module behavior or integration.
 module/wiki
GovOPlaN Wiki module behavior or integration.
 module/workflow
GovOPlaN Workflow module behavior or integration.
 module/workflow-engine
GovOPlaN Workflow Engine runtime, persistence, or integration.
 module/xoev
GovOPlaN Xoev module behavior or integration.
 module/xrechnung
GovOPlaN Xrechnung module behavior or integration.
 module/xta-osci
GovOPlaN Xta Osci module behavior or integration.
priority
p0
Immediate stop-the-line priority.
priority
p1
High priority for the next focused work window.
priority
p2
Normal planned priority.
priority
p3
Low priority or opportunistic cleanup.
source/backlog-import
Imported from markdown backlog, roadmap, plan, or TODO files.
 source/security-audit
Created from a structured security or code-quality audit report.
 source/todo-scan
Imported from inline TODO/FIXME/HACK markers by the Gitea TODO importer.
status
blocked
Cannot progress without a decision, dependency, credential, or external change.
status
in-progress
Currently being worked.
status
needs-info
Needs clarifying input before implementation can proceed safely.
status
ready
Ready for implementation.
status
triage
Needs review, ownership, priority, or acceptance criteria.
type
bug
A reproducible defect, regression, or incorrect behavior.
type
debt
Cleanup, refactoring, risk reduction, or deferred engineering work.
type
docs
Documentation, process, or developer workflow work.
type
feature
New user-visible behavior or platform capability.
type
task
Implementation, maintenance, migration, or operational work.
type
user-story
End-to-end user journey or real-world process story used to steer product slices.
No labels area/governance codex/needs-human module/campaign
priority
p2
 source/backlog-import
status
needs-info
type
feature
Milestone
No items
No Milestone Milestone 10 - Collaboration And Advanced Governance
Projects
Clear projects
No projects
Assignees
Clear assignees
govoplan-package-publisher zemion (Albrecht Degering)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GovOPlaN/govoplan-campaign#22