GovOPlaN/govoplan-campaign
2
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

[Debt] Split large frontend components only along stable feature boundaries; avoid churn before recipient import/report/test-bed work #45

New Issue
Closed
opened 2026-07-06 11:26:36 +02:00 by zemion · 5 comments
zemion commented 2026-07-06 11:26:36 +02:00
Owner
Copy Link
Copy Source

Imported from the consolidated GovOPlaN product backlog.

  • Source: /mnt/DATA/Nextcloud/ADD ideas UG/Products/govoplan/backlog.md
  • Line: 259
  • Section: Deferred Cleanup Notes

Imported backlog item:

- [ ] Split large frontend components only along stable feature boundaries; avoid churn before recipient import/report/test-bed work.
<!-- codex-backlog-fingerprint:36fe6bf59209cfb0a9a6c519 --> Imported from the consolidated GovOPlaN product backlog. - Source: `/mnt/DATA/Nextcloud/ADD ideas UG/Products/govoplan/backlog.md` - Line: `259` - Section: `Deferred Cleanup Notes` Imported backlog item: ```markdown - [ ] Split large frontend components only along stable feature boundaries; avoid churn before recipient import/report/test-bed work. ```
zemion added this to the Deferred Cleanup milestone 2026-07-06 13:20:06 +02:00
zemion commented 2026-07-29 14:24:38 +02:00
Author
Owner
Copy Link
Copy Source

Codex State: reviewed

Reviewed against published main (5240749). This remains open: ReviewSendPage.tsx is 2,667 lines and RecipientDataPage.tsx is 2,521 lines. Some stable components exist, but the deferred feature-boundary split is not complete.

## Codex State: reviewed Reviewed against published `main` (`5240749`). This remains open: `ReviewSendPage.tsx` is 2,667 lines and `RecipientDataPage.tsx` is 2,521 lines. Some stable components exist, but the deferred feature-boundary split is not complete.
zemion commented 2026-07-29 20:44:12 +02:00
Author
Owner
Copy Link
Copy Source

2026-07-29 implementation review: this no longer needs a product decision. The stable extraction boundaries are now visible. ReviewSendPage can be split into workflow navigation, attachment preview, deliverability preflight, built-message preview/query state, job attempts, and delivery results. RecipientDataPage can be split into address editing, address-source import, recipient CSV/XLSX import, file linking, and recipient-column/view-model utilities. Preserve the page-level controllers and split one boundary at a time. Resolve #84 first so generated translation noise does not obscure the refactor.

2026-07-29 implementation review: this no longer needs a product decision. The stable extraction boundaries are now visible. ReviewSendPage can be split into workflow navigation, attachment preview, deliverability preflight, built-message preview/query state, job attempts, and delivery results. RecipientDataPage can be split into address editing, address-source import, recipient CSV/XLSX import, file linking, and recipient-column/view-model utilities. Preserve the page-level controllers and split one boundary at a time. Resolve #84 first so generated translation noise does not obscure the refactor.
zemion commented 2026-07-30 01:01:41 +02:00
Author
Owner
Copy Link
Copy Source

Codex State: progress

Summary

  • Pushed the first stable-boundary refactor tranche in 961d5d1. ReviewSendPage now delegates workflow navigation, attachment linking, deliverability preflight, built-message preview/query state, job detail, and formatting helpers. RecipientDataPage now delegates address-source selection/snapshot UI and import transformation/provenance. Focused review, template-preview, and import tests pass; the integrated Core WebUI build passes. Remaining work: extract recipient CSV/XLSX import and file linking, then recipient column/view-model utilities and any remaining delivery-results controller concerns.

Suggested status label: status/in-progress

## Codex State: progress ### Summary - Pushed the first stable-boundary refactor tranche in 961d5d1. ReviewSendPage now delegates workflow navigation, attachment linking, deliverability preflight, built-message preview/query state, job detail, and formatting helpers. RecipientDataPage now delegates address-source selection/snapshot UI and import transformation/provenance. Focused review, template-preview, and import tests pass; the integrated Core WebUI build passes. Remaining work: extract recipient CSV/XLSX import and file linking, then recipient column/view-model utilities and any remaining delivery-results controller concerns. Suggested status label: `status/in-progress`
zemion commented 2026-07-31 01:37:50 +02:00
Author
Owner
Copy Link
Copy Source

Codex State: done

Summary

  • Completed the remaining stable-boundary frontend decomposition: recipient address editing, CSV/XLSX import and file linking, recipient grid/view-model construction, and review result/table presentation now live in focused feature-owned modules.
  • RecipientDataPage is now a 624-line state/persistence controller (down from 2,190 lines); ReviewSendPage remains the workflow orchestration controller while pure result presentation and column construction have moved out.
  • The extraction preserves behavior and optional Mail, Files, and Postbox capability boundaries; source-structure tests were updated to cover the page and its collaborators rather than weakened.

Changed Files

  • webui/src/features/campaigns/RecipientDataPage.tsx
  • webui/src/features/campaigns/recipients/RecipientAddressEditor.tsx
  • webui/src/features/campaigns/recipients/RecipientImportDialog.tsx
  • webui/src/features/campaigns/recipients/recipientProfileColumns.tsx
  • webui/src/features/campaigns/ReviewSendPage.tsx
  • webui/src/features/campaigns/review/reviewPresentation.tsx
  • webui/tests/recipient-search-ui-structure.test.mjs
  • webui/tests/aggregate-report-ui-structure.test.mjs

Verification

  • Campaign TypeScript check passed.
  • Campaign import, recipient-search, review-preview, template-preview, policy, report-grid, operator-queue, and aggregate-report tests passed.
  • Campaign-only production build passed bundle budgets.
  • tools/checks/check-focused.sh passed, including 31 module permutations and the full-product build.
  • git diff --check passed.
## Codex State: done ### Summary - Completed the remaining stable-boundary frontend decomposition: recipient address editing, CSV/XLSX import and file linking, recipient grid/view-model construction, and review result/table presentation now live in focused feature-owned modules. - RecipientDataPage is now a 624-line state/persistence controller (down from 2,190 lines); ReviewSendPage remains the workflow orchestration controller while pure result presentation and column construction have moved out. - The extraction preserves behavior and optional Mail, Files, and Postbox capability boundaries; source-structure tests were updated to cover the page and its collaborators rather than weakened. ### Changed Files - `webui/src/features/campaigns/RecipientDataPage.tsx` - `webui/src/features/campaigns/recipients/RecipientAddressEditor.tsx` - `webui/src/features/campaigns/recipients/RecipientImportDialog.tsx` - `webui/src/features/campaigns/recipients/recipientProfileColumns.tsx` - `webui/src/features/campaigns/ReviewSendPage.tsx` - `webui/src/features/campaigns/review/reviewPresentation.tsx` - `webui/tests/recipient-search-ui-structure.test.mjs` - `webui/tests/aggregate-report-ui-structure.test.mjs` ### Verification - `Campaign TypeScript check passed.` - `Campaign import, recipient-search, review-preview, template-preview, policy, report-grid, operator-queue, and aggregate-report tests passed.` - `Campaign-only production build passed bundle budgets.` - `tools/checks/check-focused.sh passed, including 31 module permutations and the full-product build.` - `git diff --check passed.`
zemion commented 2026-07-31 01:43:55 +02:00
Author
Owner
Copy Link
Copy Source

Codex State: note

Summary

  • Correction to the completion note: the final RecipientDataPage.tsx is 580 lines, not 624, after the last import cleanup. The verification and closure assessment are unchanged.
## Codex State: note ### Summary - Correction to the completion note: the final RecipientDataPage.tsx is 580 lines, not 624, after the last import cleanup. The verification and closure assessment are unchanged.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
HTTP API contracts, routers, schemas, or API smoke behavior.
 area/auth
Authentication, sessions, access bootstrap, or login behavior.
 area/db
Database sessions, models, transactions, or persistence primitives.
 area/devex
Local developer workflow, scripts, tests, tooling, or release helpers.
 area/docs
Durable documentation and project guidance.
 area/governance
Governance policy, audit, privacy, retention, or compliance behavior.
 area/marketing
Public website, product messaging, publication copy, or legal page content.
 area/migrations
Alembic migrations, schema bootstrap, or persistence evolution.
 area/module-system
Module discovery, manifests, capabilities, routing, or optional integrations.
 area/rbac
Permissions, roles, delegation, or authorization policy.
 area/release
Versioning, release locks, tags, packaging, or dependency pins.
 area/security
Security posture, static analysis, supply-chain hardening, or vulnerability remediation.
 area/tenancy
Tenant boundaries, provisioning, or tenant-scoped data behavior.
 area/webui
Shared WebUI shell, frontend components, routing, or frontend tests.
 audit/complexity
Complexity finding from Radon, Xenon, or equivalent maintainability scans.
 audit/duplication
Duplicated-code finding from jscpd or equivalent similarity scans.
 audit/false-positive
Audit finding reviewed as a narrow false positive or acceptable risk.
 audit/needs-design
Audit finding that needs an architectural or product decision before implementation.
 audit/quick-fix
Audit finding that appears narrow and directly fixable.
 audit/structural
Audit finding that needs design, refactoring, or behavior review.
 codex/needs-human
Needs an explicit human decision before Codex should implement.
 codex/ready
Suitable for Codex to pick up with the existing issue context.
 module/access
GovOPlaN access, identity, authentication, RBAC, and administration behavior.
 module/addresses
GovOPlaN Addresses module behavior or integration.
 module/admin
GovOPlaN Admin module behavior or integration.
 module/appointments
GovOPlaN Appointments module behavior or integration.
 module/approvals
GovOPlaN Approvals module behavior or integration.
 module/audit
GovOPlaN Audit module behavior or integration.
 module/calendar
GovOPlaN Calendar module behavior or integration.
 module/campaign
GovOPlaN campaign module behavior or integration.
 module/cases
GovOPlaN Cases module behavior or integration.
 module/committee
GovOPlaN Committee module behavior or integration.
 module/connectors
GovOPlaN Connectors module behavior or integration.
 module/core
GovOPlaN core runner, shared primitives, shell, or extension points.
 module/dashboard
GovOPlaN Dashboard module behavior or integration.
 module/dataflow
GovOPlaN Dataflow module behavior or integration.
 module/datasources
GovOPlaN governed datasource contracts, catalogs, and integrations.
 module/decisions
GovOPlaN formal Decisions module behavior or integration.
 module/dist-lists
GovOPlaN Distribution Lists module behavior or integration.
 module/dms
GovOPlaN Dms module behavior or integration.
 module/docs
GovOPlaN Docs module behavior or integration.
 module/encryption
GovOPlaN Encryption key custody, cryptographic policy, and E2EE integration.
 module/erp
GovOPlaN Erp module behavior or integration.
 module/evaluation
GovOPlaN Evaluation module behavior or integration.
 module/files
GovOPlaN files module behavior or integration.
 module/fit-connect
GovOPlaN Fit Connect module behavior or integration.
 module/forms
GovOPlaN Forms module behavior or integration.
 module/forms-runtime
GovOPlaN Forms Runtime module behavior or integration.
 module/helpdesk
GovOPlaN Helpdesk module behavior or integration.
 module/identity
GovOPlaN Identity module behavior or integration.
 module/identity-trust
GovOPlaN Identity Trust module behavior or integration.
 module/idm
GovOPlaN Idm module behavior or integration.
 module/ledger
GovOPlaN Ledger module behavior or integration.
 module/mail
GovOPlaN mail module behavior or integration.
 module/mandates
GovOPlaN Mandates, jurisdiction, responsibility, and authority behavior or integration.
 module/notifications
GovOPlaN Notifications module behavior or integration.
 module/ops
GovOPlaN Ops module behavior or integration.
 module/organizations
GovOPlaN Organizations module behavior or integration.
 module/parties
GovOPlaN procedure Parties, representation, and delivery-authority behavior or integration.
 module/payments
GovOPlaN Payments module behavior or integration.
 module/permits
GovOPlaN Permits module behavior or integration.
 module/policy
GovOPlaN Policy module behavior or integration.
 module/poll
GovOPlaN Poll module behavior or integration.
 module/portal
GovOPlaN Portal module behavior or integration.
 module/postbox
GovOPlaN Postbox module behavior or integration.
 module/projects
GovOPlaN Projects module behavior or integration.
 module/quick-access
GovOPlaN configurable task-local Quick Access behavior and integrations.
 module/records
GovOPlaN Records and eAkte lifecycle behavior or integration.
 module/reporting
GovOPlaN Reporting module behavior or integration.
 module/risk-compliance
GovOPlaN Risk Compliance module behavior or integration.
 module/scheduling
GovOPlaN Scheduling module behavior or integration.
 module/search
GovOPlaN Search module behavior or integration.
 module/services
GovOPlaN versioned institutional Services behavior or integration.
 module/tasks
GovOPlaN Tasks module behavior or integration.
 module/templates
GovOPlaN Templates module behavior or integration.
 module/tenancy
GovOPlaN Tenancy module behavior or integration.
 module/tickets
GovOPlaN Tickets module behavior or integration.
 module/views
GovOPlaN governed task views, interface projections, and workflow view integration.
 module/voting
GovOPlaN Voting module behavior or integration.
 module/wiki
GovOPlaN Wiki module behavior or integration.
 module/workflow
GovOPlaN Workflow module behavior or integration.
 module/workflow-engine
GovOPlaN Workflow Engine runtime, persistence, or integration.
 module/xoev
GovOPlaN Xoev module behavior or integration.
 module/xrechnung
GovOPlaN Xrechnung module behavior or integration.
 module/xta-osci
GovOPlaN Xta Osci module behavior or integration.
priority
p0
Immediate stop-the-line priority.
priority
p1
High priority for the next focused work window.
priority
p2
Normal planned priority.
priority
p3
Low priority or opportunistic cleanup.
source/backlog-import
Imported from markdown backlog, roadmap, plan, or TODO files.
 source/security-audit
Created from a structured security or code-quality audit report.
 source/todo-scan
Imported from inline TODO/FIXME/HACK markers by the Gitea TODO importer.
status
blocked
Cannot progress without a decision, dependency, credential, or external change.
status
in-progress
Currently being worked.
status
needs-info
Needs clarifying input before implementation can proceed safely.
status
ready
Ready for implementation.
status
triage
Needs review, ownership, priority, or acceptance criteria.
type
bug
A reproducible defect, regression, or incorrect behavior.
type
debt
Cleanup, refactoring, risk reduction, or deferred engineering work.
type
docs
Documentation, process, or developer workflow work.
type
feature
New user-visible behavior or platform capability.
type
task
Implementation, maintenance, migration, or operational work.
type
user-story
End-to-end user journey or real-world process story used to steer product slices.
No labels area/devex codex/needs-human module/campaign
priority
p2
 source/backlog-import
status
triage
type
debt
Milestone
No items
No Milestone Deferred Cleanup
Projects
Clear projects
No projects
Assignees
Clear assignees
govoplan-package-publisher zemion (Albrecht Degering)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GovOPlaN/govoplan-campaign#45