Persist incremental message review, accept matching conditions in bulk, and honor configured omissions through delivery #97
Closed
opened 2026-09-07 14:57:23 +02:00 by zemion
·
3 comments
No Branch/Tag Specified
Labels
Clear labels
area/api
area/auth
area/db
area/devex
area/docs
area/governance
area/marketing
area/migrations
area/module-system
area/rbac
area/release
area/security
area/tenancy
area/webui
audit/complexity
audit/duplication
audit/false-positive
audit/needs-design
audit/quick-fix
audit/structural
codex/needs-human
codex/ready
module/access
module/addresses
module/admin
module/appointments
module/approvals
module/audit
module/calendar
module/campaign
module/cases
module/committee
module/connectors
module/core
module/dashboard
module/dataflow
module/datasources
module/decisions
module/dist-lists
module/dms
module/docs
module/encryption
module/erp
module/evaluation
module/files
module/fit-connect
module/forms
module/forms-runtime
module/helpdesk
module/identity
module/identity-trust
module/idm
module/ledger
module/mail
module/mandates
module/notifications
module/ops
module/organizations
module/parties
module/payments
module/permits
module/policy
module/poll
module/portal
module/postbox
module/projects
module/quick-access
module/records
module/reporting
module/risk-compliance
module/scheduling
module/search
module/services
module/tasks
module/templates
module/tenancy
module/tickets
module/views
module/voting
module/wiki
module/workflow
module/workflow-engine
module/xoev
module/xrechnung
module/xta-osci
source/backlog-import
source/security-audit
source/todo-scan
HTTP API contracts, routers, schemas, or API smoke behavior.
Authentication, sessions, access bootstrap, or login behavior.
Database sessions, models, transactions, or persistence primitives.
Local developer workflow, scripts, tests, tooling, or release helpers.
Durable documentation and project guidance.
Governance policy, audit, privacy, retention, or compliance behavior.
Public website, product messaging, publication copy, or legal page content.
Alembic migrations, schema bootstrap, or persistence evolution.
Module discovery, manifests, capabilities, routing, or optional integrations.
Permissions, roles, delegation, or authorization policy.
Versioning, release locks, tags, packaging, or dependency pins.
Security posture, static analysis, supply-chain hardening, or vulnerability remediation.
Tenant boundaries, provisioning, or tenant-scoped data behavior.
Shared WebUI shell, frontend components, routing, or frontend tests.
Complexity finding from Radon, Xenon, or equivalent maintainability scans.
Duplicated-code finding from jscpd or equivalent similarity scans.
Audit finding reviewed as a narrow false positive or acceptable risk.
Audit finding that needs an architectural or product decision before implementation.
Audit finding that appears narrow and directly fixable.
Audit finding that needs design, refactoring, or behavior review.
Needs an explicit human decision before Codex should implement.
Suitable for Codex to pick up with the existing issue context.
GovOPlaN access, identity, authentication, RBAC, and administration behavior.
GovOPlaN Addresses module behavior or integration.
GovOPlaN Admin module behavior or integration.
GovOPlaN Appointments module behavior or integration.
GovOPlaN Approvals module behavior or integration.
GovOPlaN Audit module behavior or integration.
GovOPlaN Calendar module behavior or integration.
GovOPlaN campaign module behavior or integration.
GovOPlaN Cases module behavior or integration.
GovOPlaN Committee module behavior or integration.
GovOPlaN Connectors module behavior or integration.
GovOPlaN core runner, shared primitives, shell, or extension points.
GovOPlaN Dashboard module behavior or integration.
GovOPlaN Dataflow module behavior or integration.
GovOPlaN governed datasource contracts, catalogs, and integrations.
GovOPlaN formal Decisions module behavior or integration.
GovOPlaN Distribution Lists module behavior or integration.
GovOPlaN Dms module behavior or integration.
GovOPlaN Docs module behavior or integration.
GovOPlaN Encryption key custody, cryptographic policy, and E2EE integration.
GovOPlaN Erp module behavior or integration.
GovOPlaN Evaluation module behavior or integration.
GovOPlaN files module behavior or integration.
GovOPlaN Fit Connect module behavior or integration.
GovOPlaN Forms module behavior or integration.
GovOPlaN Forms Runtime module behavior or integration.
GovOPlaN Helpdesk module behavior or integration.
GovOPlaN Identity module behavior or integration.
GovOPlaN Identity Trust module behavior or integration.
GovOPlaN Idm module behavior or integration.
GovOPlaN Ledger module behavior or integration.
GovOPlaN mail module behavior or integration.
GovOPlaN Mandates, jurisdiction, responsibility, and authority behavior or integration.
GovOPlaN Notifications module behavior or integration.
GovOPlaN Ops module behavior or integration.
GovOPlaN Organizations module behavior or integration.
GovOPlaN procedure Parties, representation, and delivery-authority behavior or integration.
GovOPlaN Payments module behavior or integration.
GovOPlaN Permits module behavior or integration.
GovOPlaN Policy module behavior or integration.
GovOPlaN Poll module behavior or integration.
GovOPlaN Portal module behavior or integration.
GovOPlaN Postbox module behavior or integration.
GovOPlaN Projects module behavior or integration.
GovOPlaN configurable task-local Quick Access behavior and integrations.
GovOPlaN Records and eAkte lifecycle behavior or integration.
GovOPlaN Reporting module behavior or integration.
GovOPlaN Risk Compliance module behavior or integration.
GovOPlaN Scheduling module behavior or integration.
GovOPlaN Search module behavior or integration.
GovOPlaN versioned institutional Services behavior or integration.
GovOPlaN Tasks module behavior or integration.
GovOPlaN Templates module behavior or integration.
GovOPlaN Tenancy module behavior or integration.
GovOPlaN Tickets module behavior or integration.
GovOPlaN governed task views, interface projections, and workflow view integration.
GovOPlaN Voting module behavior or integration.
GovOPlaN Wiki module behavior or integration.
GovOPlaN Workflow module behavior or integration.
GovOPlaN Workflow Engine runtime, persistence, or integration.
GovOPlaN Xoev module behavior or integration.
GovOPlaN Xrechnung module behavior or integration.
GovOPlaN Xta Osci module behavior or integration.
priority
p0
Immediate stop-the-line priority.
priority
p1
High priority for the next focused work window.
priority
p2
Normal planned priority.
priority
p3
Low priority or opportunistic cleanup.
Imported from markdown backlog, roadmap, plan, or TODO files.
Created from a structured security or code-quality audit report.
Imported from inline TODO/FIXME/HACK markers by the Gitea TODO importer.
status
blocked
Cannot progress without a decision, dependency, credential, or external change.
status
in-progress
Currently being worked.
status
needs-info
Needs clarifying input before implementation can proceed safely.
status
ready
Ready for implementation.
status
triage
Needs review, ownership, priority, or acceptance criteria.
type
bug
A reproducible defect, regression, or incorrect behavior.
type
debt
Cleanup, refactoring, risk reduction, or deferred engineering work.
type
docs
Documentation, process, or developer workflow work.
type
feature
New user-visible behavior or platform capability.
type
task
Implementation, maintenance, migration, or operational work.
type
user-story
End-to-end user journey or real-world process story used to steer product slices.
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: GovOPlaN/govoplan-campaign#97
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
User-reported campaign usability follow-up to #96. Individual review reasons were held only locally until final completion, with expensive whole-page updates and no automatic advance. Expected DROP outcomes/explicitly allowed zero-match rules must not trigger review. Final delivery preflight must honor accepted same-build conditions instead of blocking from raw missing-file counts.
Implementation in the working tree (not pushed): additive revision/build-bound incremental review writes; exact frozen-job category verification and bounded 200-message grouped acceptance; durable per-job reason/actor/time audit; selected-job-only backend validation; lightweight acknowledgement without workspace/file rescans; next-unreviewed navigation; failure-safe note retention; EN/DE UI/docs. Genuine blockers and stale builds remain rejected. Existing frozen builds require an intentional rebuild to adopt corrected policy classification.
Backend verification: 132 targeted tests and 20 subtests passed, including concurrency, permission, locked history, bounded loading of 1 selected job among 502, and cross-reviewer evidence. Browser integration and final-preflight regression checks are in progress. No live send or policy/deployment change performed. Leave open until published and verified.
Additional user requirements implemented locally: four shared message states (Ready / Needs review / Blocked / Excluded) plus an explanation column; the review-candidates button uses the same controlled State filter, with no separate hidden server filter. Validation cause and no-attachment policy outcome are presented as one condition while original technical evidence is retained. Validation details and repeated files both use shared pagination. Confirm & Send and earlier validation guidance no longer demand a second acceptance for completed same-build review. Reviewed-stage mock testing now checks stored sealed EML and same-build decisions instead of rebuilding/blanket-accepting exceptions.
Current verification: 144 targeted backend tests +20 subtests passed, 18 focused review helper tests passed. Browser coverage includes durable incremental/reload/retry/bulk decisions, permissions, conflict handling, final preflight despite14missing source matches, and four-state filtering. Final pagination/build/admin checks are still underway. No real sends or deployment/policy changes.
Local implementation verification: full Core browser conformance 127/127 passes, including incremental review persistence/races, bulk acceptance, unified Ready/Needs review/Blocked/Excluded filtering, validation/repeated-file pagination and German labels. Combined targeted Campaign backend suite: 191 tests + 23 subtests pass; review helper suite 18 passes. Production WebUI build, structural i18n audit, manifest checks and strict interface inventory pass. Workspace focused check reaches unrelated institutional-governance journey fixture failure (expired availability date; tests/test_institutional_governance_journey.py:223). Changes are local/unpublished; issue remains open. No real mail was sent.
Reconciled 2026-09-08: implemented and published
This supersedes the earlier local/unpublished status. The owning fix is on remote
mainand the verifiedv0.1.28tag (commitc51fc180fba7), included in the published 0.1.45 source/package composition.Incremental build/revision-bound review, bounded same-condition bulk acceptance, configured omission handling and accepted-condition delivery preflight are implemented.
test_incremental_review_persistence.py,test_reviewed_build_mock.pyand actual campaign-review/bulk-review/review-details conformance passed. Genuine blockers and stale builds remain blocked; existing frozen builds need an intentional rebuild to adopt changed classifications. EN/DE guidance is included; no live build or delivery was initiated here.The completed, unmodified release
tools/checks/check-focused.shrun passed, including 213 browser conformance cases and the relevant backend suites. The audit matched current remote branches/tags and reviewed the original acceptance criteria and subsequent comments. Closing the implemented source/package scope. This is not a runtime deployment claim: Meta #52 and website #9 retain their independent runtime/public-site holds. No tag was moved.