perf(webui): load optional password generation on demand

2026-09-08 03:15:07 +02:00
parent c209b3c27d
commit c3daa4a9aa
7 changed files with 212 additions and 14 deletions
@@ -0,0 +1,64 @@
+import { StrictMode, useState } from "react";
+import { createRoot } from "react-dom/client";
+import Button from "../src/components/Button";
+import FormField from "../src/components/FormField";
+import PasswordField from "../src/components/PasswordField";
+import { PlatformLanguageProvider } from "../src/i18n/LanguageContext";
+import "../src/styles/tokens.css";
+import "../src/styles/layout.css";
+import "../src/styles/forms.css";
+import "../src/styles/components.css";
+import "../src/styles/dialogs.css";
+import "./conformance.css";
+
+const GENERATOR_OPTIONS = { length: 24 };
+
+function PasswordFieldScenario() {
+  const [password, setPassword] = useState("fixture-unchanged-password");
+  const [disabled, setDisabled] = useState(false);
+  const [changes, setChanges] = useState(0);
+
+  return (
+    <main className="conformance-root">
+      <h1>Optional password generator</h1>
+      <FormField label="Editable password">
+        <PasswordField
+          data-testid="editable-password"
+          value={password}
+          disabled={disabled}
+          generator
+          generatorOptions={GENERATOR_OPTIONS}
+          helpContextId="access.authentication.password"
+          helpModuleId="access"
+          onValueChange={(value) => {
+            setPassword(value);
+            setChanges((count) => count + 1);
+          }}
+        />
+      </FormField>
+      <output data-testid="password-changes">{changes}</output>
+      <Button data-testid="toggle-generator-access" onClick={() => setDisabled((value) => !value)}>
+        {disabled ? "Enable generation" : "Disable generation"}
+      </Button>
+      <FormField label="Sign-in password">
+        <PasswordField value="fixture-sign-in-password" onValueChange={() => undefined} />
+      </FormField>
+      <FormField label="Disabled password">
+        <PasswordField generator disabled value="" onValueChange={() => undefined} />
+      </FormField>
+      <FormField label="Read-only password">
+        <PasswordField generator readOnly value="" onValueChange={() => undefined} />
+      </FormField>
+    </main>
+  );
+}
+
+// Deliberately no Core barrel or other fixture imports: they could eagerly load
+// the generator and mask a regression in this field's real lazy boundary.
+createRoot(document.getElementById("root")!).render(
+  <StrictMode>
+    <PlatformLanguageProvider preferredLanguageCode={new URLSearchParams(window.location.search).get("language") ?? "en"}>
+      <PasswordFieldScenario />
+    </PlatformLanguageProvider>
+  </StrictMode>,
+);
@@ -0,0 +1,12 @@
+<!doctype html>
+<html lang="en">
+  <head>
+    <meta charset="UTF-8" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <title>Password field loading conformance</title>
+  </head>
+  <body>
+    <div id="root"></div>
+    <script type="module" src="./PasswordFieldMain.tsx"></script>
+  </body>
+</html>
@@ -0,0 +1,77 @@
+import { expect, test } from "@playwright/test";
+
+const generatorUrl = "**/PasswordGeneratorDialog.tsx*";
+
+for (const language of ["en", "de"]) {
+  test(`password generation loads only when opened and preserves cancel/use/focus (${language})`, async ({ page }) => {
+    const generateLabel = language === "de" ? "Passwort generieren" : "Generate password";
+    const cancelLabel = language === "de" ? "Abbrechen" : "Cancel";
+    const useLabel = language === "de" ? "Passwort verwenden" : "Use password";
+    const requests: string[] = [];
+    page.on("request", (request) => {
+      if (request.url().includes("/PasswordGeneratorDialog.tsx")) requests.push(request.url());
+    });
+    await page.goto(`/password-field.html?language=${language}`);
+    const trigger = page.getByRole("button", { name: generateLabel, exact: true });
+    await expect(trigger).toHaveCount(1);
+    await expect(page.getByTestId("editable-password")).toHaveValue("fixture-unchanged-password");
+    expect(requests).toHaveLength(0);
+
+    await trigger.click();
+    const dialog = page.getByRole("dialog", { name: generateLabel, exact: true });
+    await expect(dialog).toBeVisible();
+    await expect.poll(() => requests.length).toBe(1);
+    await expect(dialog.locator(".password-generator-result input")).toHaveValue(/^.{24}$/);
+    await expect(page.getByTestId("password-changes")).toHaveText("0");
+    await dialog.getByRole("button", { name: cancelLabel, exact: true }).click();
+    await expect(dialog).toBeHidden();
+    await expect(trigger).toBeFocused();
+    await expect(page.getByTestId("editable-password")).toHaveValue("fixture-unchanged-password");
+
+    await trigger.click();
+    await expect(dialog.locator(".password-generator-result input")).toHaveValue(/^.{24}$/);
+    const candidate = await dialog.locator(".password-generator-result input").inputValue();
+    await dialog.getByRole("button", { name: useLabel, exact: true }).click();
+    await expect(dialog).toBeHidden();
+    await expect(page.getByTestId("editable-password")).toHaveValue(candidate);
+    await expect(page.getByTestId("editable-password")).toHaveAttribute("type", "password");
+    await expect(page.getByTestId("password-changes")).toHaveText("1");
+    await expect(trigger).toBeFocused();
+    expect(requests).toHaveLength(1);
+  });
+}
+
+test("a pending generator load cannot reopen after generation becomes unavailable", async ({ page }) => {
+  let releaseLoad!: () => void;
+  const pending = new Promise<void>((resolve) => { releaseLoad = resolve; });
+  await page.route(generatorUrl, async (route) => {
+    await pending;
+    await route.continue();
+  });
+  await page.goto("/password-field.html?language=en");
+  await page.getByRole("button", { name: "Generate password", exact: true }).click();
+  await expect(page.locator(".module-load-progress")).toBeVisible();
+  await page.getByTestId("toggle-generator-access").click();
+  releaseLoad();
+  await expect(page.getByTestId("editable-password")).toBeDisabled();
+  await expect(page.locator(".module-load-progress")).toBeHidden();
+  await expect(page.getByRole("dialog")).toHaveCount(0);
+  await page.getByTestId("toggle-generator-access").click();
+  await expect(page.getByRole("dialog")).toHaveCount(0);
+  await expect(page.getByTestId("password-changes")).toHaveText("0");
+  await page.getByRole("button", { name: "Generate password", exact: true }).click();
+  await expect(page.getByRole("dialog", { name: "Generate password", exact: true })).toBeVisible();
+});
+
+test("generator chunk failure leaves ordinary password entry and reveal usable", async ({ page }) => {
+  await page.route(generatorUrl, (route) => route.abort("failed"));
+  await page.goto("/password-field.html?language=en");
+  await page.getByRole("button", { name: "Generate password", exact: true }).click();
+  await expect(page.locator(".module-load-error")).toBeVisible();
+  await expect(page.getByTestId("editable-password")).toBeEnabled();
+  await page.getByTestId("editable-password").fill("fixture-edited-password");
+  await page.getByRole("button", { name: "Show password", exact: true }).first().click();
+  await expect(page.getByTestId("editable-password")).toHaveAttribute("type", "text");
+  await expect(page.getByTestId("editable-password")).toHaveValue("fixture-edited-password");
+  await expect(page.getByRole("dialog")).toHaveCount(0);
+});