[Bug] DataGrid action-column visibility and responsive dialog sizing #294

New Issue

2026-09-07T10:24:01+02:00

zemion commented

2026-09-07 10:24:01 +02:00

Audit shared DataGrid and all module consumers. Fix clipped last-column actions, initial sizing, resizing and constrained containers without disabling useful local horizontal table scrolling. Fix unnecessary horizontal overflow in Templates Add and shared dialogs. Add true browser geometry/resize regression and documentation.

Implementation started locally for the 2026-09-07 usability review. Existing uncommitted Campaign repairs are preserved. No live user imports or settings changes for tests; leave open until committed and delivered.

Audit shared DataGrid and all module consumers. Fix clipped last-column actions, initial sizing, resizing and constrained containers without disabling useful local horizontal table scrolling. Fix unnecessary horizontal overflow in Templates Add and shared dialogs. Add true browser geometry/resize regression and documentation. Implementation started locally for the 2026-09-07 usability review. Existing uncommitted Campaign repairs are preserved. No live user imports or settings changes for tests; leave open until committed and delivered.

zemion commented

2026-09-07 10:59:29 +02:00

Local implementation and verification — 2026-09-07 usability slice (not yet committed/pushed).

Audited 110 DataGrid uses in 64 TS/TSX files. Shared DataGrid now measures real action groups (including reserved and disabled slots), supports semantic action columns for composite controls, keeps sticky end tracks correctly bounded, wraps constrained action groups, and releases oversized sticky tracks when they would obscure the entire viewport. Content/free sizing retains explicit user widths; pointer/touch and keyboard resizing persist, reset and cancel safely. Incompatible old sizing snapshots reset once; sorting/filter state is retained. Reporting/Ops/Distribution Lists had specific action compositions corrected.

Shared dialogs now shrink their padded content rather than forcing whole-dialog horizontal scrolling. Templates Add uses DialogSection + FormGrid without the old intrinsic minimum. Genuinely wide tables retain a local scroller.

Live acceptance found an additional previous central-component migration defect: 11 Access/Admin/Tenancy files imported FormGrid or ActionToolbar type-only while rendering them as JSX. Corrected those imports. New lexical TypeScript AST guard checks 309 TSX files across 47 UI modules; 10 regression cases cover aliases, namespaces, nested JSX and legitimate shadowing. Wired before the broad integration checks in check-focused.

Evidence: production build and unchanged bundle budgets pass (synchronous appearance helpers were separated from settings-only UI to retain startup headroom). Full browser conformance passed 47/47; final dialog composition rerun 12/12, navigation/shared-interface rerun 21/21. DataGrid sizing/action tests, module interface checks, shared foundations/layout/primitives checks, strict inventory and all 72 manifests pass. Live 127.0.0.1:5173: tenant Users action controls fit and are reachable at scroll end at 1440/768/390px; Templates Add has no horizontal dialog overflow at 1440/390/320px. No live data/settings writes were performed.

English/German module guidance and Core DataGrid/interface contracts updated. Final visual review also repaired previously undefined navigation spacing tokens and made the personal navigation card full-span.

Known separate check limitation: the full check-focused run stops at tests/test_institutional_governance_journey.py:223 (IndexError from dated service fixture); this predates this slice and is not claimed green. Optional-module build matrix is still completing and will be noted separately.

Delivery state: keep open until reviewed/committed/pushed; this note records local verified work only.

Local implementation and verification — 2026-09-07 usability slice (not yet committed/pushed). Audited 110 DataGrid uses in 64 TS/TSX files. Shared DataGrid now measures real action groups (including reserved and disabled slots), supports semantic action columns for composite controls, keeps sticky end tracks correctly bounded, wraps constrained action groups, and releases oversized sticky tracks when they would obscure the entire viewport. Content/free sizing retains explicit user widths; pointer/touch and keyboard resizing persist, reset and cancel safely. Incompatible old sizing snapshots reset once; sorting/filter state is retained. Reporting/Ops/Distribution Lists had specific action compositions corrected. Shared dialogs now shrink their padded content rather than forcing whole-dialog horizontal scrolling. Templates Add uses DialogSection + FormGrid without the old intrinsic minimum. Genuinely wide tables retain a local scroller. Live acceptance found an additional previous central-component migration defect: 11 Access/Admin/Tenancy files imported FormGrid or ActionToolbar type-only while rendering them as JSX. Corrected those imports. New lexical TypeScript AST guard checks 309 TSX files across 47 UI modules; 10 regression cases cover aliases, namespaces, nested JSX and legitimate shadowing. Wired before the broad integration checks in check-focused. Evidence: production build and unchanged bundle budgets pass (synchronous appearance helpers were separated from settings-only UI to retain startup headroom). Full browser conformance passed 47/47; final dialog composition rerun 12/12, navigation/shared-interface rerun 21/21. DataGrid sizing/action tests, module interface checks, shared foundations/layout/primitives checks, strict inventory and all 72 manifests pass. Live 127.0.0.1:5173: tenant Users action controls fit and are reachable at scroll end at 1440/768/390px; Templates Add has no horizontal dialog overflow at 1440/390/320px. No live data/settings writes were performed. English/German module guidance and Core DataGrid/interface contracts updated. Final visual review also repaired previously undefined navigation spacing tokens and made the personal navigation card full-span. Known separate check limitation: the full check-focused run stops at tests/test_institutional_governance_journey.py:223 (IndexError from dated service fixture); this predates this slice and is not claimed green. Optional-module build matrix is still completing and will be noted separately. Delivery state: keep open until reviewed/committed/pushed; this note records local verified work only.

zemion commented

2026-09-07 11:07:29 +02:00

Final verification update — 2026-09-07:

All 63 optional-module production build permutations passed, including Core-only, Access/Admin/Tenancy independently, Files/Templates/Views combinations and full product. Bundle budgets remain unchanged; final full-product initial JavaScript is503.3KiB raw /159.3KiB gzip. Final full browser conformance rerun passed47/47 after the navigation spacing/full-width and Templates wrapper refinements. Shared layout/primitives/foundations and the309-TSX runtime-import gate pass.

Expanded live smoke confirms all11 corrected administration components render, including actual Role templates, tenant/system roles/users, API keys, groups, data-subject requests, module management and tenants. One separate API failure remains on Function mappings: GET /api/v1/admin/external-function-role-mappings/delta returns500 because PostgreSQL reports missing relation access_external_function_role_assignments. Verified in runtime/dev-launcher/backend.log and Access route stack. The table is already defined in Access baseline revision4a5b6c7d8e9f (production v017_access_baseline.py and development access_semantic_directory.py). This needs live schema/migration-history reconciliation; do not blindly replay or stamp a baseline. No live database repair, policy changes, file import or settings save was performed.

The full focused suite's separate institutional-governance dated-fixture error remains as previously recorded. Requested UI/archive changes are local, with issue left open pending review/commit/push.

Final verification update — 2026-09-07: All 63 optional-module production build permutations passed, including Core-only, Access/Admin/Tenancy independently, Files/Templates/Views combinations and full product. Bundle budgets remain unchanged; final full-product initial JavaScript is503.3KiB raw /159.3KiB gzip. Final full browser conformance rerun passed47/47 after the navigation spacing/full-width and Templates wrapper refinements. Shared layout/primitives/foundations and the309-TSX runtime-import gate pass. Expanded live smoke confirms all11 corrected administration components render, including actual Role templates, tenant/system roles/users, API keys, groups, data-subject requests, module management and tenants. One separate API failure remains on Function mappings: GET /api/v1/admin/external-function-role-mappings/delta returns500 because PostgreSQL reports missing relation access_external_function_role_assignments. Verified in runtime/dev-launcher/backend.log and Access route stack. The table is already defined in Access baseline revision4a5b6c7d8e9f (production v017_access_baseline.py and development access_semantic_directory.py). This needs live schema/migration-history reconciliation; do not blindly replay or stamp a baseline. No live database repair, policy changes, file import or settings save was performed. The full focused suite's separate institutional-governance dated-fixture error remains as previously recorded. Requested UI/archive changes are local, with issue left open pending review/commit/push.

zemion commented

2026-09-08 05:23:52 +02:00

Reconciled 2026-09-08: implemented and published

This supersedes the earlier local/unpublished status. The owning fix is on remote main and the verified v0.1.45 tag (commit a6d056a3df81), included in the published 0.1.45 source/package composition.

Shared DataGrid sizing/action-column behavior and responsive dialog/layout rules are implemented. Actual data-grid-layout.spec.ts, dialog-layout.spec.ts and module-layouts.spec.ts checks cover constrained containers, resizing and dialog geometry. DataGrid sizing and page-layout guidance are included. This closes the specified regressions, not a claim that every possible future UI layout is defect-free.

The completed, unmodified release tools/checks/check-focused.sh run passed, including 213 browser conformance cases and the relevant backend suites. The audit matched current remote branches/tags and reviewed the original acceptance criteria and subsequent comments. Closing the implemented source/package scope. This is not a runtime deployment claim: Meta #52 and website #9 retain their independent runtime/public-site holds. No tag was moved.

## Reconciled 2026-09-08: implemented and published This supersedes the earlier local/unpublished status. The owning fix is on remote `main` and the verified [`v0.1.45` tag](https://git.add-ideas.de/GovOPlaN/govoplan-core/src/tag/v0.1.45) ([commit `a6d056a3df81`](https://git.add-ideas.de/GovOPlaN/govoplan-core/commit/a6d056a3df81a1601d44c5e8c7bd1a55d64d2b45)), included in the published [0.1.45 source/package composition](https://git.add-ideas.de/GovOPlaN/govoplan/src/commit/88b685ff5e689acf096bdfc7084bd108e801e86e/docs/releases/0.1.45.md). Shared DataGrid sizing/action-column behavior and responsive dialog/layout rules are implemented. Actual `data-grid-layout.spec.ts`, `dialog-layout.spec.ts` and `module-layouts.spec.ts` checks cover constrained containers, resizing and dialog geometry. DataGrid sizing and page-layout guidance are included. This closes the specified regressions, not a claim that every possible future UI layout is defect-free. The completed, unmodified release `tools/checks/check-focused.sh` run passed, including 213 browser conformance cases and the relevant backend suites. The audit matched current remote branches/tags and reviewed the original acceptance criteria and subsequent comments. Closing the implemented source/package scope. This is not a runtime deployment claim: [Meta #52](https://git.add-ideas.de/GovOPlaN/govoplan/issues/52) and [website #9](https://git.add-ideas.de/add-ideas/addideas-govoplan-website/issues/9) retain their independent runtime/public-site holds. No tag was moved.

zemion closed this issue

2026-09-08 05:23:52 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: GovOPlaN/govoplan-core#294