feat: consume governed datasources and shared graphs

webui/src/features/dataflow/DataflowCanvas.tsx

@@ -13,6 +13,7 @@ import {
   type Edge,
   type ReactFlowInstance
 } from "@xyflow/react";
+import { definitionConnectionError } from "@govoplan/core-webui/definition-graph";
 import type {
   DataflowDiagnostic,
   NodeTypeDefinition,
@@ -124,34 +125,17 @@ export default function DataflowCanvas({
   };
 
   const isValidConnection = (connection: Connection | Edge): boolean => {
-    if (readOnly || !connection.source || !connection.target || connection.source === connection.target) return false;
-    const source = graph.nodes.find((node) => node.id === connection.source);
-    const target = graph.nodes.find((node) => node.id === connection.target);
-    if (!source || !target || source.type === "output" || target.type.startsWith("source.")) return false;
-    const sourcePort = connection.sourceHandle ?? "output";
-    const targetPort = connection.targetHandle ?? "input";
-    const sourceDefinition = definitions.get(source.type);
-    const targetDefinition = definitions.get(target.type);
-    if (
-      !sourceDefinition?.output_ports.some((port) => port.id === sourcePort)
-      || !targetDefinition?.input_ports.some((port) => port.id === targetPort)
-    ) {
-      return false;
-    }
-    const duplicate = graph.edges.some(
-      (edge) =>
-        edge.source === connection.source
-        && edge.target === connection.target
-        && (edge.source_port ?? "output") === sourcePort
-        && (edge.target_port ?? "input") === targetPort
-    );
-    if (duplicate) return false;
-    const port = targetDefinition.input_ports.find((item) => item.id === targetPort);
-    const targetPortConnections = graph.edges.filter(
-      (edge) => edge.target === connection.target && (edge.target_port ?? "input") === targetPort
-    );
-    if (!port?.multiple && targetPortConnections.length) return false;
-    return !wouldCreateCycle(graph, connection.source, connection.target);
+    if (readOnly || !connection.source || !connection.target) return false;
+    return definitionConnectionError(
+      graph,
+      nodeLibrary,
+      {
+        source: connection.source,
+        target: connection.target,
+        sourcePort: connection.sourceHandle,
+        targetPort: connection.targetHandle
+      }
+    ) === null;
   };
 
   const onConnect = (connection: Connection) => {
@@ -234,23 +218,6 @@ export default function DataflowCanvas({
   );
 }
 
-function wouldCreateCycle(graph: PipelineGraph, source: string, target: string): boolean {
-  const outgoing = new Map<string, string[]>();
-  graph.edges.forEach((edge) => {
-    outgoing.set(edge.source, [...(outgoing.get(edge.source) ?? []), edge.target]);
-  });
-  const pending = [target];
-  const visited = new Set<string>();
-  while (pending.length) {
-    const nodeId = pending.pop();
-    if (!nodeId || visited.has(nodeId)) continue;
-    if (nodeId === source) return true;
-    visited.add(nodeId);
-    pending.push(...(outgoing.get(nodeId) ?? []));
-  }
-  return false;
-}
-
 export function updateGraphNode(
   graph: PipelineGraph,
   updatedNode: PipelineGraphNode