GovOPlaN/govoplan-files
1
0
Fork 0
Code Issues 13 Pull Requests Actions Packages Projects Releases Wiki Activity

[Bug] File upload drop target does not accept dropped files reliably #31

New Issue
Closed
opened 2026-07-14 20:08:42 +02:00 by zemion · 6 comments
zemion commented 2026-07-14 20:08:42 +02:00
Owner
Copy Link

Problem / User Need

The file upload drop target currently does not work reliably. Users expect to drag files into the upload area and have them accepted.

Acceptance Criteria

  • Dropping files onto the upload drop target triggers the same upload flow as selecting files manually.
  • Rejected drops show a clear reason.
  • The behavior is covered by a focused UI/component regression test where feasible.
## Problem / User Need The file upload drop target currently does not work reliably. Users expect to drag files into the upload area and have them accepted. ## Acceptance Criteria - Dropping files onto the upload drop target triggers the same upload flow as selecting files manually. - Rejected drops show a clear reason. - The behavior is covered by a focused UI/component regression test where feasible.
zemion commented 2026-07-15 00:34:46 +02:00
Author
Owner
Copy Link

Codex State: done

Summary

  • Fixed unreliable upload drops by passing the intended file target directly instead of relying on immediate dialog state updates.
  • Upload rejection paths now surface clear errors for missing permission, missing destination, connector targets, and non-file drops.

Changed Files

  • webui/src/features/files/FilesPage.tsx

Verification

  • GOVOPLAN_WEBUI_MODULE_PACKAGES=@govoplan/files-webui npm run build in govoplan-core/webui passed.

Next / Blocked

  • Close after the govoplan-files change is committed and pushed.
## Codex State: done ### Summary - Fixed unreliable upload drops by passing the intended file target directly instead of relying on immediate dialog state updates. - Upload rejection paths now surface clear errors for missing permission, missing destination, connector targets, and non-file drops. ### Changed Files - `webui/src/features/files/FilesPage.tsx` ### Verification - `GOVOPLAN_WEBUI_MODULE_PACKAGES=@govoplan/files-webui npm run build in govoplan-core/webui passed.` ### Next / Blocked - Close after the govoplan-files change is committed and pushed.
zemion commented 2026-07-15 00:43:43 +02:00
Author
Owner
Copy Link

Codex State: done

Summary

  • Follow-up fix: hardened the shared FileDropZone used by the upload dialog so filesystem drops are accepted on dragenter/dragover, propagation is stopped, and files are extracted from DataTransfer.files or DataTransfer.items.
  • Files upload dialog now displays an explicit error when a dialog drop is rejected instead of silently ignoring it.
  • The main file pane also now consumes file drops to avoid the browser opening the dropped file.

Changed Files

  • /mnt/DATA/git/govoplan-core/webui/src/components/FileDropZone.tsx
  • webui/src/features/files/FilesPage.tsx

Verification

  • GOVOPLAN_WEBUI_MODULE_PACKAGES=@govoplan/files-webui npm run build in govoplan-core/webui passed.

Next / Blocked

  • Please hard refresh the running dev page; if the dialog still ignores drops, check the browser console/network panel while dropping because the event path should now either upload or show an error.
## Codex State: done ### Summary - Follow-up fix: hardened the shared FileDropZone used by the upload dialog so filesystem drops are accepted on dragenter/dragover, propagation is stopped, and files are extracted from DataTransfer.files or DataTransfer.items. - Files upload dialog now displays an explicit error when a dialog drop is rejected instead of silently ignoring it. - The main file pane also now consumes file drops to avoid the browser opening the dropped file. ### Changed Files - `/mnt/DATA/git/govoplan-core/webui/src/components/FileDropZone.tsx` - `webui/src/features/files/FilesPage.tsx` ### Verification - `GOVOPLAN_WEBUI_MODULE_PACKAGES=@govoplan/files-webui npm run build in govoplan-core/webui passed.` ### Next / Blocked - Please hard refresh the running dev page; if the dialog still ignores drops, check the browser console/network panel while dropping because the event path should now either upload or show an error.
zemion commented 2026-07-15 00:48:18 +02:00
Author
Owner
Copy Link

Codex State: progress

Summary

  • Extended the upload-dialog drop zone to extract files not only from DataTransfer.files, but also from DataTransferItem.getAsFile(), Chromium file-system handles, and legacy webkit entries.
  • If the browser still exposes only an unreadable URI/path, the warning now says that explicitly instead of asking for a file again.

Changed Files

  • /mnt/DATA/git/govoplan-core/webui/src/components/FileDropZone.tsx
  • webui/src/features/files/FilesPage.tsx

Verification

  • GOVOPLAN_WEBUI_MODULE_PACKAGES=@govoplan/files-webui npm run build in govoplan-core/webui passed.

Next / Blocked

  • Retest after hard refresh. If the red unreadable-file warning remains, the drag source/browser is not exposing file contents to web apps; selecting via the file picker should still work and the remaining work is source/browser-specific diagnostics.

Suggested status label: status/in-progress

## Codex State: progress ### Summary - Extended the upload-dialog drop zone to extract files not only from DataTransfer.files, but also from DataTransferItem.getAsFile(), Chromium file-system handles, and legacy webkit entries. - If the browser still exposes only an unreadable URI/path, the warning now says that explicitly instead of asking for a file again. ### Changed Files - `/mnt/DATA/git/govoplan-core/webui/src/components/FileDropZone.tsx` - `webui/src/features/files/FilesPage.tsx` ### Verification - `GOVOPLAN_WEBUI_MODULE_PACKAGES=@govoplan/files-webui npm run build in govoplan-core/webui passed.` ### Next / Blocked - Retest after hard refresh. If the red unreadable-file warning remains, the drag source/browser is not exposing file contents to web apps; selecting via the file picker should still work and the remaining work is source/browser-specific diagnostics. Suggested status label: `status/in-progress`
zemion commented 2026-07-20 14:34:46 +02:00
Author
Owner
Copy Link

Retest update, 2026-07-20: the Files-only/combined production WebUI build and affected diff checks pass. Static inspection confirms direct target handoff, DataTransfer.files/items/handle fallbacks, drag-event cancellation, and explicit rejection messages.

Closure is premature because the shared FileDropZone change in govoplan-core and the FilesPage change in govoplan-files are both still uncommitted, and this environment has no browser/DOM harness for a real drag/drop smoke test. Keeping this in progress until both changes are integrated and these browser checks pass:

  1. Dialog drop uploads exactly once into the selected folder.
  2. Current-pane/folder-target drop uses that exact target.
  3. Non-file or unreadable drops show a clear reason.
  4. Connector, missing-permission, and busy states reject with the correct reason.
  5. File-picker upload still follows the same path.
Retest update, 2026-07-20: the Files-only/combined production WebUI build and affected diff checks pass. Static inspection confirms direct target handoff, `DataTransfer.files`/items/handle fallbacks, drag-event cancellation, and explicit rejection messages. Closure is premature because the shared `FileDropZone` change in `govoplan-core` and the `FilesPage` change in `govoplan-files` are both still uncommitted, and this environment has no browser/DOM harness for a real drag/drop smoke test. Keeping this in progress until both changes are integrated and these browser checks pass: 1. Dialog drop uploads exactly once into the selected folder. 2. Current-pane/folder-target drop uses that exact target. 3. Non-file or unreadable drops show a clear reason. 4. Connector, missing-permission, and busy states reject with the correct reason. 5. File-picker upload still follows the same path.
zemion commented 2026-07-20 15:30:11 +02:00
Author
Owner
Copy Link

Added strong local regression evidence without external test dependencies:

  • pure resolver tests cover DataTransfer.files, getAsFile(), File System Access file/nested-directory handles, legacy WebKit file entries, empty/unreadable paths, and precedence/no duplicate resolution
  • structural checks cover drag-event cancellation, rejection routing, and explicit selected-target forwarding in FilesPage

npm run test:file-drop-zone, npm run test:file-drop-target, Core structural i18n audit, Files-only production build (1,904 modules), and both diff checks pass.

Keeping the issue open: these source-level tests cannot prove real browser/OS DataTransfer interoperability. One browser smoke must still verify exactly-once dialog upload, current/folder target selection, clear rejection states, and file-picker parity after the local Core and Files changes are integrated.

<!-- codex-progress-file-drop-regression-2026-07-20 --> Added strong local regression evidence without external test dependencies: - pure resolver tests cover `DataTransfer.files`, `getAsFile()`, File System Access file/nested-directory handles, legacy WebKit file entries, empty/unreadable paths, and precedence/no duplicate resolution - structural checks cover drag-event cancellation, rejection routing, and explicit selected-target forwarding in `FilesPage` `npm run test:file-drop-zone`, `npm run test:file-drop-target`, Core structural i18n audit, Files-only production build (1,904 modules), and both diff checks pass. Keeping the issue open: these source-level tests cannot prove real browser/OS `DataTransfer` interoperability. One browser smoke must still verify exactly-once dialog upload, current/folder target selection, clear rejection states, and file-picker parity after the local Core and Files changes are integrated.
zemion commented 2026-07-20 16:41:03 +02:00
Author
Owner
Copy Link

Codex State: done

Summary

  • The file-list surface and upload dialog now route dropped local files through the same explicit-target upload path as the file picker.
  • Rejected drops report permission, destination, connector-space, busy-state, or unreadable-browser-payload reasons instead of failing silently.
  • The reported Zen Browser environment also rejects displaying local files, so that remaining behavior points to browser/local-file exposure rather than the GovOPlaN drop target.

Changed Files

  • webui/src/features/files/FilesPage.tsx
  • webui/scripts/test-file-drop-target-structure.mjs
  • ../govoplan-core/webui/src/components/FileDropZone.tsx
  • ../govoplan-core/webui/src/components/resolveDroppedFiles.ts

Verification

  • govoplan-files/webui: npm run test:file-drop-target (pass)
  • govoplan-core/webui: npm run test:file-drop-zone (pass)
  • govoplan-core/webui: npm run build (pass)

Next / Blocked

  • Reopen with browser/version and console evidence if a browser that exposes local File objects still fails.
## Codex State: done ### Summary - The file-list surface and upload dialog now route dropped local files through the same explicit-target upload path as the file picker. - Rejected drops report permission, destination, connector-space, busy-state, or unreadable-browser-payload reasons instead of failing silently. - The reported Zen Browser environment also rejects displaying local files, so that remaining behavior points to browser/local-file exposure rather than the GovOPlaN drop target. ### Changed Files - `webui/src/features/files/FilesPage.tsx` - `webui/scripts/test-file-drop-target-structure.mjs` - `../govoplan-core/webui/src/components/FileDropZone.tsx` - `../govoplan-core/webui/src/components/resolveDroppedFiles.ts` ### Verification - `govoplan-files/webui: npm run test:file-drop-target (pass)` - `govoplan-core/webui: npm run test:file-drop-zone (pass)` - `govoplan-core/webui: npm run build (pass)` ### Next / Blocked - Reopen with browser/version and console evidence if a browser that exposes local File objects still fails.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
HTTP API contracts, routers, schemas, or API smoke behavior.
area/auth
Authentication, sessions, access bootstrap, or login behavior.
area/db
Database sessions, models, transactions, or persistence primitives.
area/devex
Local developer workflow, scripts, tests, tooling, or release helpers.
area/docs
Durable documentation and project guidance.
area/governance
Governance policy, audit, privacy, retention, or compliance behavior.
area/marketing
Public website, product messaging, publication copy, or legal page content.
area/migrations
Alembic migrations, schema bootstrap, or persistence evolution.
area/module-system
Module discovery, manifests, capabilities, routing, or optional integrations.
area/rbac
Permissions, roles, delegation, or authorization policy.
area/release
Versioning, release locks, tags, packaging, or dependency pins.
area/security
Security posture, static analysis, supply-chain hardening, or vulnerability remediation.
area/tenancy
Tenant boundaries, provisioning, or tenant-scoped data behavior.
area/webui
Shared WebUI shell, frontend components, routing, or frontend tests.
audit/complexity
Complexity finding from Radon, Xenon, or equivalent maintainability scans.
audit/duplication
Duplicated-code finding from jscpd or equivalent similarity scans.
audit/false-positive
Audit finding reviewed as a narrow false positive or acceptable risk.
audit/needs-design
Audit finding that needs an architectural or product decision before implementation.
audit/quick-fix
Audit finding that appears narrow and directly fixable.
audit/structural
Audit finding that needs design, refactoring, or behavior review.
codex/needs-human
Needs an explicit human decision before Codex should implement.
codex/ready
Suitable for Codex to pick up with the existing issue context.
module/access
GovOPlaN access, identity, authentication, RBAC, and administration behavior.
module/addresses
GovOPlaN Addresses module behavior or integration.
module/admin
GovOPlaN Admin module behavior or integration.
module/appointments
GovOPlaN Appointments module behavior or integration.
module/audit
GovOPlaN Audit module behavior or integration.
module/calendar
GovOPlaN Calendar module behavior or integration.
module/campaign
GovOPlaN campaign module behavior or integration.
module/cases
GovOPlaN Cases module behavior or integration.
module/connectors
GovOPlaN Connectors module behavior or integration.
module/core
GovOPlaN core runner, shared primitives, shell, or extension points.
module/dataflow
GovOPlaN Dataflow module behavior or integration.
module/datasources
GovOPlaN governed datasource contracts, catalogs, and integrations.
module/dist-lists
GovOPlaN Distribution Lists module behavior or integration.
module/dms
GovOPlaN Dms module behavior or integration.
module/erp
GovOPlaN Erp module behavior or integration.
module/evaluation
GovOPlaN Evaluation module behavior or integration.
module/files
GovOPlaN files module behavior or integration.
module/fit-connect
GovOPlaN Fit Connect module behavior or integration.
module/forms
GovOPlaN Forms module behavior or integration.
module/identity
GovOPlaN Identity module behavior or integration.
module/identity-trust
GovOPlaN Identity Trust module behavior or integration.
module/idm
GovOPlaN Idm module behavior or integration.
module/ledger
GovOPlaN Ledger module behavior or integration.
module/mail
GovOPlaN mail module behavior or integration.
module/notifications
GovOPlaN Notifications module behavior or integration.
module/ops
GovOPlaN Ops module behavior or integration.
module/organizations
GovOPlaN Organizations module behavior or integration.
module/payments
GovOPlaN Payments module behavior or integration.
module/permits
GovOPlaN Permits module behavior or integration.
module/policy
GovOPlaN Policy module behavior or integration.
module/poll
GovOPlaN Poll module behavior or integration.
module/portal
GovOPlaN Portal module behavior or integration.
module/postbox
GovOPlaN Postbox module behavior or integration.
module/reporting
GovOPlaN Reporting module behavior or integration.
module/risk-compliance
GovOPlaN Risk Compliance module behavior or integration.
module/scheduling
GovOPlaN Scheduling module behavior or integration.
module/search
GovOPlaN Search module behavior or integration.
module/tasks
GovOPlaN Tasks module behavior or integration.
module/templates
GovOPlaN Templates module behavior or integration.
module/tenancy
GovOPlaN Tenancy module behavior or integration.
module/views
GovOPlaN governed task views, interface projections, and workflow view integration.
module/workflow
GovOPlaN Workflow module behavior or integration.
module/xoev
GovOPlaN Xoev module behavior or integration.
module/xrechnung
GovOPlaN Xrechnung module behavior or integration.
module/xta-osci
GovOPlaN Xta Osci module behavior or integration.
priority
p0
Immediate stop-the-line priority.
priority
p1
High priority for the next focused work window.
priority
p2
Normal planned priority.
priority
p3
Low priority or opportunistic cleanup.
source/backlog-import
Imported from markdown backlog, roadmap, plan, or TODO files.
source/security-audit
Created from a structured security or code-quality audit report.
source/todo-scan
Imported from inline TODO/FIXME/HACK markers by the Gitea TODO importer.
status
blocked
Cannot progress without a decision, dependency, credential, or external change.
status
in-progress
Currently being worked.
status
needs-info
Needs clarifying input before implementation can proceed safely.
status
ready
Ready for implementation.
status
triage
Needs review, ownership, priority, or acceptance criteria.
type
bug
A reproducible defect, regression, or incorrect behavior.
type
debt
Cleanup, refactoring, risk reduction, or deferred engineering work.
type
docs
Documentation, process, or developer workflow work.
type
feature
New user-visible behavior or platform capability.
type
task
Implementation, maintenance, migration, or operational work.
type
user-story
End-to-end user journey or real-world process story used to steer product slices.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zemion
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GovOPlaN/govoplan-files#31
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?