feat: enforce Mail-owned campaign transport boundary
This commit is contained in:
@@ -1,9 +1,11 @@
|
||||
from __future__ import annotations
|
||||
|
||||
import unittest
|
||||
from types import SimpleNamespace
|
||||
from unittest.mock import patch
|
||||
|
||||
from govoplan_core.core.modules import ModuleManifest
|
||||
from govoplan_mail.backend.manifest import get_manifest
|
||||
from govoplan_core.core.modules import MigrationRetirementPlan, ModuleManifest
|
||||
from govoplan_mail.backend.manifest import _mail_retirement_provider, get_manifest
|
||||
|
||||
|
||||
class MailManifestTests(unittest.TestCase):
|
||||
@@ -14,6 +16,62 @@ class MailManifestTests(unittest.TestCase):
|
||||
self.assertEqual(manifest.id, "mail")
|
||||
self.assertIn("addresses", manifest.optional_dependencies)
|
||||
self.assertIn("addresses.lookup", {interface.name for interface in manifest.requires_interfaces})
|
||||
self.assertIn(
|
||||
{"name": "mail.campaign_delivery", "version": "0.2.0"},
|
||||
[
|
||||
{"name": interface.name, "version": interface.version}
|
||||
for interface in manifest.provides_interfaces
|
||||
],
|
||||
)
|
||||
topics = {topic.id: topic for topic in manifest.documentation}
|
||||
ownership = topics["mail.profile-ownership-and-consumers"]
|
||||
self.assertEqual(ownership.metadata["kind"], "reference")
|
||||
self.assertEqual(ownership.metadata["route"], "/mail")
|
||||
self.assertIn("campaigns.mail-profile-user-journey", ownership.metadata["related_topic_ids"])
|
||||
|
||||
def test_retirement_scrubs_credentials_before_dropping_mail_tables(self) -> None:
|
||||
events: list[str] = []
|
||||
|
||||
def table_provider(_session, _module_id):
|
||||
return MigrationRetirementPlan(
|
||||
supported=True,
|
||||
summary="Mail tables",
|
||||
destroy_data_supported=True,
|
||||
destroy_data_executor=lambda _execute_session, _execute_module_id: events.append("drop"),
|
||||
)
|
||||
|
||||
session = SimpleNamespace(get_bind=lambda: object(), query=lambda *_args: None)
|
||||
inspector = SimpleNamespace(has_table=lambda _name: True)
|
||||
with (
|
||||
patch("govoplan_mail.backend.manifest._mail_table_retirement_provider", table_provider),
|
||||
patch("govoplan_mail.backend.manifest.inspect", return_value=inspector),
|
||||
patch(
|
||||
"govoplan_mail.backend.mail_profiles.delete_mail_profile_credentials_for_retirement",
|
||||
side_effect=lambda _session: events.append("scrub"),
|
||||
),
|
||||
):
|
||||
plan = _mail_retirement_provider(session, "mail")
|
||||
assert plan.destroy_data_executor is not None
|
||||
plan.destroy_data_executor(session, "mail")
|
||||
|
||||
self.assertEqual(events, ["scrub", "drop"])
|
||||
self.assertTrue(any("audit" in warning for warning in plan.destroy_data_warnings))
|
||||
|
||||
events.clear()
|
||||
with (
|
||||
patch("govoplan_mail.backend.manifest._mail_table_retirement_provider", table_provider),
|
||||
patch("govoplan_mail.backend.manifest.inspect", return_value=inspector),
|
||||
patch(
|
||||
"govoplan_mail.backend.mail_profiles.delete_mail_profile_credentials_for_retirement",
|
||||
side_effect=RuntimeError("audit unavailable"),
|
||||
),
|
||||
):
|
||||
blocked_plan = _mail_retirement_provider(session, "mail")
|
||||
assert blocked_plan.destroy_data_executor is not None
|
||||
with self.assertRaisesRegex(RuntimeError, "audit unavailable"):
|
||||
blocked_plan.destroy_data_executor(session, "mail")
|
||||
|
||||
self.assertEqual(events, [])
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
|
||||
Reference in New Issue
Block a user