feat(scheduling): enforce governed response policies

tests/test_migrations.py

@@ -20,7 +20,7 @@ from govoplan_scheduling.backend.db.models import (
 from govoplan_scheduling.backend.manifest import get_manifest as get_scheduling_manifest
 
 
-_SCHEDULING_HEAD = "9c2f4a7d1e6b"
+_SCHEDULING_HEAD = "ad7e3c9b2f10"
 _ENABLED_MODULES = ("poll", "scheduling")
 _MANIFEST_FACTORIES = (get_poll_manifest, get_scheduling_manifest)
 
@@ -110,12 +110,27 @@ class SchedulingMigrationTests(unittest.TestCase):
                             "scheduling_requests"
                         )
                     }
+                    participant_columns = {
+                        item["name"]
+                        for item in inspect(connection).get_columns(
+                            "scheduling_participants"
+                        )
+                    }
                     visibility = connection.execute(
                         text(
                             "SELECT participant_visibility FROM scheduling_requests "
                             "WHERE id = 'request-1'"
                         )
                     ).scalar_one()
+                    response_defaults = connection.execute(
+                        text(
+                            "SELECT notify_on_answers, single_choice, "
+                            "max_participants_per_option, allow_maybe, allow_comments, "
+                            "participant_email_required, anonymous_password_protection_enabled, "
+                            "anonymous_password_hash FROM scheduling_requests "
+                            "WHERE id = 'request-1'"
+                        )
+                    ).one()
                     counts = {
                         model.__tablename__: connection.execute(
                             select(func.count()).select_from(model)
@@ -130,7 +145,11 @@ class SchedulingMigrationTests(unittest.TestCase):
 
                 self.assertIn(_SCHEDULING_HEAD, heads)
                 self.assertIn("participant_visibility", columns)
+                self.assertIn("max_participants_per_option", columns)
+                self.assertIn("response_comment", participant_columns)
+                self.assertIn("participation_gateway", participant_columns)
                 self.assertEqual(visibility, "aggregates_only")
+                self.assertEqual(tuple(response_defaults), (1, 0, None, 1, 0, 0, 0, None))
                 self.assertEqual(set(counts.values()), {1})
             finally:
                 engine.dispose()
@@ -219,6 +238,74 @@ class SchedulingMigrationTests(unittest.TestCase):
             finally:
                 engine.dispose()
 
+    def test_rejects_partial_existing_response_settings(self) -> None:
+        with tempfile.TemporaryDirectory(
+            prefix="govoplan-scheduling-migration-"
+        ) as directory:
+            url = f"sqlite:///{Path(directory) / 'scheduling.db'}"
+            self._migrate(url)
+            engine = create_engine(url)
+            try:
+                with engine.begin() as connection:
+                    self._remove_scheduling_revision(
+                        connection,
+                        remove_privacy_column=False,
+                    )
+                    connection.execute(
+                        text(
+                            "ALTER TABLE scheduling_requests "
+                            "DROP COLUMN allow_comments"
+                        )
+                    )
+
+                with self.assertRaisesRegex(
+                    RuntimeError,
+                    "partial scheduling_requests scheduling response settings",
+                ):
+                    self._migrate(url)
+
+                with engine.connect() as connection:
+                    heads = set(
+                        MigrationContext.configure(connection).get_current_heads()
+                    )
+                self.assertNotIn(_SCHEDULING_HEAD, heads)
+            finally:
+                engine.dispose()
+
+    def test_rejects_partial_existing_participant_response_settings(self) -> None:
+        with tempfile.TemporaryDirectory(
+            prefix="govoplan-scheduling-migration-"
+        ) as directory:
+            url = f"sqlite:///{Path(directory) / 'scheduling.db'}"
+            self._migrate(url)
+            engine = create_engine(url)
+            try:
+                with engine.begin() as connection:
+                    self._remove_scheduling_revision(
+                        connection,
+                        remove_privacy_column=False,
+                    )
+                    connection.execute(
+                        text(
+                            "ALTER TABLE scheduling_participants "
+                            "DROP COLUMN participation_gateway"
+                        )
+                    )
+
+                with self.assertRaisesRegex(
+                    RuntimeError,
+                    "partial scheduling_participants scheduling response settings",
+                ):
+                    self._migrate(url)
+
+                with engine.connect() as connection:
+                    heads = set(
+                        MigrationContext.configure(connection).get_current_heads()
+                    )
+                self.assertNotIn(_SCHEDULING_HEAD, heads)
+            finally:
+                engine.dispose()
+
 
 if __name__ == "__main__":
     unittest.main()