GovOPlaN/govoplan-views
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Guard View surface tree traversal

Browse Source
This commit is contained in:
Albrecht Degering
2026-07-28 21:32:28 +02:00
parent ca615df36e
commit 34221b633b
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
webui/src/features/views/ViewsAdminPanel.tsx
View File

@@ -1054,10 +1054,12 @@ function SurfaceSelector({
function descendants(surfaceId: string): string[] { function descendants(surfaceId: string): string[] {
const result: string[] = []; const result: string[] = [];
const visited = new Set([surfaceId]);
const pending = [...(childrenByParent.get(surfaceId) ?? [])]; const pending = [...(childrenByParent.get(surfaceId) ?? [])];
while (pending.length) { while (pending.length) {
const child = pending.shift(); const child = pending.shift();
if (!child) continue; if (!child || visited.has(child.id)) continue;
visited.add(child.id);
result.push(child.id); result.push(child.id);
pending.push(...(childrenByParent.get(child.id) ?? [])); pending.push(...(childrenByParent.get(child.id) ?? []));
} }
@@ -1065,8 +1067,11 @@ function SurfaceSelector({
} }
function withAncestors(next: Set<string>, surfaceId: string) { function withAncestors(next: Set<string>, surfaceId: string) {
const visited = new Set([surfaceId]);
let current = byId.get(surfaceId); let current = byId.get(surfaceId);
while (current?.parentId) { while (current?.parentId) {
if (visited.has(current.parentId)) break;
visited.add(current.parentId);
next.add(current.parentId); next.add(current.parentId);
current = byId.get(current.parentId); current = byId.get(current.parentId);
} }