chore: harden audit checks and issue taxonomy
This commit is contained in:
@@ -74,6 +74,8 @@ PY
|
||||
"$PYTHON" -m unittest discover -s /mnt/DATA/git/govoplan-dataflow/tests
|
||||
"$PYTHON" -m unittest discover -s /mnt/DATA/git/govoplan-workflow/tests
|
||||
"$PYTHON" -m unittest discover -s /mnt/DATA/git/govoplan-views/tests
|
||||
"$PYTHON" -m unittest discover -s /mnt/DATA/git/govoplan-dashboard/tests
|
||||
"$PYTHON" -m unittest discover -s /mnt/DATA/git/govoplan-postbox/tests
|
||||
"$PYTHON" "$META_ROOT/tools/checks/check-datasource-composition.py"
|
||||
"$PYTHON" -m unittest discover -s /mnt/DATA/git/govoplan-mail/tests
|
||||
"$PYTHON" -m unittest tests.test_api_smoke.ApiSmokeTests.test_mailbox_message_listing_reports_total_count
|
||||
@@ -92,6 +94,12 @@ cd /mnt/DATA/git/govoplan-datasources/webui
|
||||
cd /mnt/DATA/git/govoplan-workflow/webui
|
||||
"$NPM" run typecheck
|
||||
|
||||
cd /mnt/DATA/git/govoplan-dashboard/webui
|
||||
"$NPM" run test:dashboard-layout
|
||||
|
||||
cd /mnt/DATA/git/govoplan-postbox/webui
|
||||
"$NPM" run test:ui-structure
|
||||
|
||||
cd /mnt/DATA/git/govoplan-mail/webui
|
||||
"$NPM" run test:mail-ui
|
||||
|
||||
|
||||
@@ -496,7 +496,12 @@ run_bandit() {
|
||||
fi
|
||||
if [[ "${#PY_TEST_ROOTS[@]}" -gt 0 ]]; then
|
||||
prepare_machine_report "$REPORTS_DIR/bandit-tests.json" || return 2
|
||||
bandit -r "${PY_TEST_ROOTS[@]}" -f json -o "$REPORTS_DIR/bandit-tests.json"
|
||||
# Tests intentionally use assertions and synthetic credentials. Keep the
|
||||
# separate test scan useful by excluding only those test-specific signals.
|
||||
bandit -r "${PY_TEST_ROOTS[@]}" \
|
||||
--skip B101,B105,B106,B107 \
|
||||
-f json \
|
||||
-o "$REPORTS_DIR/bandit-tests.json"
|
||||
local test_status=$?
|
||||
[[ "$test_status" -le 1 ]] || status=2
|
||||
fi
|
||||
@@ -512,7 +517,11 @@ run_ruff_security() {
|
||||
fi
|
||||
if [[ "${#PY_TEST_ROOTS[@]}" -gt 0 ]]; then
|
||||
prepare_machine_report "$REPORTS_DIR/ruff-security-tests.json" || return 2
|
||||
ruff check --select S --output-format json "${PY_TEST_ROOTS[@]}" > "$REPORTS_DIR/ruff-security-tests.json"
|
||||
ruff check \
|
||||
--select S \
|
||||
--ignore S101,S105,S106,S107 \
|
||||
--output-format json \
|
||||
"${PY_TEST_ROOTS[@]}" > "$REPORTS_DIR/ruff-security-tests.json"
|
||||
local test_status=$?
|
||||
[[ "$test_status" -le 1 ]] || status=2
|
||||
fi
|
||||
@@ -582,14 +591,32 @@ run_trivy() {
|
||||
run_pip_audit_manifests() {
|
||||
local status=0
|
||||
for repo in "${REPOS[@]}"; do
|
||||
[[ -f "$repo/requirements.txt" ]] || continue
|
||||
local name
|
||||
name="$(safe_name "$repo")"
|
||||
prepare_machine_report "$REPORTS_DIR/pip-audit-$name.json" || return 2
|
||||
# Requirements may contain project-relative entries such as `.[server]`.
|
||||
# Resolve them from the owning repository instead of the meta-repository.
|
||||
(cd "$repo" && pip-audit -r requirements.txt --progress-spinner off --format json --output "$REPORTS_DIR/pip-audit-$name.json")
|
||||
accumulate_exit_status status "$?"
|
||||
local repo_name
|
||||
repo_name="$(safe_name "$repo")"
|
||||
while IFS= read -r -d '' requirements_file; do
|
||||
local manifest_name report_path
|
||||
manifest_name="$(safe_name "$requirements_file")"
|
||||
report_path="$REPORTS_DIR/pip-audit-$repo_name-$manifest_name.json"
|
||||
prepare_machine_report "$report_path" || return 2
|
||||
# Requirements may contain project-relative entries such as `.[server]`.
|
||||
# Resolve them from the owning repository instead of the meta-repository.
|
||||
(
|
||||
cd "$repo" &&
|
||||
pip-audit \
|
||||
-r "$(basename "$requirements_file")" \
|
||||
--progress-spinner off \
|
||||
--format json \
|
||||
--output "$report_path"
|
||||
)
|
||||
accumulate_exit_status status "$?"
|
||||
done < <(
|
||||
find "$repo" \
|
||||
-maxdepth 1 \
|
||||
-type f \
|
||||
-name 'requirements*.txt' \
|
||||
-print0 |
|
||||
sort -z
|
||||
)
|
||||
done
|
||||
return "$status"
|
||||
}
|
||||
@@ -597,12 +624,38 @@ run_pip_audit_manifests() {
|
||||
run_npm_audit_manifests() {
|
||||
local status=0
|
||||
for repo in "${REPOS[@]}"; do
|
||||
[[ -f "$repo/webui/package-lock.json" ]] || continue
|
||||
local name
|
||||
name="$(safe_name "$repo")"
|
||||
prepare_machine_report "$REPORTS_DIR/npm-audit-$name.json" || return 2
|
||||
(cd "$repo/webui" && npm audit --omit=dev --json > "$REPORTS_DIR/npm-audit-$name.json")
|
||||
accumulate_exit_status status "$?"
|
||||
local repo_name
|
||||
repo_name="$(safe_name "$repo")"
|
||||
while IFS= read -r -d '' lock_file; do
|
||||
local lock_dir lock_name runtime_report all_report
|
||||
lock_dir="$(dirname "$lock_file")"
|
||||
lock_name="$(
|
||||
printf '%s' "${lock_file#"$repo"/}" |
|
||||
tr -c 'A-Za-z0-9_.-' '_'
|
||||
)"
|
||||
runtime_report="$REPORTS_DIR/npm-audit-runtime-$repo_name-$lock_name.json"
|
||||
all_report="$REPORTS_DIR/npm-audit-all-$repo_name-$lock_name.json"
|
||||
prepare_machine_report "$runtime_report" || return 2
|
||||
(
|
||||
cd "$lock_dir" &&
|
||||
npm audit --omit=dev --json > "$runtime_report"
|
||||
)
|
||||
accumulate_exit_status status "$?"
|
||||
prepare_machine_report "$all_report" || return 2
|
||||
(
|
||||
cd "$lock_dir" &&
|
||||
npm audit --json > "$all_report"
|
||||
)
|
||||
accumulate_exit_status status "$?"
|
||||
done < <(
|
||||
find "$repo" \
|
||||
-maxdepth 3 \
|
||||
-type f \
|
||||
-name package-lock.json \
|
||||
-not -path '*/node_modules/*' \
|
||||
-print0 |
|
||||
sort -z
|
||||
)
|
||||
done
|
||||
return "$status"
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user