Release v0.1.2

src/govoplan_campaign/backend/campaign/validation.py

@@ -301,25 +301,27 @@ def validate_campaign_config(
     issues.extend(_attachment_path_issues(config))
     issues.extend(_zip_configuration_issues(config))
 
-    if config.server.imap and config.server.imap.enabled:
-        missing = [name for name in ["host", "port", "username", "password"] if getattr(config.server.imap, name) in (None, "")]
-        if missing:
+    runtime_imap = config.server.runtime_imap_config()
+    if config.delivery.imap_append_sent.enabled:
+        if runtime_imap is None:
             issues.append(_issue(
-                Severity.ERROR,
-                "incomplete_imap_config",
-                "IMAP append is enabled, but these IMAP settings are missing: " + ", ".join(missing),
-                "/server/imap",
+                Severity.WARNING,
+                "delivery_imap_enabled_without_server_imap",
+                "delivery.imap_append_sent is enabled, but no server.imap configuration is present",
+                "/delivery/imap_append_sent/enabled",
             ))
+        else:
+            missing = [name for name in ["host", "port", "username", "password"] if getattr(runtime_imap, name) in (None, "")]
+            if missing:
+                issues.append(_issue(
+                    Severity.ERROR,
+                    "incomplete_imap_config",
+                    "IMAP append is enabled, but these IMAP settings are missing: " + ", ".join(missing),
+                    "/server/imap",
+                ))
 
-    if config.delivery.imap_append_sent.enabled and not (config.server.imap and config.server.imap.enabled):
-        issues.append(_issue(
-            Severity.WARNING,
-            "delivery_imap_enabled_without_server_imap",
-            "delivery.imap_append_sent is enabled, but server.imap.enabled is not true",
-            "/delivery/imap_append_sent/enabled",
-        ))
-
-    if config.campaign.mode == "send" and not config.server.smtp:
+    runtime_smtp = config.server.runtime_smtp_config()
+    if config.campaign.mode == "send" and not runtime_smtp:
         issues.append(_issue(
             Severity.ERROR,
             "missing_smtp_config",
@@ -327,8 +329,8 @@ def validate_campaign_config(
             "/server/smtp",
         ))
 
-    if config.server.smtp:
-        missing = [name for name in ["host", "port"] if getattr(config.server.smtp, name) in (None, "")]
+    if runtime_smtp:
+        missing = [name for name in ["host", "port"] if getattr(runtime_smtp, name) in (None, "")]
         if missing:
             issues.append(_issue(
                 Severity.WARNING,