add-ideas/govoplan-campaign
1
0
Fork 0
Code Issues 49 Pull Requests Actions Packages Projects Releases Wiki Activity

[Debt] Refactor high-complexity campaign validation, sending, and reporting code #54

New Issue
Closed
opened 2026-07-11 12:51:21 +02:00 by zemion · 3 comments
zemion commented 2026-07-11 12:51:21 +02:00
Owner
Copy Link

Xenon/Radon show several E/F/D-ranked campaign functions. This is the largest maintainability cluster in the full audit.

Classification: structural maintainability work.

Report evidence:

  • validate_campaign_config rank F.
  • validate_campaign_partial rank F.
  • run_mock_campaign_send rank F.
  • build_entry_message rank E.
  • _campaign_workspace_delta_response rank E.
  • generate_campaign_report rank E.
  • send_campaign_job, _update_campaign_after_job rank D.

Suggested next steps:

  • Prioritize validation and message-building first, because they are user-facing and security-adjacent.
  • Extract smaller pure helpers with fixtures for ZIP/attachment/message/report paths.
  • Keep behavior stable and reduce one cluster per PR.

Baseline report directory: audit-reports/govoplan-full-20260711-1238

<!-- codex-audit-full-2026-07-11:campaign-complexity-baseline --> Xenon/Radon show several E/F/D-ranked campaign functions. This is the largest maintainability cluster in the full audit. Classification: **structural maintainability work**. Report evidence: - `validate_campaign_config` rank F. - `validate_campaign_partial` rank F. - `run_mock_campaign_send` rank F. - `build_entry_message` rank E. - `_campaign_workspace_delta_response` rank E. - `generate_campaign_report` rank E. - `send_campaign_job`, `_update_campaign_after_job` rank D. Suggested next steps: - Prioritize validation and message-building first, because they are user-facing and security-adjacent. - Extract smaller pure helpers with fixtures for ZIP/attachment/message/report paths. - Keep behavior stable and reduce one cluster per PR. Baseline report directory: `audit-reports/govoplan-full-20260711-1238`
zemion added the
type
debt
priority
p3
status
ready
module/campaign
codex/ready
 labels 2026-07-11 12:51:21 +02:00
zemion added the
audit/complexity
audit/structural
source/security-audit
 labels 2026-07-11 16:10:09 +02:00
zemion commented 2026-07-14 01:52:26 +02:00
Author
Owner
Copy Link

Codex State: progress

Summary

  • Current Xenon state after the latest cleanup: validate_campaign_partial and build_entry_message are no longer above threshold.
  • Remaining campaign hotspots are validate_campaign_config and ZIP configuration validation; mock campaign sending; workspace delta/review metadata routing; review-state persistence; campaign report generation; and send-job/update orchestration.
  • Closing newer duplicate tracker govoplan-campaign#58 as superseded by this issue.

Verification

  • xenon --max-absolute C on src/govoplan_campaign still reports the remaining blocks listed above.

Next / Blocked

  • Tackle one cluster at a time, starting with semantic validation or mock sending, with focused fixtures.

Suggested status label: status/in-progress

## Codex State: progress ### Summary - Current Xenon state after the latest cleanup: validate_campaign_partial and build_entry_message are no longer above threshold. - Remaining campaign hotspots are validate_campaign_config and ZIP configuration validation; mock campaign sending; workspace delta/review metadata routing; review-state persistence; campaign report generation; and send-job/update orchestration. - Closing newer duplicate tracker govoplan-campaign#58 as superseded by this issue. ### Verification - `xenon --max-absolute C on src/govoplan_campaign still reports the remaining blocks listed above.` ### Next / Blocked - Tackle one cluster at a time, starting with semantic validation or mock sending, with focused fixtures. Suggested status label: `status/in-progress`
zemion commented 2026-07-14 08:46:57 +02:00
Author
Owner
Copy Link

Codex State: progress

Summary

  • Implemented another campaign complexity slice: semantic campaign validation now delegates global, ZIP, delivery, entries, and file checks; mock campaign send now delegates per-message send/append handling and counters.
  • Current Xenon state: validate_campaign_config, _zip_configuration_issues, and run_mock_campaign_send no longer appear in campaign threshold violations.

Changed Files

  • src/govoplan_campaign/backend/campaign/validation.py
  • src/govoplan_campaign/backend/dev/mock_campaign.py
  • tests/test_partial_validation.py

Verification

  • python -m py_compile src/govoplan_campaign/backend/campaign/validation.py src/govoplan_campaign/backend/dev/mock_campaign.py tests/test_partial_validation.py
  • python -m unittest discover tests
  • xenon passes for validation.py and mock_campaign.py individually

Next / Blocked

  • Remaining campaign complexity is concentrated in router delta/review metadata, review-state persistence, report generation, and send-job orchestration.

Suggested status label: status/in-progress

## Codex State: progress ### Summary - Implemented another campaign complexity slice: semantic campaign validation now delegates global, ZIP, delivery, entries, and file checks; mock campaign send now delegates per-message send/append handling and counters. - Current Xenon state: validate_campaign_config, _zip_configuration_issues, and run_mock_campaign_send no longer appear in campaign threshold violations. ### Changed Files - `src/govoplan_campaign/backend/campaign/validation.py` - `src/govoplan_campaign/backend/dev/mock_campaign.py` - `tests/test_partial_validation.py` ### Verification - `python -m py_compile src/govoplan_campaign/backend/campaign/validation.py src/govoplan_campaign/backend/dev/mock_campaign.py tests/test_partial_validation.py` - `python -m unittest discover tests` - `xenon passes for validation.py and mock_campaign.py individually` ### Next / Blocked - Remaining campaign complexity is concentrated in router delta/review metadata, review-state persistence, report generation, and send-job orchestration. Suggested status label: `status/in-progress`
zemion commented 2026-07-14 09:21:48 +02:00
Author
Owner
Copy Link

Codex State: done

Summary

  • Refactored the remaining campaign complexity hotspots from the audit: validation helpers, mock campaign send flow, report generation, review state handling, workspace delta/review metadata, delivery status finalization, and send_campaign_job orchestration.
  • Full campaign Xenon now passes with --max-absolute C --max-modules B --max-average A.

Changed Files

  • src/govoplan_campaign/backend/campaign/validation.py
  • src/govoplan_campaign/backend/dev/mock_campaign.py
  • src/govoplan_campaign/backend/persistence/versions.py
  • src/govoplan_campaign/backend/reports/campaigns.py
  • src/govoplan_campaign/backend/router.py
  • src/govoplan_campaign/backend/sending/jobs.py
  • tests/test_partial_validation.py

Verification

  • /mnt/DATA/git/govoplan/.venv/bin/xenon --max-absolute C --max-modules B --max-average A src/govoplan_campaign: PASS
  • /mnt/DATA/git/govoplan/.venv/bin/python -m unittest discover tests: PASS (7 tests)
## Codex State: done ### Summary - Refactored the remaining campaign complexity hotspots from the audit: validation helpers, mock campaign send flow, report generation, review state handling, workspace delta/review metadata, delivery status finalization, and send_campaign_job orchestration. - Full campaign Xenon now passes with --max-absolute C --max-modules B --max-average A. ### Changed Files - `src/govoplan_campaign/backend/campaign/validation.py` - `src/govoplan_campaign/backend/dev/mock_campaign.py` - `src/govoplan_campaign/backend/persistence/versions.py` - `src/govoplan_campaign/backend/reports/campaigns.py` - `src/govoplan_campaign/backend/router.py` - `src/govoplan_campaign/backend/sending/jobs.py` - `tests/test_partial_validation.py` ### Verification - `/mnt/DATA/git/govoplan/.venv/bin/xenon --max-absolute C --max-modules B --max-average A src/govoplan_campaign: PASS` - `/mnt/DATA/git/govoplan/.venv/bin/python -m unittest discover tests: PASS (7 tests)`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
HTTP API contracts, routers, schemas, or API smoke behavior.
area/auth
Authentication, sessions, access bootstrap, or login behavior.
area/db
Database sessions, models, transactions, or persistence primitives.
area/deployment
Deployment, release, operations, or runtime packaging.
area/devex
Local developer workflow, scripts, tests, tooling, or release helpers.
area/docs
Durable documentation and project guidance.
area/governance
Governance policy, audit, privacy, retention, or compliance behavior.
area/marketing
Public website, product messaging, publication copy, or legal page content.
area/migrations
Alembic migrations, schema bootstrap, or persistence evolution.
area/module-system
Module discovery, manifests, capabilities, routing, or optional integrations.
area/rbac
Permissions, roles, delegation, or authorization policy.
area/release
Versioning, release locks, tags, packaging, or dependency pins.
area/security
Security posture, static analysis, supply-chain hardening, or vulnerability remediation.
area/tenancy
Tenant boundaries, provisioning, or tenant-scoped data behavior.
area/webui
Shared WebUI shell, frontend components, routing, or frontend tests.
audit/complexity
Complexity finding from Radon, Xenon, or equivalent maintainability scans.
audit/duplication
Duplicated-code finding from jscpd or equivalent similarity scans.
audit/false-positive
Audit finding reviewed as a narrow false positive or acceptable risk.
audit/needs-design
Audit finding that needs an architectural or product decision before implementation.
audit/quick-fix
Audit finding that appears narrow and directly fixable.
audit/structural
Audit finding that needs design, refactoring, or behavior review.
codex/needs-human
Needs an explicit human decision before Codex should implement.
codex/ready
Suitable for Codex to pick up with the existing issue context.
module/access
GovOPlaN access, identity, authentication, RBAC, and administration behavior.
module/addresses
GovOPlaN Addresses module behavior or integration.
module/admin
GovOPlaN Admin module behavior or integration.
module/appointments
GovOPlaN Appointments module behavior or integration.
module/approvals
GovOPlaN Approvals module behavior or integration.
module/assets
GovOPlaN Assets module behavior or integration.
module/audit
GovOPlaN Audit module behavior or integration.
module/booking
GovOPlaN Booking module behavior or integration.
module/calendar
GovOPlaN Calendar module behavior or integration.
module/campaign
GovOPlaN campaign module behavior or integration.
module/cases
GovOPlaN Cases module behavior or integration.
module/certificates
GovOPlaN Certificates module behavior or integration.
module/committee
GovOPlaN Committee module behavior or integration.
module/connectors
GovOPlaN Connectors module behavior or integration.
module/consultation
GovOPlaN Consultation module behavior or integration.
module/contracts
GovOPlaN Contracts module behavior or integration.
module/core
GovOPlaN core runner, shared primitives, shell, or extension points.
module/dist-lists
GovOPlaN Distribution Lists module behavior or integration.
module/dms
GovOPlaN Dms module behavior or integration.
module/docs
GovOPlaN documentation layer behavior or integration.
module/erp
GovOPlaN Erp module behavior or integration.
module/evaluation
GovOPlaN Evaluation module behavior or integration.
module/facilities
GovOPlaN Facilities module behavior or integration.
module/files
GovOPlaN files module behavior or integration.
module/fit-connect
GovOPlaN Fit Connect module behavior or integration.
module/forms
GovOPlaN Forms module behavior or integration.
module/forms-runtime
GovOPlaN Forms Runtime module behavior or integration.
module/grants
GovOPlaN Grants module behavior or integration.
module/helpdesk
GovOPlaN Helpdesk module behavior or integration.
module/identity
GovOPlaN Identity module behavior or integration.
module/identity-trust
GovOPlaN Identity Trust module behavior or integration.
module/idm
GovOPlaN Idm module behavior or integration.
module/inspections
GovOPlaN Inspections module behavior or integration.
module/issue-reporting
GovOPlaN Issue Reporting module behavior or integration.
module/learning
GovOPlaN Learning module behavior or integration.
module/ledger
GovOPlaN Ledger module behavior or integration.
module/mail
GovOPlaN mail module behavior or integration.
module/notifications
GovOPlaN Notifications module behavior or integration.
module/ops
GovOPlaN Ops module behavior or integration.
module/organizations
GovOPlaN Organizations module behavior or integration.
module/payments
GovOPlaN Payments module behavior or integration.
module/permits
GovOPlaN Permits module behavior or integration.
module/policy
GovOPlaN Policy module behavior or integration.
module/poll
GovOPlaN Poll module behavior or integration.
module/portal
GovOPlaN Portal module behavior or integration.
module/postbox
GovOPlaN Postbox module behavior or integration.
module/procurement
GovOPlaN Procurement module behavior or integration.
module/records
GovOPlaN Records module behavior or integration.
module/reporting
GovOPlaN Reporting module behavior or integration.
module/resources
GovOPlaN Resources module behavior or integration.
module/risk-compliance
GovOPlaN Risk Compliance module behavior or integration.
module/scheduling
GovOPlaN Scheduling module behavior or integration.
module/search
GovOPlaN Search module behavior or integration.
module/tasks
GovOPlaN Tasks module behavior or integration.
module/templates
GovOPlaN Templates module behavior or integration.
module/tenancy
GovOPlaN Tenancy module behavior or integration.
module/transparency
GovOPlaN Transparency module behavior or integration.
module/web
GovOPlaN public website, product page, or publication content.
module/workflow
GovOPlaN Workflow module behavior or integration.
module/xoev
GovOPlaN Xoev module behavior or integration.
module/xrechnung
GovOPlaN Xrechnung module behavior or integration.
module/xta-osci
GovOPlaN Xta Osci module behavior or integration.
priority
p0
Immediate stop-the-line priority.
priority
p1
High priority for the next focused work window.
priority
p2
Normal planned priority.
priority
p3
Low priority or opportunistic cleanup.
source/backlog-import
Imported from markdown backlog, roadmap, plan, or TODO files.
source/module-roadmap
Created from GovOPlaN module and integration roadmap planning.
source/security-audit
Created from a structured security or code-quality audit report.
source/todo-scan
Imported from inline TODO/FIXME/HACK markers by the Gitea TODO importer.
status
blocked
Cannot progress without a decision, dependency, credential, or external change.
status
in-progress
Currently being worked.
status
needs-info
Needs clarifying input before implementation can proceed safely.
status
ready
Ready for implementation.
status
triage
Needs review, ownership, priority, or acceptance criteria.
type
bug
A reproducible defect, regression, or incorrect behavior.
type
debt
Cleanup, refactoring, risk reduction, or deferred engineering work.
type
docs
Documentation, process, or developer workflow work.
type
feature
New user-visible behavior or platform capability.
type
task
Implementation, maintenance, migration, or operational work.
type
user-story
End-to-end user journey or real-world process story used to steer product slices.
No Label
audit/complexity
audit/structural
codex/ready
module/campaign
priority
p3
source/security-audit
status
ready
type
debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zemion
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: add-ideas/govoplan-campaign#54
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?