add-ideas/govoplan-core
1
0
Fork 0
Code Issues 45 Pull Requests Actions Packages Projects Releases Wiki Activity

Finish MessageDisplayPanel consolidation for mail and campaign previews #229

New Issue
Closed
opened 2026-07-09 18:42:12 +02:00 by zemion · 1 comment
zemion commented 2026-07-09 18:42:12 +02:00
Owner
Copy Link

Context

MessageDisplayPanel is already the right shared primitive for rendered mail/message content, but campaign still needs wrapper behavior and the core panel still has a few hard-rendered internals that should move onto shared controls.

Current call sites found by scan

  • govoplan-core/webui/src/components/MessageDisplayPanel.tsx
    • Shared content panel with title, fields, bodyText, bodyHtml, bodyPreview, preferredBodyMode, deriveTextFromHtml, headers, attachments, and emptyText.
    • Still hand-renders the HTML/text body switch instead of using the shared SegmentedControl.
  • govoplan-mail/webui/src/features/mail/MailboxPage.tsx
    • Uses MessageDisplayPanel inline for mailbox reading.
    • Passes sender/recipient/date fields, body text/html/preview, headers, attachments, and empty-state text.
  • govoplan-campaign/webui/src/features/campaigns/components/MessagePreviewOverlay.tsx
    • Wraps MessageDisplayPanel with modal shell, recipient note, message navigation, keyboard navigation, raw MIME details, and close button.
  • govoplan-campaign/webui/src/features/campaigns/TemplateDataPage.tsx
    • Uses campaign overlay for template preview with recipient pagination and resolved attachment preview.
  • govoplan-campaign/webui/src/features/campaigns/ReviewSendPage.tsx
    • Uses campaign overlay for mock mailbox preview and built-message preview.

Proposed component direction

Keep MessageDisplayPanel as the content primitive and add a reusable higher-level wrapper only if the campaign overlay behavior is useful outside campaign.

Potential API additions:

  • Replace internal body-mode buttons in MessageDisplayPanel with SegmentedControl.
  • Add optional props to MessageDisplayPanel if needed:
    • bodySwitchSize / bodySwitchWidth or fixed defaults matching the shared segmented control.
    • attachmentsTitle, headersTitle, bodyTitle if modules need module-specific labels.
    • renderAttachmentActions for future open/download/send actions.
  • Consider a new MessagePreviewDialog wrapper:
    • Props: open, title, onClose, recipientLabel, recipientNote, navigation, raw, rawLabel, closeLabel, children or message props forwarded to MessageDisplayPanel.
    • Navigation props: index, total, onFirst, onPrevious, onNext, onLast, enableKeyboardNavigation.
    • Should not force campaign semantics; campaign can keep a thin feature-specific adapter.

Acceptance criteria

  • MessageDisplayPanel uses SegmentedControl for the HTML/text switch.
  • Campaign overlay is either made clearly feature-specific and thin, or replaced by a generic core MessagePreviewDialog plus campaign adapter.
  • Mailbox preview and campaign template/review previews stay visually consistent.
  • Attachment grouping, ZIP protection hints, header display, and empty states are preserved.
  • Build and module permutation tests pass.
## Context `MessageDisplayPanel` is already the right shared primitive for rendered mail/message content, but campaign still needs wrapper behavior and the core panel still has a few hard-rendered internals that should move onto shared controls. ## Current call sites found by scan - `govoplan-core/webui/src/components/MessageDisplayPanel.tsx` - Shared content panel with `title`, `fields`, `bodyText`, `bodyHtml`, `bodyPreview`, `preferredBodyMode`, `deriveTextFromHtml`, `headers`, `attachments`, and `emptyText`. - Still hand-renders the HTML/text body switch instead of using the shared `SegmentedControl`. - `govoplan-mail/webui/src/features/mail/MailboxPage.tsx` - Uses `MessageDisplayPanel` inline for mailbox reading. - Passes sender/recipient/date fields, body text/html/preview, headers, attachments, and empty-state text. - `govoplan-campaign/webui/src/features/campaigns/components/MessagePreviewOverlay.tsx` - Wraps `MessageDisplayPanel` with modal shell, recipient note, message navigation, keyboard navigation, raw MIME details, and close button. - `govoplan-campaign/webui/src/features/campaigns/TemplateDataPage.tsx` - Uses campaign overlay for template preview with recipient pagination and resolved attachment preview. - `govoplan-campaign/webui/src/features/campaigns/ReviewSendPage.tsx` - Uses campaign overlay for mock mailbox preview and built-message preview. ## Proposed component direction Keep `MessageDisplayPanel` as the content primitive and add a reusable higher-level wrapper only if the campaign overlay behavior is useful outside campaign. Potential API additions: - Replace internal body-mode buttons in `MessageDisplayPanel` with `SegmentedControl`. - Add optional props to `MessageDisplayPanel` if needed: - `bodySwitchSize` / `bodySwitchWidth` or fixed defaults matching the shared segmented control. - `attachmentsTitle`, `headersTitle`, `bodyTitle` if modules need module-specific labels. - `renderAttachmentActions` for future open/download/send actions. - Consider a new `MessagePreviewDialog` wrapper: - Props: `open`, `title`, `onClose`, `recipientLabel`, `recipientNote`, `navigation`, `raw`, `rawLabel`, `closeLabel`, `children` or `message` props forwarded to `MessageDisplayPanel`. - Navigation props: `index`, `total`, `onFirst`, `onPrevious`, `onNext`, `onLast`, `enableKeyboardNavigation`. - Should not force campaign semantics; campaign can keep a thin feature-specific adapter. ## Acceptance criteria - `MessageDisplayPanel` uses `SegmentedControl` for the HTML/text switch. - Campaign overlay is either made clearly feature-specific and thin, or replaced by a generic core `MessagePreviewDialog` plus campaign adapter. - Mailbox preview and campaign template/review previews stay visually consistent. - Attachment grouping, ZIP protection hints, header display, and empty states are preserved. - Build and module permutation tests pass. <!-- codex-fingerprint: shared-message-display-panel-followup-2026-07-09 -->
zemion commented 2026-07-10 10:33:23 +02:00
Author
Owner
Copy Link

Codex State: done

Summary

  • MessageDisplayPanel now uses the shared SegmentedControl instead of hand-rendered body-mode buttons.
  • Campaign MessagePreviewOverlay remains as a campaign-specific wrapper for pagination, attachments, and review/send context, while delegating message rendering to core MessageDisplayPanel.

Changed Files

  • webui/src/components/MessageDisplayPanel.tsx
  • /mnt/DATA/git/govoplan-campaign/webui/src/features/campaigns/components/MessagePreviewOverlay.tsx

Verification

  • npm run build passed in govoplan-core/webui
  • bash scripts/check-focused.sh passed
## Codex State: done ### Summary - MessageDisplayPanel now uses the shared SegmentedControl instead of hand-rendered body-mode buttons. - Campaign MessagePreviewOverlay remains as a campaign-specific wrapper for pagination, attachments, and review/send context, while delegating message rendering to core MessageDisplayPanel. ### Changed Files - `webui/src/components/MessageDisplayPanel.tsx` - `/mnt/DATA/git/govoplan-campaign/webui/src/features/campaigns/components/MessagePreviewOverlay.tsx` ### Verification - `npm run build passed in govoplan-core/webui` - `bash scripts/check-focused.sh passed`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
HTTP API contracts, routers, schemas, or API smoke behavior.
area/auth
Authentication, sessions, access bootstrap, or login behavior.
area/db
Database sessions, models, transactions, or persistence primitives.
area/deployment
Deployment, release, operations, or runtime packaging.
area/devex
Local developer workflow, scripts, tests, tooling, or release helpers.
area/docs
Durable documentation and project guidance.
area/governance
Governance policy, audit, privacy, retention, or compliance behavior.
area/marketing
Public website, product messaging, publication copy, or legal page content.
area/migrations
Alembic migrations, schema bootstrap, or persistence evolution.
area/module-system
Module discovery, manifests, capabilities, routing, or optional integrations.
area/rbac
Permissions, roles, delegation, or authorization policy.
area/release
Versioning, release locks, tags, packaging, or dependency pins.
area/security
Security posture, static analysis, supply-chain hardening, or vulnerability remediation.
area/tenancy
Tenant boundaries, provisioning, or tenant-scoped data behavior.
area/webui
Shared WebUI shell, frontend components, routing, or frontend tests.
audit/complexity
Complexity finding from Radon, Xenon, or equivalent maintainability scans.
audit/duplication
Duplicated-code finding from jscpd or equivalent similarity scans.
audit/false-positive
Audit finding reviewed as a narrow false positive or acceptable risk.
audit/needs-design
Audit finding that needs an architectural or product decision before implementation.
audit/quick-fix
Audit finding that appears narrow and directly fixable.
audit/structural
Audit finding that needs design, refactoring, or behavior review.
codex/needs-human
Needs an explicit human decision before Codex should implement.
codex/ready
Suitable for Codex to pick up with the existing issue context.
module/access
GovOPlaN access, identity, authentication, RBAC, and administration behavior.
module/addresses
GovOPlaN Addresses module behavior or integration.
module/admin
GovOPlaN Admin module behavior or integration.
module/appointments
GovOPlaN Appointments module behavior or integration.
module/approvals
GovOPlaN Approvals module behavior or integration.
module/assets
GovOPlaN Assets module behavior or integration.
module/audit
GovOPlaN Audit module behavior or integration.
module/booking
GovOPlaN Booking module behavior or integration.
module/calendar
GovOPlaN Calendar module behavior or integration.
module/campaign
GovOPlaN campaign module behavior or integration.
module/cases
GovOPlaN Cases module behavior or integration.
module/certificates
GovOPlaN Certificates module behavior or integration.
module/committee
GovOPlaN Committee module behavior or integration.
module/connectors
GovOPlaN Connectors module behavior or integration.
module/consultation
GovOPlaN Consultation module behavior or integration.
module/contracts
GovOPlaN Contracts module behavior or integration.
module/core
GovOPlaN core runner, shared primitives, shell, or extension points.
module/dist-lists
GovOPlaN Distribution Lists module behavior or integration.
module/dms
GovOPlaN Dms module behavior or integration.
module/docs
GovOPlaN documentation layer behavior or integration.
module/erp
GovOPlaN Erp module behavior or integration.
module/evaluation
GovOPlaN Evaluation module behavior or integration.
module/facilities
GovOPlaN Facilities module behavior or integration.
module/files
GovOPlaN files module behavior or integration.
module/fit-connect
GovOPlaN Fit Connect module behavior or integration.
module/forms
GovOPlaN Forms module behavior or integration.
module/forms-runtime
GovOPlaN Forms Runtime module behavior or integration.
module/grants
GovOPlaN Grants module behavior or integration.
module/helpdesk
GovOPlaN Helpdesk module behavior or integration.
module/identity
GovOPlaN Identity module behavior or integration.
module/identity-trust
GovOPlaN Identity Trust module behavior or integration.
module/idm
GovOPlaN Idm module behavior or integration.
module/inspections
GovOPlaN Inspections module behavior or integration.
module/issue-reporting
GovOPlaN Issue Reporting module behavior or integration.
module/learning
GovOPlaN Learning module behavior or integration.
module/ledger
GovOPlaN Ledger module behavior or integration.
module/mail
GovOPlaN mail module behavior or integration.
module/notifications
GovOPlaN Notifications module behavior or integration.
module/ops
GovOPlaN Ops module behavior or integration.
module/organizations
GovOPlaN Organizations module behavior or integration.
module/payments
GovOPlaN Payments module behavior or integration.
module/permits
GovOPlaN Permits module behavior or integration.
module/policy
GovOPlaN Policy module behavior or integration.
module/poll
GovOPlaN Poll module behavior or integration.
module/portal
GovOPlaN Portal module behavior or integration.
module/postbox
GovOPlaN Postbox module behavior or integration.
module/procurement
GovOPlaN Procurement module behavior or integration.
module/records
GovOPlaN Records module behavior or integration.
module/reporting
GovOPlaN Reporting module behavior or integration.
module/resources
GovOPlaN Resources module behavior or integration.
module/risk-compliance
GovOPlaN Risk Compliance module behavior or integration.
module/scheduling
GovOPlaN Scheduling module behavior or integration.
module/search
GovOPlaN Search module behavior or integration.
module/tasks
GovOPlaN Tasks module behavior or integration.
module/templates
GovOPlaN Templates module behavior or integration.
module/tenancy
GovOPlaN Tenancy module behavior or integration.
module/transparency
GovOPlaN Transparency module behavior or integration.
module/web
GovOPlaN public website, product page, or publication content.
module/workflow
GovOPlaN Workflow module behavior or integration.
module/xoev
GovOPlaN Xoev module behavior or integration.
module/xrechnung
GovOPlaN Xrechnung module behavior or integration.
module/xta-osci
GovOPlaN Xta Osci module behavior or integration.
priority
p0
Immediate stop-the-line priority.
priority
p1
High priority for the next focused work window.
priority
p2
Normal planned priority.
priority
p3
Low priority or opportunistic cleanup.
source/backlog-import
Imported from markdown backlog, roadmap, plan, or TODO files.
source/module-roadmap
Created from GovOPlaN module and integration roadmap planning.
source/security-audit
Created from a structured security or code-quality audit report.
source/todo-scan
Imported from inline TODO/FIXME/HACK markers by the Gitea TODO importer.
status
blocked
Cannot progress without a decision, dependency, credential, or external change.
status
in-progress
Currently being worked.
status
needs-info
Needs clarifying input before implementation can proceed safely.
status
ready
Ready for implementation.
status
triage
Needs review, ownership, priority, or acceptance criteria.
type
bug
A reproducible defect, regression, or incorrect behavior.
type
debt
Cleanup, refactoring, risk reduction, or deferred engineering work.
type
docs
Documentation, process, or developer workflow work.
type
feature
New user-visible behavior or platform capability.
type
task
Implementation, maintenance, migration, or operational work.
type
user-story
End-to-end user journey or real-world process story used to steer product slices.
No Label
area/webui
codex/ready
module/campaign
module/core
module/mail
priority
p2
status
ready
type
debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zemion
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: add-ideas/govoplan-core#229
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?