add-ideas/govoplan-core
1
0
Fork 0
Code Issues 45 Pull Requests Actions Packages Projects Releases Wiki Activity

[Debt] Refactor high-complexity core installer/configuration/runtime functions #245

New Issue
Closed
opened 2026-07-11 12:51:16 +02:00 by zemion · 4 comments
zemion commented 2026-07-11 12:51:16 +02:00
Owner
Copy Link

Xenon/Radon identify several D/E/F-ranked core functions. These are not immediate security defects, but they increase risk in migration, installer, and configuration code.

Classification: structural maintainability work.

Report evidence:

  • govoplan-core/src/govoplan_core/commands/module_installer.py:42 main rank F.
  • govoplan-core/src/govoplan_core/core/install_config.py:110 validate_runtime_configuration rank F.
  • govoplan-core/src/govoplan_core/core/module_installer.py:418 run_module_install_plan, :1388, :1476 ranks E.
  • govoplan-core/src/govoplan_core/core/module_package_catalog.py:52 validate_module_package_catalog rank F.
  • Full Xenon output attached by user; future runs will capture this in xenon.txt.

Suggested next steps:

  • Split installer orchestration into smaller command planning, execution, rollback, and catalog-validation services.
  • Add focused regression tests before refactoring each cluster.
  • Use Xenon as report-only until a baseline is reduced.

Baseline report directory: audit-reports/govoplan-full-20260711-1238

<!-- codex-audit-full-2026-07-11:core-complexity-baseline --> Xenon/Radon identify several D/E/F-ranked core functions. These are not immediate security defects, but they increase risk in migration, installer, and configuration code. Classification: **structural maintainability work**. Report evidence: - `govoplan-core/src/govoplan_core/commands/module_installer.py:42 main` rank F. - `govoplan-core/src/govoplan_core/core/install_config.py:110 validate_runtime_configuration` rank F. - `govoplan-core/src/govoplan_core/core/module_installer.py:418 run_module_install_plan`, `:1388`, `:1476` ranks E. - `govoplan-core/src/govoplan_core/core/module_package_catalog.py:52 validate_module_package_catalog` rank F. - Full Xenon output attached by user; future runs will capture this in `xenon.txt`. Suggested next steps: - Split installer orchestration into smaller command planning, execution, rollback, and catalog-validation services. - Add focused regression tests before refactoring each cluster. - Use Xenon as report-only until a baseline is reduced. Baseline report directory: `audit-reports/govoplan-full-20260711-1238`
zemion added the
type
debt
status
ready
priority
p3
module/core
codex/ready
 labels 2026-07-11 12:51:16 +02:00
zemion added the
audit/complexity
audit/structural
source/security-audit
 labels 2026-07-11 16:06:05 +02:00
zemion commented 2026-07-12 02:07:13 +02:00
Author
Owner
Copy Link

Sequencing confirmed: leave this issue open, but do not pull it into the current small cleanup wave.

This should be tackled when installer/runtime work is active, with regression tests around catalog validation, install-plan execution, rollback, runtime validation, and daemon supervision before simplifying the high-complexity functions.

Sequencing confirmed: leave this issue open, but do not pull it into the current small cleanup wave. This should be tackled when installer/runtime work is active, with regression tests around catalog validation, install-plan execution, rollback, runtime validation, and daemon supervision before simplifying the high-complexity functions.
zemion commented 2026-07-14 01:52:15 +02:00
Author
Owner
Copy Link

Codex State: progress

Summary

  • Current Xenon state after the latest cleanup: validate_runtime_configuration and validate_module_package_catalog are no longer above threshold.
  • Remaining core hotspots are module_installer CLI main; module_installer install/preflight/catalog/migration/uninstall/data-safety helpers; configuration package catalog validation; configuration safety planning; module management normalization; registry validation; and DB migration task/reconciliation helpers.
  • Closing newer duplicate tracker govoplan-core#257 as superseded by this issue.

Verification

  • xenon --max-absolute C on src/govoplan_core still reports the remaining blocks listed above.

Next / Blocked

  • Tackle one cluster at a time, starting with module_installer CLI/main or migration helpers, with focused regression tests.

Suggested status label: status/in-progress

## Codex State: progress ### Summary - Current Xenon state after the latest cleanup: validate_runtime_configuration and validate_module_package_catalog are no longer above threshold. - Remaining core hotspots are module_installer CLI main; module_installer install/preflight/catalog/migration/uninstall/data-safety helpers; configuration package catalog validation; configuration safety planning; module management normalization; registry validation; and DB migration task/reconciliation helpers. - Closing newer duplicate tracker govoplan-core#257 as superseded by this issue. ### Verification - `xenon --max-absolute C on src/govoplan_core still reports the remaining blocks listed above.` ### Next / Blocked - Tackle one cluster at a time, starting with module_installer CLI/main or migration helpers, with focused regression tests. Suggested status label: `status/in-progress`
zemion commented 2026-07-14 08:46:52 +02:00
Author
Owner
Copy Link

Codex State: progress

Summary

  • Implemented another core complexity slice: configuration package catalog validation now delegates to a validation state object plus policy/result/warning helpers, and configuration change safety planning now delegates blocker collection and plan assembly.
  • Current Xenon state: validate_configuration_package_catalog and plan_configuration_change no longer appear in the core threshold violations.

Changed Files

  • src/govoplan_core/core/configuration_packages.py
  • src/govoplan_core/core/configuration_safety.py

Verification

  • python -m py_compile src/govoplan_core/core/configuration_safety.py src/govoplan_core/core/configuration_packages.py
  • python -m unittest tests.test_policy_contracts tests.test_module_system.ModuleSystemTests.test_configuration_package_catalog_validates_signed_entries
  • xenon passes for configuration_safety.py and configuration_packages.py individually

Next / Blocked

  • Remaining core complexity is concentrated in module_installer CLI/runtime helpers, module_management normalization, registry validation, and DB migration reconciliation.

Suggested status label: status/in-progress

## Codex State: progress ### Summary - Implemented another core complexity slice: configuration package catalog validation now delegates to a validation state object plus policy/result/warning helpers, and configuration change safety planning now delegates blocker collection and plan assembly. - Current Xenon state: validate_configuration_package_catalog and plan_configuration_change no longer appear in the core threshold violations. ### Changed Files - `src/govoplan_core/core/configuration_packages.py` - `src/govoplan_core/core/configuration_safety.py` ### Verification - `python -m py_compile src/govoplan_core/core/configuration_safety.py src/govoplan_core/core/configuration_packages.py` - `python -m unittest tests.test_policy_contracts tests.test_module_system.ModuleSystemTests.test_configuration_package_catalog_validates_signed_entries` - `xenon passes for configuration_safety.py and configuration_packages.py individually` ### Next / Blocked - Remaining core complexity is concentrated in module_installer CLI/runtime helpers, module_management normalization, registry validation, and DB migration reconciliation. Suggested status label: `status/in-progress`
zemion commented 2026-07-14 09:21:43 +02:00
Author
Owner
Copy Link

Codex State: done

Summary

  • Refactored the remaining core complexity hotspots from the audit: module installer CLI dispatch, installer preflight/run/rollback/command generation, uninstall/data-safety/catalog companion handling, migration planning, and server app startup wiring.
  • Full core Xenon now passes with --max-absolute C --max-modules B --max-average A.

Changed Files

  • src/govoplan_core/commands/module_installer.py
  • src/govoplan_core/core/module_installer.py
  • src/govoplan_core/server/app.py

Verification

  • /mnt/DATA/git/govoplan/.venv/bin/xenon --max-absolute C --max-modules B --max-average A src/govoplan_core: PASS
  • /mnt/DATA/git/govoplan/.venv/bin/python -m unittest tests.test_module_system: PASS (105 tests)
  • /mnt/DATA/git/govoplan/.venv/bin/python -m unittest tests.test_devserver: PASS
  • Focused create_app saved-state tests: PASS (3 tests)
  • Manual devserver smoke against local PostgreSQL: BLOCKED by existing Alembic revision mismatch e1f2a4b5c6d, unrelated to this refactor
## Codex State: done ### Summary - Refactored the remaining core complexity hotspots from the audit: module installer CLI dispatch, installer preflight/run/rollback/command generation, uninstall/data-safety/catalog companion handling, migration planning, and server app startup wiring. - Full core Xenon now passes with --max-absolute C --max-modules B --max-average A. ### Changed Files - `src/govoplan_core/commands/module_installer.py` - `src/govoplan_core/core/module_installer.py` - `src/govoplan_core/server/app.py` ### Verification - `/mnt/DATA/git/govoplan/.venv/bin/xenon --max-absolute C --max-modules B --max-average A src/govoplan_core: PASS` - `/mnt/DATA/git/govoplan/.venv/bin/python -m unittest tests.test_module_system: PASS (105 tests)` - `/mnt/DATA/git/govoplan/.venv/bin/python -m unittest tests.test_devserver: PASS` - `Focused create_app saved-state tests: PASS (3 tests)` - `Manual devserver smoke against local PostgreSQL: BLOCKED by existing Alembic revision mismatch e1f2a4b5c6d, unrelated to this refactor`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
HTTP API contracts, routers, schemas, or API smoke behavior.
area/auth
Authentication, sessions, access bootstrap, or login behavior.
area/db
Database sessions, models, transactions, or persistence primitives.
area/deployment
Deployment, release, operations, or runtime packaging.
area/devex
Local developer workflow, scripts, tests, tooling, or release helpers.
area/docs
Durable documentation and project guidance.
area/governance
Governance policy, audit, privacy, retention, or compliance behavior.
area/marketing
Public website, product messaging, publication copy, or legal page content.
area/migrations
Alembic migrations, schema bootstrap, or persistence evolution.
area/module-system
Module discovery, manifests, capabilities, routing, or optional integrations.
area/rbac
Permissions, roles, delegation, or authorization policy.
area/release
Versioning, release locks, tags, packaging, or dependency pins.
area/security
Security posture, static analysis, supply-chain hardening, or vulnerability remediation.
area/tenancy
Tenant boundaries, provisioning, or tenant-scoped data behavior.
area/webui
Shared WebUI shell, frontend components, routing, or frontend tests.
audit/complexity
Complexity finding from Radon, Xenon, or equivalent maintainability scans.
audit/duplication
Duplicated-code finding from jscpd or equivalent similarity scans.
audit/false-positive
Audit finding reviewed as a narrow false positive or acceptable risk.
audit/needs-design
Audit finding that needs an architectural or product decision before implementation.
audit/quick-fix
Audit finding that appears narrow and directly fixable.
audit/structural
Audit finding that needs design, refactoring, or behavior review.
codex/needs-human
Needs an explicit human decision before Codex should implement.
codex/ready
Suitable for Codex to pick up with the existing issue context.
module/access
GovOPlaN access, identity, authentication, RBAC, and administration behavior.
module/addresses
GovOPlaN Addresses module behavior or integration.
module/admin
GovOPlaN Admin module behavior or integration.
module/appointments
GovOPlaN Appointments module behavior or integration.
module/approvals
GovOPlaN Approvals module behavior or integration.
module/assets
GovOPlaN Assets module behavior or integration.
module/audit
GovOPlaN Audit module behavior or integration.
module/booking
GovOPlaN Booking module behavior or integration.
module/calendar
GovOPlaN Calendar module behavior or integration.
module/campaign
GovOPlaN campaign module behavior or integration.
module/cases
GovOPlaN Cases module behavior or integration.
module/certificates
GovOPlaN Certificates module behavior or integration.
module/committee
GovOPlaN Committee module behavior or integration.
module/connectors
GovOPlaN Connectors module behavior or integration.
module/consultation
GovOPlaN Consultation module behavior or integration.
module/contracts
GovOPlaN Contracts module behavior or integration.
module/core
GovOPlaN core runner, shared primitives, shell, or extension points.
module/dist-lists
GovOPlaN Distribution Lists module behavior or integration.
module/dms
GovOPlaN Dms module behavior or integration.
module/docs
GovOPlaN documentation layer behavior or integration.
module/erp
GovOPlaN Erp module behavior or integration.
module/evaluation
GovOPlaN Evaluation module behavior or integration.
module/facilities
GovOPlaN Facilities module behavior or integration.
module/files
GovOPlaN files module behavior or integration.
module/fit-connect
GovOPlaN Fit Connect module behavior or integration.
module/forms
GovOPlaN Forms module behavior or integration.
module/forms-runtime
GovOPlaN Forms Runtime module behavior or integration.
module/grants
GovOPlaN Grants module behavior or integration.
module/helpdesk
GovOPlaN Helpdesk module behavior or integration.
module/identity
GovOPlaN Identity module behavior or integration.
module/identity-trust
GovOPlaN Identity Trust module behavior or integration.
module/idm
GovOPlaN Idm module behavior or integration.
module/inspections
GovOPlaN Inspections module behavior or integration.
module/issue-reporting
GovOPlaN Issue Reporting module behavior or integration.
module/learning
GovOPlaN Learning module behavior or integration.
module/ledger
GovOPlaN Ledger module behavior or integration.
module/mail
GovOPlaN mail module behavior or integration.
module/notifications
GovOPlaN Notifications module behavior or integration.
module/ops
GovOPlaN Ops module behavior or integration.
module/organizations
GovOPlaN Organizations module behavior or integration.
module/payments
GovOPlaN Payments module behavior or integration.
module/permits
GovOPlaN Permits module behavior or integration.
module/policy
GovOPlaN Policy module behavior or integration.
module/poll
GovOPlaN Poll module behavior or integration.
module/portal
GovOPlaN Portal module behavior or integration.
module/postbox
GovOPlaN Postbox module behavior or integration.
module/procurement
GovOPlaN Procurement module behavior or integration.
module/records
GovOPlaN Records module behavior or integration.
module/reporting
GovOPlaN Reporting module behavior or integration.
module/resources
GovOPlaN Resources module behavior or integration.
module/risk-compliance
GovOPlaN Risk Compliance module behavior or integration.
module/scheduling
GovOPlaN Scheduling module behavior or integration.
module/search
GovOPlaN Search module behavior or integration.
module/tasks
GovOPlaN Tasks module behavior or integration.
module/templates
GovOPlaN Templates module behavior or integration.
module/tenancy
GovOPlaN Tenancy module behavior or integration.
module/transparency
GovOPlaN Transparency module behavior or integration.
module/web
GovOPlaN public website, product page, or publication content.
module/workflow
GovOPlaN Workflow module behavior or integration.
module/xoev
GovOPlaN Xoev module behavior or integration.
module/xrechnung
GovOPlaN Xrechnung module behavior or integration.
module/xta-osci
GovOPlaN Xta Osci module behavior or integration.
priority
p0
Immediate stop-the-line priority.
priority
p1
High priority for the next focused work window.
priority
p2
Normal planned priority.
priority
p3
Low priority or opportunistic cleanup.
source/backlog-import
Imported from markdown backlog, roadmap, plan, or TODO files.
source/module-roadmap
Created from GovOPlaN module and integration roadmap planning.
source/security-audit
Created from a structured security or code-quality audit report.
source/todo-scan
Imported from inline TODO/FIXME/HACK markers by the Gitea TODO importer.
status
blocked
Cannot progress without a decision, dependency, credential, or external change.
status
in-progress
Currently being worked.
status
needs-info
Needs clarifying input before implementation can proceed safely.
status
ready
Ready for implementation.
status
triage
Needs review, ownership, priority, or acceptance criteria.
type
bug
A reproducible defect, regression, or incorrect behavior.
type
debt
Cleanup, refactoring, risk reduction, or deferred engineering work.
type
docs
Documentation, process, or developer workflow work.
type
feature
New user-visible behavior or platform capability.
type
task
Implementation, maintenance, migration, or operational work.
type
user-story
End-to-end user journey or real-world process story used to steer product slices.
No Label
audit/complexity
audit/structural
codex/ready
module/core
priority
p3
source/security-audit
status
ready
type
debt
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zemion
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: add-ideas/govoplan-core#245
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?