add-ideas/govoplan-mail
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

Mail: redesign profile UI around server and credential split #10

New Issue
Closed
opened 2026-07-11 03:46:50 +02:00 by zemion · 2 comments
zemion commented 2026-07-11 03:46:50 +02:00
Owner
Copy Link

Context

The mail backend now separates server configuration from credentials, but the profile creation/editing UI still behaves as if every edit button opens the same combined dialog.

Requested behavior

Change the mail profile creation and editing flow to reflect the server/credential split.

Acceptance criteria

  • Editing an IMAP server, SMTP server, and credentials opens the appropriate focused dialog.
  • The UI makes it clear that IMAP and SMTP can be different servers and server types.
  • Credentials are visibly attached to the server/profile they belong to.
  • Creation flow guides the user through server selection/creation and credential assignment without duplicating fields.
  • Existing profile policies remain compatible.
  • WebUI tests cover the new dialog routing and at least one create/edit path.

Folded Scope From #12: Mail Profile / Transport Complexity

The structural debt from govoplan-mail#12 is part of this redesign work and must not be lost while implementing the server/credential split.

Additional acceptance notes:

  • Extract mail profile policy merge and validation into smaller focused helpers with fixture-style tests.
  • Keep server configuration, credential inheritance, and policy enforcement visibly separate in the UI and backend service boundaries.
  • Split transport request preparation from execution/response handling where SMTP/IMAP behavior is touched.
  • Preserve existing policy compatibility while simplifying _merge_policy, update_mail_server_profile, _validate_policy_against_parent, list_imap_messages, and _send_smtp_payload over follow-up slices.

Source: folded from govoplan-mail#12 (source/security-audit, audit complexity baseline codex-audit-full-2026-07-11:mail-complexity-baseline).

## Context The mail backend now separates server configuration from credentials, but the profile creation/editing UI still behaves as if every edit button opens the same combined dialog. ## Requested behavior Change the mail profile creation and editing flow to reflect the server/credential split. ## Acceptance criteria - Editing an IMAP server, SMTP server, and credentials opens the appropriate focused dialog. - The UI makes it clear that IMAP and SMTP can be different servers and server types. - Credentials are visibly attached to the server/profile they belong to. - Creation flow guides the user through server selection/creation and credential assignment without duplicating fields. - Existing profile policies remain compatible. - WebUI tests cover the new dialog routing and at least one create/edit path. ## Folded Scope From #12: Mail Profile / Transport Complexity The structural debt from `govoplan-mail#12` is part of this redesign work and must not be lost while implementing the server/credential split. Additional acceptance notes: - Extract mail profile policy merge and validation into smaller focused helpers with fixture-style tests. - Keep server configuration, credential inheritance, and policy enforcement visibly separate in the UI and backend service boundaries. - Split transport request preparation from execution/response handling where SMTP/IMAP behavior is touched. - Preserve existing policy compatibility while simplifying `_merge_policy`, `update_mail_server_profile`, `_validate_policy_against_parent`, `list_imap_messages`, and `_send_smtp_payload` over follow-up slices. Source: folded from `govoplan-mail#12` (`source/security-audit`, audit complexity baseline `codex-audit-full-2026-07-11:mail-complexity-baseline`).
zemion added the
type
task
status
ready
priority
p2
area/webui
module/mail
codex/ready
 labels 2026-07-11 03:46:50 +02:00
zemion commented 2026-07-12 01:36:08 +02:00
Author
Owner
Copy Link

Codex State: progress

Summary

  • Split the mail profile tree so SMTP/IMAP server settings and SMTP/IMAP credentials are visible as separate child rows, with edit actions opening the corresponding MailServerSettingsPanel section.
  • Added a WebUI package lock so the module-local test script can install and run TypeScript consistently.

Changed Files

  • webui/src/features/mail/MailProfileManagement.tsx
  • webui/package-lock.json

Verification

  • /home/zemion/.nvm/versions/node/v22.22.3/bin/npm run test:mail-ui
  • /home/zemion/.nvm/versions/node/v22.22.3/bin/npm run build in govoplan-core/webui

Next / Blocked

  • Keep this open for full guided creation/edit UX and any backend schema split work that is still intended for this issue.

Suggested status label: status/in-progress

## Codex State: progress ### Summary - Split the mail profile tree so SMTP/IMAP server settings and SMTP/IMAP credentials are visible as separate child rows, with edit actions opening the corresponding MailServerSettingsPanel section. - Added a WebUI package lock so the module-local test script can install and run TypeScript consistently. ### Changed Files - `webui/src/features/mail/MailProfileManagement.tsx` - `webui/package-lock.json` ### Verification - `/home/zemion/.nvm/versions/node/v22.22.3/bin/npm run test:mail-ui` - `/home/zemion/.nvm/versions/node/v22.22.3/bin/npm run build in govoplan-core/webui` ### Next / Blocked - Keep this open for full guided creation/edit UX and any backend schema split work that is still intended for this issue. Suggested status label: `status/in-progress`
zemion commented 2026-07-12 16:32:49 +02:00
Author
Owner
Copy Link

Codex State: done

Summary

  • Mail profile UI now separates profile metadata, SMTP/IMAP server settings, and SMTP/IMAP credentials into focused edit targets.
  • The shared core MailServerSettingsPanel supports full, server-only, and credentials-only modes without duplicating fields.
  • Existing policy handling remains compatible; IMAP add/edit no longer treats credentials-only input as a configured IMAP server.

Changed Files

  • govoplan-core/webui/src/components/mail/MailServerSettingsPanel.tsx
  • govoplan-mail/webui/src/features/mail/MailProfileManagement.tsx
  • govoplan-mail/webui/src/features/mail/mailProfileEditorModel.ts

Verification

  • npm run test:mail-components (core WebUI)
  • npm run test:mail-ui (mail WebUI)
  • python -m unittest discover -s tests (govoplan-mail)
## Codex State: done ### Summary - Mail profile UI now separates profile metadata, SMTP/IMAP server settings, and SMTP/IMAP credentials into focused edit targets. - The shared core MailServerSettingsPanel supports full, server-only, and credentials-only modes without duplicating fields. - Existing policy handling remains compatible; IMAP add/edit no longer treats credentials-only input as a configured IMAP server. ### Changed Files - `govoplan-core/webui/src/components/mail/MailServerSettingsPanel.tsx` - `govoplan-mail/webui/src/features/mail/MailProfileManagement.tsx` - `govoplan-mail/webui/src/features/mail/mailProfileEditorModel.ts` ### Verification - `npm run test:mail-components (core WebUI)` - `npm run test:mail-ui (mail WebUI)` - `python -m unittest discover -s tests (govoplan-mail)`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
HTTP API contracts, routers, schemas, or API smoke behavior.
area/auth
Authentication, sessions, access bootstrap, or login behavior.
area/db
Database sessions, models, transactions, or persistence primitives.
area/deployment
Deployment, release, operations, or runtime packaging.
area/devex
Local developer workflow, scripts, tests, tooling, or release helpers.
area/docs
Durable documentation and project guidance.
area/governance
Governance policy, audit, privacy, retention, or compliance behavior.
area/marketing
Public website, product messaging, publication copy, or legal page content.
area/migrations
Alembic migrations, schema bootstrap, or persistence evolution.
area/module-system
Module discovery, manifests, capabilities, routing, or optional integrations.
area/rbac
Permissions, roles, delegation, or authorization policy.
area/release
Versioning, release locks, tags, packaging, or dependency pins.
area/security
Security posture, static analysis, supply-chain hardening, or vulnerability remediation.
area/tenancy
Tenant boundaries, provisioning, or tenant-scoped data behavior.
area/webui
Shared WebUI shell, frontend components, routing, or frontend tests.
audit/complexity
Complexity finding from Radon, Xenon, or equivalent maintainability scans.
audit/duplication
Duplicated-code finding from jscpd or equivalent similarity scans.
audit/false-positive
Audit finding reviewed as a narrow false positive or acceptable risk.
audit/needs-design
Audit finding that needs an architectural or product decision before implementation.
audit/quick-fix
Audit finding that appears narrow and directly fixable.
audit/structural
Audit finding that needs design, refactoring, or behavior review.
codex/needs-human
Needs an explicit human decision before Codex should implement.
codex/ready
Suitable for Codex to pick up with the existing issue context.
module/access
GovOPlaN access, identity, authentication, RBAC, and administration behavior.
module/addresses
GovOPlaN Addresses module behavior or integration.
module/admin
GovOPlaN Admin module behavior or integration.
module/appointments
GovOPlaN Appointments module behavior or integration.
module/approvals
GovOPlaN Approvals module behavior or integration.
module/assets
GovOPlaN Assets module behavior or integration.
module/audit
GovOPlaN Audit module behavior or integration.
module/booking
GovOPlaN Booking module behavior or integration.
module/calendar
GovOPlaN Calendar module behavior or integration.
module/campaign
GovOPlaN campaign module behavior or integration.
module/cases
GovOPlaN Cases module behavior or integration.
module/certificates
GovOPlaN Certificates module behavior or integration.
module/committee
GovOPlaN Committee module behavior or integration.
module/connectors
GovOPlaN Connectors module behavior or integration.
module/consultation
GovOPlaN Consultation module behavior or integration.
module/contracts
GovOPlaN Contracts module behavior or integration.
module/core
GovOPlaN core runner, shared primitives, shell, or extension points.
module/dist-lists
GovOPlaN Distribution Lists module behavior or integration.
module/dms
GovOPlaN Dms module behavior or integration.
module/docs
GovOPlaN documentation layer behavior or integration.
module/erp
GovOPlaN Erp module behavior or integration.
module/evaluation
GovOPlaN Evaluation module behavior or integration.
module/facilities
GovOPlaN Facilities module behavior or integration.
module/files
GovOPlaN files module behavior or integration.
module/fit-connect
GovOPlaN Fit Connect module behavior or integration.
module/forms
GovOPlaN Forms module behavior or integration.
module/forms-runtime
GovOPlaN Forms Runtime module behavior or integration.
module/grants
GovOPlaN Grants module behavior or integration.
module/helpdesk
GovOPlaN Helpdesk module behavior or integration.
module/identity
GovOPlaN Identity module behavior or integration.
module/identity-trust
GovOPlaN Identity Trust module behavior or integration.
module/idm
GovOPlaN Idm module behavior or integration.
module/inspections
GovOPlaN Inspections module behavior or integration.
module/issue-reporting
GovOPlaN Issue Reporting module behavior or integration.
module/learning
GovOPlaN Learning module behavior or integration.
module/ledger
GovOPlaN Ledger module behavior or integration.
module/mail
GovOPlaN mail module behavior or integration.
module/notifications
GovOPlaN Notifications module behavior or integration.
module/ops
GovOPlaN Ops module behavior or integration.
module/organizations
GovOPlaN Organizations module behavior or integration.
module/payments
GovOPlaN Payments module behavior or integration.
module/permits
GovOPlaN Permits module behavior or integration.
module/policy
GovOPlaN Policy module behavior or integration.
module/poll
GovOPlaN Poll module behavior or integration.
module/portal
GovOPlaN Portal module behavior or integration.
module/postbox
GovOPlaN Postbox module behavior or integration.
module/procurement
GovOPlaN Procurement module behavior or integration.
module/records
GovOPlaN Records module behavior or integration.
module/reporting
GovOPlaN Reporting module behavior or integration.
module/resources
GovOPlaN Resources module behavior or integration.
module/risk-compliance
GovOPlaN Risk Compliance module behavior or integration.
module/scheduling
GovOPlaN Scheduling module behavior or integration.
module/search
GovOPlaN Search module behavior or integration.
module/tasks
GovOPlaN Tasks module behavior or integration.
module/templates
GovOPlaN Templates module behavior or integration.
module/tenancy
GovOPlaN Tenancy module behavior or integration.
module/transparency
GovOPlaN Transparency module behavior or integration.
module/web
GovOPlaN public website, product page, or publication content.
module/workflow
GovOPlaN Workflow module behavior or integration.
module/xoev
GovOPlaN Xoev module behavior or integration.
module/xrechnung
GovOPlaN Xrechnung module behavior or integration.
module/xta-osci
GovOPlaN Xta Osci module behavior or integration.
priority
p0
Immediate stop-the-line priority.
priority
p1
High priority for the next focused work window.
priority
p2
Normal planned priority.
priority
p3
Low priority or opportunistic cleanup.
source/backlog-import
Imported from markdown backlog, roadmap, plan, or TODO files.
source/module-roadmap
Created from GovOPlaN module and integration roadmap planning.
source/security-audit
Created from a structured security or code-quality audit report.
source/todo-scan
Imported from inline TODO/FIXME/HACK markers by the Gitea TODO importer.
status
blocked
Cannot progress without a decision, dependency, credential, or external change.
status
in-progress
Currently being worked.
status
needs-info
Needs clarifying input before implementation can proceed safely.
status
ready
Ready for implementation.
status
triage
Needs review, ownership, priority, or acceptance criteria.
type
bug
A reproducible defect, regression, or incorrect behavior.
type
debt
Cleanup, refactoring, risk reduction, or deferred engineering work.
type
docs
Documentation, process, or developer workflow work.
type
feature
New user-visible behavior or platform capability.
type
task
Implementation, maintenance, migration, or operational work.
type
user-story
End-to-end user journey or real-world process story used to steer product slices.
No Label
area/webui
codex/ready
module/mail
priority
p2
status
ready
type
task
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zemion
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: add-ideas/govoplan-mail#10
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?