Code cleanup and deduplication

src/features/campaigns/GlobalSettingsPage.tsx

@@ -1,4 +1,4 @@
-import { useEffect, useState } from "react";
+import { useState } from "react";
 import type { ApiSettings } from "../../types";
 import Button from "../../components/Button";
 import Card from "../../components/Card";
@@ -6,11 +6,10 @@ import FormField from "../../components/FormField";
 import PageTitle from "../../components/PageTitle";
 import LoadingFrame from "../../components/LoadingFrame";
 import ToggleSwitch from "../../components/ToggleSwitch";
-import { autosaveCampaignVersion } from "../../api/campaigns";
 import { useCampaignWorkspaceData } from "./hooks/useCampaignWorkspaceData";
-import { asRecord, formatDateTime, getCampaignJson, isAuditLockedVersion, versionLockReason } from "./utils/campaignView";
-import { cloneJson, ensureCampaignDraft, getBool, getNumber, getText, updateNested } from "./utils/draftEditor";
-import { useRegisterCampaignUnsavedChanges } from "./context/UnsavedChangesContext";
+import { useCampaignDraftEditor } from "./hooks/useCampaignDraftEditor";
+import { asRecord, isAuditLockedVersion, versionLockReason } from "./utils/campaignView";
+import { cloneJson, getBool, getNumber, getText, updateNested } from "./utils/draftEditor";
 
 const behaviorOptions = ["block", "ask", "drop", "continue", "warn"];
 
@@ -18,15 +17,24 @@ type EditorState = Record<string, unknown>;
 
 export default function GlobalSettingsPage({ settings, campaignId }: { settings: ApiSettings; campaignId: string }) {
   const { data, loading, error, reload, setError } = useCampaignWorkspaceData(settings, campaignId);
-  const [draft, setDraft] = useState<Record<string, unknown> | null>(null);
   const [editorState, setEditorState] = useState<EditorState>({});
-  const [dirty, setDirty] = useState(false);
-  const [saveState, setSaveState] = useState("Loaded");
-  const [localError, setLocalError] = useState("");
 
   const version = data.currentVersion;
   const locked = isAuditLockedVersion(version);
-  const displayDraft = draft ?? ensureCampaignDraft(null);
+  const { draft, displayDraft, dirty, saveState, localError, patch, markDirty, saveDraft } = useCampaignDraftEditor({
+    settings,
+    campaignId,
+    version,
+    locked,
+    reload,
+    setError,
+    currentStep: "global-settings",
+    unsavedTitle: "Unsaved global settings",
+    unsavedMessage: "Global settings have unsaved changes. Save them before leaving, or discard them and continue.",
+    extraPayload: () => ({ editor_state: editorState }),
+    onLoaded: (loadedVersion) => setEditorState(cloneJson(loadedVersion.editor_state ?? {})),
+    onSaved: (savedVersion) => setEditorState(cloneJson(savedVersion.editor_state ?? editorState))
+  });
   const validationPolicy = asRecord(displayDraft.validation_policy);
   const attachments = asRecord(displayDraft.attachments);
   const delivery = asRecord(displayDraft.delivery);
@@ -35,63 +43,14 @@ export default function GlobalSettingsPage({ settings, campaignId }: { settings:
   const statusTracking = asRecord(displayDraft.status_tracking);
   const optIns = asRecord(editorState.opt_ins);
 
-  useEffect(() => {
-    if (!version) return;
-    setDraft(ensureCampaignDraft(version));
-    setEditorState(cloneJson(version.editor_state ?? {}));
-    setDirty(false);
-    setSaveState(version.autosaved_at ? `Loaded saved draft ${formatDateTime(version.autosaved_at)}` : "Loaded");
-  }, [version]);
 
 
-  function patch(path: string[], value: unknown) {
-    if (locked) return;
-    setDraft((current) => updateNested(current ?? {}, path, value));
-    setDirty(true);
-    setLocalError("");
-  }
-
   function patchEditor(path: string[], value: unknown) {
     if (locked) return;
     setEditorState((current) => updateNested(current, path, value));
-    setDirty(true);
-    setLocalError("");
+    markDirty();
   }
 
-  async function saveDraft(mode: "auto" | "manual" = "manual"): Promise<boolean> {
-    if (!draft || !version || locked) return false;
-    setSaveState("Saving…");
-    setError("");
-    setLocalError("");
-    try {
-      const saved = await autosaveCampaignVersion(settings, campaignId, version.id, {
-        campaign_json: draft,
-        editor_state: editorState,
-        current_flow: "manual",
-        current_step: "global-settings",
-        workflow_state: "editing",
-        is_complete: false
-      });
-      setDraft(getCampaignJson(saved));
-      setEditorState(cloneJson(saved.editor_state ?? editorState));
-      setDirty(false);
-      setSaveState(`Saved ${formatDateTime(saved.autosaved_at ?? saved.updated_at)}`);
-      await reload();
-      return true;
-    } catch (err) {
-      const text = err instanceof Error ? err.message : String(err);
-      setLocalError(text);
-      setSaveState("Save failed");
-      return false;
-    }
-  }
-
-  useRegisterCampaignUnsavedChanges(dirty && !locked ? {
-    title: "Unsaved global settings",
-    message: "Global settings have unsaved changes. Save them before leaving, or discard them and continue.",
-    onSave: () => saveDraft("manual"),
-    onDiscard: () => setDirty(false)
-  } : null);
 
   return (
     <div className="content-pad workspace-data-page">