Code cleanup and deduplication

src/features/campaigns/RecipientDetailsPage.tsx

@@ -1,15 +1,14 @@
-import { useEffect, useMemo, useState } from "react";
+import { useMemo } from "react";
 import { Link } from "react-router-dom";
 import type { ApiSettings } from "../../types";
 import Button from "../../components/Button";
 import Card from "../../components/Card";
 import PageTitle from "../../components/PageTitle";
 import LoadingFrame from "../../components/LoadingFrame";
-import { autosaveCampaignVersion } from "../../api/campaigns";
 import { useCampaignWorkspaceData } from "./hooks/useCampaignWorkspaceData";
-import { asArray, asRecord, formatDateTime, isAuditLockedVersion, isRecord, versionLockReason } from "./utils/campaignView";
-import { ensureCampaignDraft, getBool, getText, updateNested } from "./utils/draftEditor";
-import { useRegisterCampaignUnsavedChanges } from "./context/UnsavedChangesContext";
+import { useCampaignDraftEditor } from "./hooks/useCampaignDraftEditor";
+import { asArray, asRecord, isAuditLockedVersion, isRecord, versionLockReason } from "./utils/campaignView";
+import { getBool, getText } from "./utils/draftEditor";
 import FieldValueInput from "./components/FieldValueInput";
 import AttachmentRulesOverlay, { type AttachmentBasePath, type AttachmentRule } from "./components/AttachmentRulesOverlay";
 import { addressesFromValue } from "../../utils/emailAddresses";
@@ -23,14 +22,20 @@ type FieldDefinition = {
 
 export default function RecipientDetailsPage({ settings, campaignId }: { settings: ApiSettings; campaignId: string }) {
   const { data, loading, error, reload, setError } = useCampaignWorkspaceData(settings, campaignId);
-  const [draft, setDraft] = useState<Record<string, unknown> | null>(null);
-  const [dirty, setDirty] = useState(false);
-  const [saveState, setSaveState] = useState("Loaded");
-  const [localError, setLocalError] = useState("");
 
   const version = data.currentVersion;
   const locked = isAuditLockedVersion(version);
-  const displayDraft = draft ?? ensureCampaignDraft(null);
+  const { draft, displayDraft, dirty, saveState, localError, patch, saveDraft } = useCampaignDraftEditor({
+    settings,
+    campaignId,
+    version,
+    locked,
+    reload,
+    setError,
+    currentStep: "recipient-data",
+    unsavedTitle: "Unsaved recipient data changes",
+    unsavedMessage: "Recipient field values or attachments have unsaved changes. Save them before leaving, or discard them and continue."
+  });
   const entries = asRecord(displayDraft.entries);
   const inlineEntries = asArray(entries.inline).map(asRecord);
   const source = asRecord(entries.source);
@@ -42,19 +47,6 @@ export default function RecipientDetailsPage({ settings, campaignId }: { setting
     return enabled.length > 0 ? enabled : attachmentBasePaths;
   }, [attachmentBasePaths]);
 
-  useEffect(() => {
-    if (!version) return;
-    setDraft(ensureCampaignDraft(version));
-    setDirty(false);
-    setSaveState(version.autosaved_at ? `Loaded saved draft ${formatDateTime(version.autosaved_at)}` : "Loaded");
-  }, [version]);
-
-  function patch(path: string[], value: unknown) {
-    if (locked) return;
-    setDraft((current) => updateNested(current ?? {}, path, value));
-    setDirty(true);
-    setLocalError("");
-  }
 
   function replaceInlineEntries(nextEntries: Record<string, unknown>[]) {
     patch(["entries", "inline"], nextEntries);
@@ -79,37 +71,6 @@ export default function RecipientDetailsPage({ settings, campaignId }: { setting
     updateEntry(index, (entry) => ({ ...entry, attachments }));
   }
 
-  async function saveRecipientData(mode: "auto" | "manual" = "manual"): Promise<boolean> {
-    if (!draft || !version || locked) return false;
-    setSaveState("Saving…");
-    setError("");
-    setLocalError("");
-    try {
-      const saved = await autosaveCampaignVersion(settings, campaignId, version.id, {
-        campaign_json: draft,
-        current_flow: "manual",
-        current_step: "recipient-data",
-        workflow_state: "editing",
-        is_complete: false
-      });
-      setDraft(ensureCampaignDraft(saved));
-      setDirty(false);
-      setSaveState(`Saved ${formatDateTime(saved.autosaved_at ?? saved.updated_at)}`);
-      await reload();
-      return true;
-    } catch (err) {
-      setLocalError(err instanceof Error ? err.message : String(err));
-      setSaveState("Save failed");
-      return false;
-    }
-  }
-
-  useRegisterCampaignUnsavedChanges(dirty && !locked ? {
-    title: "Unsaved recipient data changes",
-    message: "Recipient field values or attachment rules have unsaved changes. Save them before leaving, or discard them and continue.",
-    onSave: () => saveRecipientData("manual"),
-    onDiscard: () => setDirty(false)
-  } : null);
 
   return (
     <div className="content-pad workspace-data-page">
@@ -120,7 +81,7 @@ export default function RecipientDetailsPage({ settings, campaignId }: { setting
         </div>
         <div className="button-row compact-actions">
           <Button onClick={reload} disabled={loading}>Reload</Button>
-          <Button variant="primary" onClick={() => saveRecipientData("manual")} disabled={!dirty || locked || !draft}>Save</Button>
+          <Button variant="primary" onClick={() => saveDraft("manual")} disabled={!dirty || locked || !draft}>Save</Button>
         </div>
       </div>
 
@@ -190,7 +151,7 @@ export default function RecipientDetailsPage({ settings, campaignId }: { setting
           </Card>
 
           <div className="button-row page-bottom-actions">
-            <Button variant="primary" onClick={() => saveRecipientData("manual")} disabled={!dirty || locked}>Save</Button>
+            <Button variant="primary" onClick={() => saveDraft("manual")} disabled={!dirty || locked}>Save</Button>
           </div>
         </>
       </LoadingFrame>