GovOPlaN/govoplan-campaign
1
0
Fork 0
Code Issues 46 Pull Requests Actions Packages Projects Releases Wiki Activity

[Feature] Audit-proof single-recipient campaign send #69

New Issue
Open
opened 2026-07-14 20:08:41 +02:00 by zemion · 4 comments
zemion commented 2026-07-14 20:08:41 +02:00
Owner
Copy Link

Problem / User Need

Operators need to transport exactly one immutable built campaign message without accidentally changing unrelated recipients. Test, official one-off send, and resend have distinct state and audit consequences.

Accepted Semantics

  • Test: transport the selected rendered message once and log the attempt/result, but leave canonical job, recipient, campaign completion, and official-attempt state unsent/unchanged.
  • Single-send: make one initial official delivery attempt for a selected unsent message, log it, and mark only that message done after successful SMTP acceptance. Failure is logged and leaves it not done.
  • Single-resend: explicitly transport one selected message again whether it previously succeeded, failed, was cancelled, or was never attempted. Log a new action/attempt linked to the earlier history. A failed resend never erases an earlier successful disposition.

These operations never enqueue or alter other campaign messages.

Acceptance Criteria

  • API requires kind: test | single_send | single_resend; omission never defaults to an official action.
  • Every invocation targets exactly one immutable built job and performs at most one SMTP attempt; replay of the same command is idempotent and does not become an implicit retry.
  • Test leaves official state and completion aggregation unchanged.
  • Single-send marks only the selected message done after successful transport.
  • Single-resend is allowed regardless of prior final outcome. Only active or uncertain concurrency states such as claimed, sending, or outcome-unknown must be resolved first.
  • Successful resend sets done if not already done; failed resend preserves any earlier successful disposition.
  • Resend requires a reason. Every mode records kind, actor, timestamps, campaign/version/job/message identities and hashes, recipient evidence, reason/context, idempotency key, SMTP outcome, and linked attempt.
  • The action record exists before delivery and is finalized afterwards, so initiation failures are auditable. Test/resend history remains separate from canonical state.
  • Protocol/report output distinguishes all three action kinds and outcomes.
  • UI names each consequence, shows recipient/version/message identity, requires the resend reason, and confirms the selected mode.
  • Tests cover accepted, temporary, permanent, and unknown outcomes; the prior-state matrix; duplicate/concurrent calls; authorization; audit/report output; and completion aggregation.

Audited Local State (2026-07-20)

Current WIP implements only a generic initial official send. It has no kind/reason, cannot test-send with transport while preserving unsent state, rejects resends after any prior attempt, and lacks the required action/audit fields and focused UI tests. Implement this contract as an isolated slice rather than treating the WIP as complete.

## Problem / User Need Operators need to transport exactly one immutable built campaign message without accidentally changing unrelated recipients. Test, official one-off send, and resend have distinct state and audit consequences. ## Accepted Semantics - **Test**: transport the selected rendered message once and log the attempt/result, but leave canonical job, recipient, campaign completion, and official-attempt state unsent/unchanged. - **Single-send**: make one initial official delivery attempt for a selected unsent message, log it, and mark only that message done after successful SMTP acceptance. Failure is logged and leaves it not done. - **Single-resend**: explicitly transport one selected message again whether it previously succeeded, failed, was cancelled, or was never attempted. Log a new action/attempt linked to the earlier history. A failed resend never erases an earlier successful disposition. These operations never enqueue or alter other campaign messages. ## Acceptance Criteria - [ ] API requires `kind: test | single_send | single_resend`; omission never defaults to an official action. - [ ] Every invocation targets exactly one immutable built job and performs at most one SMTP attempt; replay of the same command is idempotent and does not become an implicit retry. - [ ] Test leaves official state and completion aggregation unchanged. - [ ] Single-send marks only the selected message done after successful transport. - [ ] Single-resend is allowed regardless of prior final outcome. Only active or uncertain concurrency states such as claimed, sending, or outcome-unknown must be resolved first. - [ ] Successful resend sets done if not already done; failed resend preserves any earlier successful disposition. - [ ] Resend requires a reason. Every mode records kind, actor, timestamps, campaign/version/job/message identities and hashes, recipient evidence, reason/context, idempotency key, SMTP outcome, and linked attempt. - [ ] The action record exists before delivery and is finalized afterwards, so initiation failures are auditable. Test/resend history remains separate from canonical state. - [ ] Protocol/report output distinguishes all three action kinds and outcomes. - [ ] UI names each consequence, shows recipient/version/message identity, requires the resend reason, and confirms the selected mode. - [ ] Tests cover accepted, temporary, permanent, and unknown outcomes; the prior-state matrix; duplicate/concurrent calls; authorization; audit/report output; and completion aggregation. ## Audited Local State (2026-07-20) Current WIP implements only a generic initial official send. It has no kind/reason, cannot test-send with transport while preserving unsent state, rejects resends after any prior attempt, and lacks the required action/audit fields and focused UI tests. Implement this contract as an isolated slice rather than treating the WIP as complete.
zemion commented 2026-07-15 10:50:47 +02:00
Author
Owner
Copy Link

Codex State: started

Summary

  • Starting implementation: support audit-proof single-message send from preview/review for one recipient entry.

Suggested status label: status/in-progress

## Codex State: started ### Summary - Starting implementation: support audit-proof single-message send from preview/review for one recipient entry. Suggested status label: `status/in-progress`
zemion commented 2026-07-15 11:03:48 +02:00
Author
Owner
Copy Link

Codex State: done

Summary

  • Implemented audit-path single message send from built-message preview with confirmation.
  • Added backend endpoint /campaigns/{campaign_id}/jobs/{job_id}/send using the existing CampaignJob/SendAttempt protocol and EML evidence verification.
  • Added preview footer action, guarded disabled states, and UI status refresh after the one-message send.

Changed Files

  • src/govoplan_campaign/backend/sending/jobs.py
  • src/govoplan_campaign/backend/router.py
  • src/govoplan_campaign/backend/schemas.py
  • webui/src/api/campaigns.ts
  • webui/src/features/campaigns/ReviewSendPage.tsx
  • webui/src/features/campaigns/components/MessagePreviewOverlay.tsx

Verification

  • /mnt/DATA/git/govoplan/.venv/bin/python -m unittest tests.test_zip_service tests.test_attachment_building
  • GOVOPLAN_WEBUI_MODULE_PACKAGES=@govoplan/campaign-webui npm run build (from govoplan-core/webui)
## Codex State: done ### Summary - Implemented audit-path single message send from built-message preview with confirmation. - Added backend endpoint /campaigns/{campaign_id}/jobs/{job_id}/send using the existing CampaignJob/SendAttempt protocol and EML evidence verification. - Added preview footer action, guarded disabled states, and UI status refresh after the one-message send. ### Changed Files - `src/govoplan_campaign/backend/sending/jobs.py` - `src/govoplan_campaign/backend/router.py` - `src/govoplan_campaign/backend/schemas.py` - `webui/src/api/campaigns.ts` - `webui/src/features/campaigns/ReviewSendPage.tsx` - `webui/src/features/campaigns/components/MessagePreviewOverlay.tsx` ### Verification - `/mnt/DATA/git/govoplan/.venv/bin/python -m unittest tests.test_zip_service tests.test_attachment_building` - `GOVOPLAN_WEBUI_MODULE_PACKAGES=@govoplan/campaign-webui npm run build (from govoplan-core/webui)`
zemion commented 2026-07-20 14:35:21 +02:00
Author
Owner
Copy Link

No remote commit, PR, or branch contains this work; the endpoint and UI are only uncommitted WIP. The WIP uses the existing claim path, but it has no send-kind or reason/context, treats every action as a normal SMTP attempt, does not fully audit failed initiation, and has no focused tests. Reopening until terminology and guardrails for test, partial/official, and resend behavior are decided and the isolated implementation is integrated.

No remote commit, PR, or branch contains this work; the endpoint and UI are only uncommitted WIP. The WIP uses the existing claim path, but it has no send-kind or reason/context, treats every action as a normal SMTP attempt, does not fully audit failed initiation, and has no focused tests. Reopening until terminology and guardrails for test, partial/official, and resend behavior are decided and the isolated implementation is integrated.
zemion reopened this issue 2026-07-20 14:35:21 +02:00
zemion commented 2026-07-20 16:42:39 +02:00
Author
Owner
Copy Link

Product terminology and state semantics were accepted on 2026-07-20. The issue is now ready for an isolated implementation slice; #63 vocabulary remains a separate review decision.

Product terminology and state semantics were accepted on 2026-07-20. The issue is now ready for an isolated implementation slice; #63 vocabulary remains a separate review decision.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
HTTP API contracts, routers, schemas, or API smoke behavior.
area/auth
Authentication, sessions, access bootstrap, or login behavior.
area/db
Database sessions, models, transactions, or persistence primitives.
area/devex
Local developer workflow, scripts, tests, tooling, or release helpers.
area/docs
Durable documentation and project guidance.
area/governance
Governance policy, audit, privacy, retention, or compliance behavior.
area/marketing
Public website, product messaging, publication copy, or legal page content.
area/migrations
Alembic migrations, schema bootstrap, or persistence evolution.
area/module-system
Module discovery, manifests, capabilities, routing, or optional integrations.
area/rbac
Permissions, roles, delegation, or authorization policy.
area/release
Versioning, release locks, tags, packaging, or dependency pins.
area/security
Security posture, static analysis, supply-chain hardening, or vulnerability remediation.
area/tenancy
Tenant boundaries, provisioning, or tenant-scoped data behavior.
area/webui
Shared WebUI shell, frontend components, routing, or frontend tests.
audit/complexity
Complexity finding from Radon, Xenon, or equivalent maintainability scans.
audit/duplication
Duplicated-code finding from jscpd or equivalent similarity scans.
audit/false-positive
Audit finding reviewed as a narrow false positive or acceptable risk.
audit/needs-design
Audit finding that needs an architectural or product decision before implementation.
audit/quick-fix
Audit finding that appears narrow and directly fixable.
audit/structural
Audit finding that needs design, refactoring, or behavior review.
codex/needs-human
Needs an explicit human decision before Codex should implement.
codex/ready
Suitable for Codex to pick up with the existing issue context.
module/access
GovOPlaN access, identity, authentication, RBAC, and administration behavior.
module/addresses
GovOPlaN Addresses module behavior or integration.
module/admin
GovOPlaN Admin module behavior or integration.
module/appointments
GovOPlaN Appointments module behavior or integration.
module/audit
GovOPlaN Audit module behavior or integration.
module/calendar
GovOPlaN Calendar module behavior or integration.
module/campaign
GovOPlaN campaign module behavior or integration.
module/cases
GovOPlaN Cases module behavior or integration.
module/connectors
GovOPlaN Connectors module behavior or integration.
module/core
GovOPlaN core runner, shared primitives, shell, or extension points.
module/dataflow
GovOPlaN Dataflow module behavior or integration.
module/datasources
GovOPlaN governed datasource contracts, catalogs, and integrations.
module/dist-lists
GovOPlaN Distribution Lists module behavior or integration.
module/dms
GovOPlaN Dms module behavior or integration.
module/erp
GovOPlaN Erp module behavior or integration.
module/evaluation
GovOPlaN Evaluation module behavior or integration.
module/files
GovOPlaN files module behavior or integration.
module/fit-connect
GovOPlaN Fit Connect module behavior or integration.
module/forms
GovOPlaN Forms module behavior or integration.
module/identity
GovOPlaN Identity module behavior or integration.
module/identity-trust
GovOPlaN Identity Trust module behavior or integration.
module/idm
GovOPlaN Idm module behavior or integration.
module/ledger
GovOPlaN Ledger module behavior or integration.
module/mail
GovOPlaN mail module behavior or integration.
module/notifications
GovOPlaN Notifications module behavior or integration.
module/ops
GovOPlaN Ops module behavior or integration.
module/organizations
GovOPlaN Organizations module behavior or integration.
module/payments
GovOPlaN Payments module behavior or integration.
module/permits
GovOPlaN Permits module behavior or integration.
module/policy
GovOPlaN Policy module behavior or integration.
module/poll
GovOPlaN Poll module behavior or integration.
module/portal
GovOPlaN Portal module behavior or integration.
module/postbox
GovOPlaN Postbox module behavior or integration.
module/reporting
GovOPlaN Reporting module behavior or integration.
module/risk-compliance
GovOPlaN Risk Compliance module behavior or integration.
module/scheduling
GovOPlaN Scheduling module behavior or integration.
module/search
GovOPlaN Search module behavior or integration.
module/tasks
GovOPlaN Tasks module behavior or integration.
module/templates
GovOPlaN Templates module behavior or integration.
module/tenancy
GovOPlaN Tenancy module behavior or integration.
module/views
GovOPlaN governed task views, interface projections, and workflow view integration.
module/workflow
GovOPlaN Workflow module behavior or integration.
module/xoev
GovOPlaN Xoev module behavior or integration.
module/xrechnung
GovOPlaN Xrechnung module behavior or integration.
module/xta-osci
GovOPlaN Xta Osci module behavior or integration.
priority
p0
Immediate stop-the-line priority.
priority
p1
High priority for the next focused work window.
priority
p2
Normal planned priority.
priority
p3
Low priority or opportunistic cleanup.
source/backlog-import
Imported from markdown backlog, roadmap, plan, or TODO files.
source/security-audit
Created from a structured security or code-quality audit report.
source/todo-scan
Imported from inline TODO/FIXME/HACK markers by the Gitea TODO importer.
status
blocked
Cannot progress without a decision, dependency, credential, or external change.
status
in-progress
Currently being worked.
status
needs-info
Needs clarifying input before implementation can proceed safely.
status
ready
Ready for implementation.
status
triage
Needs review, ownership, priority, or acceptance criteria.
type
bug
A reproducible defect, regression, or incorrect behavior.
type
debt
Cleanup, refactoring, risk reduction, or deferred engineering work.
type
docs
Documentation, process, or developer workflow work.
type
feature
New user-visible behavior or platform capability.
type
task
Implementation, maintenance, migration, or operational work.
type
user-story
End-to-end user journey or real-world process story used to steer product slices.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zemion
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GovOPlaN/govoplan-campaign#69
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?