GovOPlaN/govoplan-campaign
1
0
Fork 0
Code Issues 46 Pull Requests Actions Packages Projects Releases Wiki Activity

Mail preview overlay: use fixed dimensions and stable footer #73

New Issue
Closed
opened 2026-07-15 13:00:23 +02:00 by zemion · 4 comments
zemion commented 2026-07-15 13:00:23 +02:00
Owner
Copy Link

Context

The campaign mail/message preview overlay currently grows and shrinks with the rendered message content. This makes the footer/actions move between messages and makes review navigation feel unstable.

Desired behavior

  • Use fixed responsive overlay dimensions for built-message, mock-mail, and template/mail preview variants.
  • Keep header and footer/action buttons in stable positions.
  • Let message body, metadata, raw MIME, and attachment lists scroll inside the overlay.
  • Preserve mobile behavior with sensible max-height/max-width constraints.

Acceptance criteria

  • Switching between previewed messages does not move the primary action buttons.
  • Long content scrolls inside the overlay instead of resizing the dialog.
  • Short content does not collapse the dialog below the standard review size.
## Context The campaign mail/message preview overlay currently grows and shrinks with the rendered message content. This makes the footer/actions move between messages and makes review navigation feel unstable. ## Desired behavior - Use fixed responsive overlay dimensions for built-message, mock-mail, and template/mail preview variants. - Keep header and footer/action buttons in stable positions. - Let message body, metadata, raw MIME, and attachment lists scroll inside the overlay. - Preserve mobile behavior with sensible max-height/max-width constraints. ## Acceptance criteria - Switching between previewed messages does not move the primary action buttons. - Long content scrolls inside the overlay instead of resizing the dialog. - Short content does not collapse the dialog below the standard review size.
zemion commented 2026-07-20 14:35:21 +02:00
Author
Owner
Copy Link

Raised to P2 under the interface-consistency focus. Remote CSS already improves preview body sizing and keeps the footer outside the scroll body, but stable overlay behavior still needs focused visual/component verification, especially with the local #69 footer actions.

Raised to P2 under the interface-consistency focus. Remote CSS already improves preview body sizing and keeps the footer outside the scroll body, but stable overlay behavior still needs focused visual/component verification, especially with the local #69 footer actions.
zemion commented 2026-07-20 15:29:58 +02:00
Author
Owner
Copy Link

Implemented locally as the first Campaign interface-pattern pilot:

  • all unique attachment matches remain available in a bounded, keyboard-focusable scrolling list; the count opens an accessible full-detail dialog
  • message preview geometry now has a stable header/body/footer, bounded responsive dimensions, scrolling body, keyboard navigation, and accessible close behavior
  • dynamic labels/counts use i18nMessage; the slice has stable English/German SHA-1 keys

Validation: npm run test:review-preview-ui, Campaign policy/template/import focused tests, Core structural i18n audit, Campaign-only production build (3,759 modules), and git diff --check passed. Kept open/in progress because the changes are local and share a larger unintegrated Campaign worktree.

<!-- codex-progress-review-preview-2026-07-20 --> Implemented locally as the first Campaign interface-pattern pilot: - all unique attachment matches remain available in a bounded, keyboard-focusable scrolling list; the count opens an accessible full-detail dialog - message preview geometry now has a stable header/body/footer, bounded responsive dimensions, scrolling body, keyboard navigation, and accessible close behavior - dynamic labels/counts use `i18nMessage`; the slice has stable English/German SHA-1 keys Validation: `npm run test:review-preview-ui`, Campaign policy/template/import focused tests, Core structural i18n audit, Campaign-only production build (3,759 modules), and `git diff --check` passed. Kept open/in progress because the changes are local and share a larger unintegrated Campaign worktree.
zemion commented 2026-07-20 17:12:09 +02:00
Author
Owner
Copy Link

Codex State: progress

Summary

  • The overlay now has a responsive fixed workspace, body-owned scrolling, stable footer geometry, and an accessible close control.

Changed Files

  • govoplan-campaign 724ca77

Verification

  • node webui/tests/message-preview-overlay-structure.test.mjs (pass)
  • git diff --check (pass)

Next / Blocked

  • Review and push the local commit; keep the issue open until it reaches remote main.

Suggested status label: status/in-progress

## Codex State: progress ### Summary - The overlay now has a responsive fixed workspace, body-owned scrolling, stable footer geometry, and an accessible close control. ### Changed Files - `govoplan-campaign 724ca77` ### Verification - `node webui/tests/message-preview-overlay-structure.test.mjs (pass)` - `git diff --check (pass)` ### Next / Blocked - Review and push the local commit; keep the issue open until it reaches remote main. Suggested status label: `status/in-progress`
zemion commented 2026-07-22 08:06:07 +02:00
Author
Owner
Copy Link

Codex State: done

Summary

  • The fixed responsive preview workspace, body-owned scrolling, and stable footer/action geometry are integrated on remote main at commit 724ca77.

Verification

  • node tests/message-preview-overlay-structure.test.mjs
  • npm run test:review-preview-ui
## Codex State: done ### Summary - The fixed responsive preview workspace, body-owned scrolling, and stable footer/action geometry are integrated on remote main at commit 724ca77. ### Verification - `node tests/message-preview-overlay-structure.test.mjs` - `npm run test:review-preview-ui`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
HTTP API contracts, routers, schemas, or API smoke behavior.
area/auth
Authentication, sessions, access bootstrap, or login behavior.
area/db
Database sessions, models, transactions, or persistence primitives.
area/devex
Local developer workflow, scripts, tests, tooling, or release helpers.
area/docs
Durable documentation and project guidance.
area/governance
Governance policy, audit, privacy, retention, or compliance behavior.
area/marketing
Public website, product messaging, publication copy, or legal page content.
area/migrations
Alembic migrations, schema bootstrap, or persistence evolution.
area/module-system
Module discovery, manifests, capabilities, routing, or optional integrations.
area/rbac
Permissions, roles, delegation, or authorization policy.
area/release
Versioning, release locks, tags, packaging, or dependency pins.
area/security
Security posture, static analysis, supply-chain hardening, or vulnerability remediation.
area/tenancy
Tenant boundaries, provisioning, or tenant-scoped data behavior.
area/webui
Shared WebUI shell, frontend components, routing, or frontend tests.
audit/complexity
Complexity finding from Radon, Xenon, or equivalent maintainability scans.
audit/duplication
Duplicated-code finding from jscpd or equivalent similarity scans.
audit/false-positive
Audit finding reviewed as a narrow false positive or acceptable risk.
audit/needs-design
Audit finding that needs an architectural or product decision before implementation.
audit/quick-fix
Audit finding that appears narrow and directly fixable.
audit/structural
Audit finding that needs design, refactoring, or behavior review.
codex/needs-human
Needs an explicit human decision before Codex should implement.
codex/ready
Suitable for Codex to pick up with the existing issue context.
module/access
GovOPlaN access, identity, authentication, RBAC, and administration behavior.
module/addresses
GovOPlaN Addresses module behavior or integration.
module/admin
GovOPlaN Admin module behavior or integration.
module/appointments
GovOPlaN Appointments module behavior or integration.
module/audit
GovOPlaN Audit module behavior or integration.
module/calendar
GovOPlaN Calendar module behavior or integration.
module/campaign
GovOPlaN campaign module behavior or integration.
module/cases
GovOPlaN Cases module behavior or integration.
module/connectors
GovOPlaN Connectors module behavior or integration.
module/core
GovOPlaN core runner, shared primitives, shell, or extension points.
module/dataflow
GovOPlaN Dataflow module behavior or integration.
module/datasources
GovOPlaN governed datasource contracts, catalogs, and integrations.
module/dist-lists
GovOPlaN Distribution Lists module behavior or integration.
module/dms
GovOPlaN Dms module behavior or integration.
module/erp
GovOPlaN Erp module behavior or integration.
module/evaluation
GovOPlaN Evaluation module behavior or integration.
module/files
GovOPlaN files module behavior or integration.
module/fit-connect
GovOPlaN Fit Connect module behavior or integration.
module/forms
GovOPlaN Forms module behavior or integration.
module/identity
GovOPlaN Identity module behavior or integration.
module/identity-trust
GovOPlaN Identity Trust module behavior or integration.
module/idm
GovOPlaN Idm module behavior or integration.
module/ledger
GovOPlaN Ledger module behavior or integration.
module/mail
GovOPlaN mail module behavior or integration.
module/notifications
GovOPlaN Notifications module behavior or integration.
module/ops
GovOPlaN Ops module behavior or integration.
module/organizations
GovOPlaN Organizations module behavior or integration.
module/payments
GovOPlaN Payments module behavior or integration.
module/permits
GovOPlaN Permits module behavior or integration.
module/policy
GovOPlaN Policy module behavior or integration.
module/poll
GovOPlaN Poll module behavior or integration.
module/portal
GovOPlaN Portal module behavior or integration.
module/postbox
GovOPlaN Postbox module behavior or integration.
module/reporting
GovOPlaN Reporting module behavior or integration.
module/risk-compliance
GovOPlaN Risk Compliance module behavior or integration.
module/scheduling
GovOPlaN Scheduling module behavior or integration.
module/search
GovOPlaN Search module behavior or integration.
module/tasks
GovOPlaN Tasks module behavior or integration.
module/templates
GovOPlaN Templates module behavior or integration.
module/tenancy
GovOPlaN Tenancy module behavior or integration.
module/views
GovOPlaN governed task views, interface projections, and workflow view integration.
module/workflow
GovOPlaN Workflow module behavior or integration.
module/xoev
GovOPlaN Xoev module behavior or integration.
module/xrechnung
GovOPlaN Xrechnung module behavior or integration.
module/xta-osci
GovOPlaN Xta Osci module behavior or integration.
priority
p0
Immediate stop-the-line priority.
priority
p1
High priority for the next focused work window.
priority
p2
Normal planned priority.
priority
p3
Low priority or opportunistic cleanup.
source/backlog-import
Imported from markdown backlog, roadmap, plan, or TODO files.
source/security-audit
Created from a structured security or code-quality audit report.
source/todo-scan
Imported from inline TODO/FIXME/HACK markers by the Gitea TODO importer.
status
blocked
Cannot progress without a decision, dependency, credential, or external change.
status
in-progress
Currently being worked.
status
needs-info
Needs clarifying input before implementation can proceed safely.
status
ready
Ready for implementation.
status
triage
Needs review, ownership, priority, or acceptance criteria.
type
bug
A reproducible defect, regression, or incorrect behavior.
type
debt
Cleanup, refactoring, risk reduction, or deferred engineering work.
type
docs
Documentation, process, or developer workflow work.
type
feature
New user-visible behavior or platform capability.
type
task
Implementation, maintenance, migration, or operational work.
type
user-story
End-to-end user journey or real-world process story used to steer product slices.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zemion
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: GovOPlaN/govoplan-campaign#73
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?