add-ideas/govoplan-addresses
1
0
Fork 0
Code Issues 7 Pull Requests Actions Packages Projects Releases Wiki Activity

[Feature] Add CardDAV address-book connector #7

New Issue
Open
opened 2026-07-13 00:53:46 +02:00 by zemion · 4 comments
zemion commented 2026-07-13 00:53:46 +02:00
Owner
Copy Link

Goal

Implement the first standards-based sync connector.

Scope

  • CardDAV account/address-book discovery
  • vCard resource sync into scoped address books
  • read-only and writable CardDAV books where supported by the server
  • ETag changes, deletes, and conflict detection
  • connection test and diagnostics

Acceptance Criteria

  • A CardDAV source can be connected, synced, inspected, and disconnected.
  • Refreshing a source does not duplicate contacts.
  • Conflict and permission states are visible to the user.

See govoplan-addresses/docs/ADDRESS_MODULE_ARCHITECTURE.md and govoplan-addresses/docs/IMPLEMENTATION_PLAN.md.

## Goal Implement the first standards-based sync connector. ## Scope - CardDAV account/address-book discovery - vCard resource sync into scoped address books - read-only and writable CardDAV books where supported by the server - ETag changes, deletes, and conflict detection - connection test and diagnostics ## Acceptance Criteria - A CardDAV source can be connected, synced, inspected, and disconnected. - Refreshing a source does not duplicate contacts. - Conflict and permission states are visible to the user. See `govoplan-addresses/docs/ADDRESS_MODULE_ARCHITECTURE.md` and `govoplan-addresses/docs/IMPLEMENTATION_PLAN.md`.
zemion commented 2026-07-14 11:29:58 +02:00
Author
Owner
Copy Link

Codex State: progress

Summary

  • Implemented first CardDAV path: discovery, source binding, full/sync-token inbound vCard sync, dry-run preview, tombstones, diagnostics, and conflict persistence.
  • Deferred outbound CardDAV PUT/DELETE and field-level merge UI; writable/two-way currently means local writable plus inbound sync.

Changed Files

  • src/govoplan_addresses/backend/carddav.py
  • src/govoplan_addresses/backend/service.py
  • src/govoplan_addresses/backend/router.py
  • tests/test_addresses_service.py
  • docs/IMPLEMENTATION_PLAN.md

Verification

  • python -m unittest tests.test_addresses_service -> OK
  • npm run build in govoplan-core/webui -> OK

Next / Blocked

  • Implement CardDAV disconnect/delete UI and outbound writes with conflict policy.

Suggested status label: status/in-progress

## Codex State: progress ### Summary - Implemented first CardDAV path: discovery, source binding, full/sync-token inbound vCard sync, dry-run preview, tombstones, diagnostics, and conflict persistence. - Deferred outbound CardDAV PUT/DELETE and field-level merge UI; writable/two-way currently means local writable plus inbound sync. ### Changed Files - `src/govoplan_addresses/backend/carddav.py` - `src/govoplan_addresses/backend/service.py` - `src/govoplan_addresses/backend/router.py` - `tests/test_addresses_service.py` - `docs/IMPLEMENTATION_PLAN.md` ### Verification - `python -m unittest tests.test_addresses_service -> OK` - `npm run build in govoplan-core/webui -> OK` ### Next / Blocked - Implement CardDAV disconnect/delete UI and outbound writes with conflict policy. Suggested status label: `status/in-progress`
zemion commented 2026-07-14 11:50:00 +02:00
Author
Owner
Copy Link

Codex State: progress

Summary

  • Implemented first two-way CardDAV write path: local creates, updates, and deletes are planned and applied to writable two-way/export sources.
  • Outbound CardDAV writes use If-None-Match/If-Match preconditions; stale remote state is persisted as a sync conflict instead of overwritten.

Changed Files

  • src/govoplan_addresses/backend/carddav.py
  • src/govoplan_addresses/backend/service.py
  • src/govoplan_addresses/backend/schemas.py
  • tests/test_addresses_service.py
  • webui/src/api/addresses.ts
  • webui/src/features/addressbook/AddressBookPage.tsx
  • docs/IMPLEMENTATION_PLAN.md
  • docs/ADDRESS_MODULE_ARCHITECTURE.md

Verification

  • PYTHONPATH=/mnt/DATA/git/govoplan-addresses/src:/mnt/DATA/git/govoplan-core/src /mnt/DATA/git/govoplan/.venv/bin/python -m unittest tests.test_addresses_service -> 9 tests OK
  • PYTHONPATH=/mnt/DATA/git/govoplan-addresses/src:/mnt/DATA/git/govoplan-core/src /mnt/DATA/git/govoplan/.venv/bin/python -m py_compile src/govoplan_addresses/backend/carddav.py src/govoplan_addresses/backend/service.py src/govoplan_addresses/backend/schemas.py -> OK
  • cd /mnt/DATA/git/govoplan-core/webui && npm run build -> OK, existing npm tmp and Vite chunk-size warnings remain

Next / Blocked

  • Still open: CardDAV source disconnect/delete UI and field-level conflict merge UX.

Suggested status label: status/in-progress

## Codex State: progress ### Summary - Implemented first two-way CardDAV write path: local creates, updates, and deletes are planned and applied to writable two-way/export sources. - Outbound CardDAV writes use If-None-Match/If-Match preconditions; stale remote state is persisted as a sync conflict instead of overwritten. ### Changed Files - `src/govoplan_addresses/backend/carddav.py` - `src/govoplan_addresses/backend/service.py` - `src/govoplan_addresses/backend/schemas.py` - `tests/test_addresses_service.py` - `webui/src/api/addresses.ts` - `webui/src/features/addressbook/AddressBookPage.tsx` - `docs/IMPLEMENTATION_PLAN.md` - `docs/ADDRESS_MODULE_ARCHITECTURE.md` ### Verification - `PYTHONPATH=/mnt/DATA/git/govoplan-addresses/src:/mnt/DATA/git/govoplan-core/src /mnt/DATA/git/govoplan/.venv/bin/python -m unittest tests.test_addresses_service -> 9 tests OK` - `PYTHONPATH=/mnt/DATA/git/govoplan-addresses/src:/mnt/DATA/git/govoplan-core/src /mnt/DATA/git/govoplan/.venv/bin/python -m py_compile src/govoplan_addresses/backend/carddav.py src/govoplan_addresses/backend/service.py src/govoplan_addresses/backend/schemas.py -> OK` - `cd /mnt/DATA/git/govoplan-core/webui && npm run build -> OK, existing npm tmp and Vite chunk-size warnings remain` ### Next / Blocked - Still open: CardDAV source disconnect/delete UI and field-level conflict merge UX. Suggested status label: `status/in-progress`
zemion commented 2026-07-14 13:13:19 +02:00
Author
Owner
Copy Link

Codex State: progress

Summary

  • Added CardDAV sync source lifecycle UX: enable/disable in the sync inspector and disconnect/delete with local contacts kept.
  • Added conflict review UI with local/remote field comparison, Keep local / Use remote / Ignore actions, and backend support to apply stored remote vCard payloads.
  • New vCard conflicts now persist structured local and remote payloads so the review dialog can show field-level differences and apply remote values.

Changed Files

  • src/govoplan_addresses/backend/service.py
  • src/govoplan_addresses/backend/router.py
  • tests/test_addresses_service.py
  • webui/src/api/addresses.ts
  • webui/src/features/addressbook/AddressBookPage.tsx
  • webui/src/styles/addresses.css
  • README.md
  • docs/IMPLEMENTATION_PLAN.md
  • docs/ADDRESS_MODULE_ARCHITECTURE.md

Verification

  • PYTHONPATH=/mnt/DATA/git/govoplan-addresses/src:/mnt/DATA/git/govoplan-core/src /mnt/DATA/git/govoplan/.venv/bin/python -m unittest tests.test_addresses_service -> 10 tests OK
  • PYTHONPATH=/mnt/DATA/git/govoplan-addresses/src:/mnt/DATA/git/govoplan-core/src /mnt/DATA/git/govoplan/.venv/bin/python -m py_compile src/govoplan_addresses/backend/router.py src/govoplan_addresses/backend/service.py src/govoplan_addresses/backend/schemas.py -> OK
  • cd /mnt/DATA/git/govoplan-core/webui && npm run build -> OK, existing npm tmp and Vite chunk-size warnings remain

Next / Blocked

  • Remaining follow-up: manual per-field merge editing beyond Keep local / Use remote / Ignore.

Suggested status label: status/in-progress

## Codex State: progress ### Summary - Added CardDAV sync source lifecycle UX: enable/disable in the sync inspector and disconnect/delete with local contacts kept. - Added conflict review UI with local/remote field comparison, Keep local / Use remote / Ignore actions, and backend support to apply stored remote vCard payloads. - New vCard conflicts now persist structured local and remote payloads so the review dialog can show field-level differences and apply remote values. ### Changed Files - `src/govoplan_addresses/backend/service.py` - `src/govoplan_addresses/backend/router.py` - `tests/test_addresses_service.py` - `webui/src/api/addresses.ts` - `webui/src/features/addressbook/AddressBookPage.tsx` - `webui/src/styles/addresses.css` - `README.md` - `docs/IMPLEMENTATION_PLAN.md` - `docs/ADDRESS_MODULE_ARCHITECTURE.md` ### Verification - `PYTHONPATH=/mnt/DATA/git/govoplan-addresses/src:/mnt/DATA/git/govoplan-core/src /mnt/DATA/git/govoplan/.venv/bin/python -m unittest tests.test_addresses_service -> 10 tests OK` - `PYTHONPATH=/mnt/DATA/git/govoplan-addresses/src:/mnt/DATA/git/govoplan-core/src /mnt/DATA/git/govoplan/.venv/bin/python -m py_compile src/govoplan_addresses/backend/router.py src/govoplan_addresses/backend/service.py src/govoplan_addresses/backend/schemas.py -> OK` - `cd /mnt/DATA/git/govoplan-core/webui && npm run build -> OK, existing npm tmp and Vite chunk-size warnings remain` ### Next / Blocked - Remaining follow-up: manual per-field merge editing beyond Keep local / Use remote / Ignore. Suggested status label: `status/in-progress`
zemion commented 2026-07-14 13:18:32 +02:00
Author
Owner
Copy Link

Codex State: done

Summary

  • Completed the field-level merge path: the conflict review dialog now lets users choose Local or Remote per stored vCard field and applies the merged payload with resolution=merge.
  • CardDAV source disconnect/delete UX and backend deletion are implemented; disconnect keeps local contacts and removes source sync records.

Changed Files

  • src/govoplan_addresses/backend/schemas.py
  • src/govoplan_addresses/backend/service.py
  • src/govoplan_addresses/backend/router.py
  • tests/test_addresses_service.py
  • webui/src/api/addresses.ts
  • webui/src/features/addressbook/AddressBookPage.tsx
  • webui/src/styles/addresses.css
  • README.md
  • docs/IMPLEMENTATION_PLAN.md
  • docs/ADDRESS_MODULE_ARCHITECTURE.md

Verification

  • PYTHONPATH=/mnt/DATA/git/govoplan-addresses/src:/mnt/DATA/git/govoplan-core/src /mnt/DATA/git/govoplan/.venv/bin/python -m unittest tests.test_addresses_service -> 11 tests OK
  • cd /mnt/DATA/git/govoplan-core/webui && npm run build -> OK, existing npm tmp and Vite chunk-size warnings remain
## Codex State: done ### Summary - Completed the field-level merge path: the conflict review dialog now lets users choose Local or Remote per stored vCard field and applies the merged payload with resolution=merge. - CardDAV source disconnect/delete UX and backend deletion are implemented; disconnect keeps local contacts and removes source sync records. ### Changed Files - `src/govoplan_addresses/backend/schemas.py` - `src/govoplan_addresses/backend/service.py` - `src/govoplan_addresses/backend/router.py` - `tests/test_addresses_service.py` - `webui/src/api/addresses.ts` - `webui/src/features/addressbook/AddressBookPage.tsx` - `webui/src/styles/addresses.css` - `README.md` - `docs/IMPLEMENTATION_PLAN.md` - `docs/ADDRESS_MODULE_ARCHITECTURE.md` ### Verification - `PYTHONPATH=/mnt/DATA/git/govoplan-addresses/src:/mnt/DATA/git/govoplan-core/src /mnt/DATA/git/govoplan/.venv/bin/python -m unittest tests.test_addresses_service -> 11 tests OK` - `cd /mnt/DATA/git/govoplan-core/webui && npm run build -> OK, existing npm tmp and Vite chunk-size warnings remain`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
HTTP API contracts, routers, schemas, or API smoke behavior.
area/auth
Authentication, sessions, access bootstrap, or login behavior.
area/db
Database sessions, models, transactions, or persistence primitives.
area/deployment
Deployment, release, operations, or runtime packaging.
area/devex
Local developer workflow, scripts, tests, tooling, or release helpers.
area/docs
Durable documentation and project guidance.
area/governance
Governance policy, audit, privacy, retention, or compliance behavior.
area/marketing
Public website, product messaging, publication copy, or legal page content.
area/migrations
Alembic migrations, schema bootstrap, or persistence evolution.
area/module-system
Module discovery, manifests, capabilities, routing, or optional integrations.
area/rbac
Permissions, roles, delegation, or authorization policy.
area/release
Versioning, release locks, tags, packaging, or dependency pins.
area/security
Security posture, static analysis, supply-chain hardening, or vulnerability remediation.
area/tenancy
Tenant boundaries, provisioning, or tenant-scoped data behavior.
area/webui
Shared WebUI shell, frontend components, routing, or frontend tests.
audit/complexity
Complexity finding from Radon, Xenon, or equivalent maintainability scans.
audit/duplication
Duplicated-code finding from jscpd or equivalent similarity scans.
audit/false-positive
Audit finding reviewed as a narrow false positive or acceptable risk.
audit/needs-design
Audit finding that needs an architectural or product decision before implementation.
audit/quick-fix
Audit finding that appears narrow and directly fixable.
audit/structural
Audit finding that needs design, refactoring, or behavior review.
codex/needs-human
Needs an explicit human decision before Codex should implement.
codex/ready
Suitable for Codex to pick up with the existing issue context.
module/access
GovOPlaN access, identity, authentication, RBAC, and administration behavior.
module/addresses
GovOPlaN Addresses module behavior or integration.
module/admin
GovOPlaN Admin module behavior or integration.
module/appointments
GovOPlaN Appointments module behavior or integration.
module/approvals
GovOPlaN Approvals module behavior or integration.
module/assets
GovOPlaN Assets module behavior or integration.
module/audit
GovOPlaN Audit module behavior or integration.
module/booking
GovOPlaN Booking module behavior or integration.
module/calendar
GovOPlaN Calendar module behavior or integration.
module/campaign
GovOPlaN campaign module behavior or integration.
module/cases
GovOPlaN Cases module behavior or integration.
module/certificates
GovOPlaN Certificates module behavior or integration.
module/committee
GovOPlaN Committee module behavior or integration.
module/connectors
GovOPlaN Connectors module behavior or integration.
module/consultation
GovOPlaN Consultation module behavior or integration.
module/contracts
GovOPlaN Contracts module behavior or integration.
module/core
GovOPlaN core runner, shared primitives, shell, or extension points.
module/dist-lists
GovOPlaN Distribution Lists module behavior or integration.
module/dms
GovOPlaN Dms module behavior or integration.
module/docs
GovOPlaN documentation layer behavior or integration.
module/erp
GovOPlaN Erp module behavior or integration.
module/evaluation
GovOPlaN Evaluation module behavior or integration.
module/facilities
GovOPlaN Facilities module behavior or integration.
module/files
GovOPlaN files module behavior or integration.
module/fit-connect
GovOPlaN Fit Connect module behavior or integration.
module/forms
GovOPlaN Forms module behavior or integration.
module/forms-runtime
GovOPlaN Forms Runtime module behavior or integration.
module/grants
GovOPlaN Grants module behavior or integration.
module/helpdesk
GovOPlaN Helpdesk module behavior or integration.
module/identity
GovOPlaN Identity module behavior or integration.
module/identity-trust
GovOPlaN Identity Trust module behavior or integration.
module/idm
GovOPlaN Idm module behavior or integration.
module/inspections
GovOPlaN Inspections module behavior or integration.
module/issue-reporting
GovOPlaN Issue Reporting module behavior or integration.
module/learning
GovOPlaN Learning module behavior or integration.
module/ledger
GovOPlaN Ledger module behavior or integration.
module/mail
GovOPlaN mail module behavior or integration.
module/notifications
GovOPlaN Notifications module behavior or integration.
module/ops
GovOPlaN Ops module behavior or integration.
module/organizations
GovOPlaN Organizations module behavior or integration.
module/payments
GovOPlaN Payments module behavior or integration.
module/permits
GovOPlaN Permits module behavior or integration.
module/policy
GovOPlaN Policy module behavior or integration.
module/poll
GovOPlaN Poll module behavior or integration.
module/portal
GovOPlaN Portal module behavior or integration.
module/postbox
GovOPlaN Postbox module behavior or integration.
module/procurement
GovOPlaN Procurement module behavior or integration.
module/records
GovOPlaN Records module behavior or integration.
module/reporting
GovOPlaN Reporting module behavior or integration.
module/resources
GovOPlaN Resources module behavior or integration.
module/risk-compliance
GovOPlaN Risk Compliance module behavior or integration.
module/scheduling
GovOPlaN Scheduling module behavior or integration.
module/search
GovOPlaN Search module behavior or integration.
module/tasks
GovOPlaN Tasks module behavior or integration.
module/templates
GovOPlaN Templates module behavior or integration.
module/tenancy
GovOPlaN Tenancy module behavior or integration.
module/transparency
GovOPlaN Transparency module behavior or integration.
module/web
GovOPlaN public website, product page, or publication content.
module/workflow
GovOPlaN Workflow module behavior or integration.
module/xoev
GovOPlaN Xoev module behavior or integration.
module/xrechnung
GovOPlaN Xrechnung module behavior or integration.
module/xta-osci
GovOPlaN Xta Osci module behavior or integration.
priority
p0
Immediate stop-the-line priority.
priority
p1
High priority for the next focused work window.
priority
p2
Normal planned priority.
priority
p3
Low priority or opportunistic cleanup.
source/backlog-import
Imported from markdown backlog, roadmap, plan, or TODO files.
source/module-roadmap
Created from GovOPlaN module and integration roadmap planning.
source/security-audit
Created from a structured security or code-quality audit report.
source/todo-scan
Imported from inline TODO/FIXME/HACK markers by the Gitea TODO importer.
status
blocked
Cannot progress without a decision, dependency, credential, or external change.
status
in-progress
Currently being worked.
status
needs-info
Needs clarifying input before implementation can proceed safely.
status
ready
Ready for implementation.
status
triage
Needs review, ownership, priority, or acceptance criteria.
type
bug
A reproducible defect, regression, or incorrect behavior.
type
debt
Cleanup, refactoring, risk reduction, or deferred engineering work.
type
docs
Documentation, process, or developer workflow work.
type
feature
New user-visible behavior or platform capability.
type
task
Implementation, maintenance, migration, or operational work.
type
user-story
End-to-end user journey or real-world process story used to steer product slices.
No Label
area/api
area/webui
module/addresses
priority
p1
status
ready
type
feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zemion
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: add-ideas/govoplan-addresses#7
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?