[UI review] Core / shared shell: visual and interaction conformance #301
Open
opened 2026-09-08 18:40:30 +02:00 by zemion
·
2 comments
No Branch/Tag Specified
main
v0.1.46
v0.1.45
v0.1.44
v0.1.43
v0.1.42
v0.1.41
v0.1.40
v0.1.39
v0.1.38
v0.1.37
v0.1.36
v0.1.35
v0.1.34
v0.1.33
v0.1.32
v0.1.31
v0.1.30
v0.1.29
v0.1.28
v0.1.27
v0.1.26
v0.1.25
v0.1.24
v0.1.23
v0.1.22
v0.1.21
v0.1.20
v0.1.19
v0.1.18
v0.1.17
v0.1.16
v0.1.15
v0.1.14
v0.1.13
v0.1.12
v0.1.11
v0.1.8
v0.1.7
v0.1.6
v0.1.4
v0.1.3
v0.1.2
v0.1.1
v0.1.0
Labels
Clear labels
area/api
area/auth
area/db
area/devex
area/docs
area/governance
area/marketing
area/migrations
area/module-system
area/rbac
area/release
area/security
area/tenancy
area/webui
audit/complexity
audit/duplication
audit/false-positive
audit/needs-design
audit/quick-fix
audit/structural
codex/needs-human
codex/ready
module/access
module/addresses
module/admin
module/appointments
module/approvals
module/audit
module/calendar
module/campaign
module/cases
module/committee
module/connectors
module/core
module/dashboard
module/dataflow
module/datasources
module/decisions
module/dist-lists
module/dms
module/docs
module/encryption
module/erp
module/evaluation
module/files
module/fit-connect
module/forms
module/forms-runtime
module/helpdesk
module/identity
module/identity-trust
module/idm
module/ledger
module/mail
module/mandates
module/notifications
module/ops
module/organizations
module/parties
module/payments
module/permits
module/policy
module/poll
module/portal
module/postbox
module/projects
module/quick-access
module/records
module/reporting
module/risk-compliance
module/scheduling
module/search
module/services
module/tasks
module/templates
module/tenancy
module/tickets
module/views
module/voting
module/wiki
module/workflow
module/workflow-engine
module/xoev
module/xrechnung
module/xta-osci
source/backlog-import
source/security-audit
source/todo-scan
HTTP API contracts, routers, schemas, or API smoke behavior.
Authentication, sessions, access bootstrap, or login behavior.
Database sessions, models, transactions, or persistence primitives.
Local developer workflow, scripts, tests, tooling, or release helpers.
Durable documentation and project guidance.
Governance policy, audit, privacy, retention, or compliance behavior.
Public website, product messaging, publication copy, or legal page content.
Alembic migrations, schema bootstrap, or persistence evolution.
Module discovery, manifests, capabilities, routing, or optional integrations.
Permissions, roles, delegation, or authorization policy.
Versioning, release locks, tags, packaging, or dependency pins.
Security posture, static analysis, supply-chain hardening, or vulnerability remediation.
Tenant boundaries, provisioning, or tenant-scoped data behavior.
Shared WebUI shell, frontend components, routing, or frontend tests.
Complexity finding from Radon, Xenon, or equivalent maintainability scans.
Duplicated-code finding from jscpd or equivalent similarity scans.
Audit finding reviewed as a narrow false positive or acceptable risk.
Audit finding that needs an architectural or product decision before implementation.
Audit finding that appears narrow and directly fixable.
Audit finding that needs design, refactoring, or behavior review.
Needs an explicit human decision before Codex should implement.
Suitable for Codex to pick up with the existing issue context.
GovOPlaN access, identity, authentication, RBAC, and administration behavior.
GovOPlaN Addresses module behavior or integration.
GovOPlaN Admin module behavior or integration.
GovOPlaN Appointments module behavior or integration.
GovOPlaN Approvals module behavior or integration.
GovOPlaN Audit module behavior or integration.
GovOPlaN Calendar module behavior or integration.
GovOPlaN campaign module behavior or integration.
GovOPlaN Cases module behavior or integration.
GovOPlaN Committee module behavior or integration.
GovOPlaN Connectors module behavior or integration.
GovOPlaN core runner, shared primitives, shell, or extension points.
GovOPlaN Dashboard module behavior or integration.
GovOPlaN Dataflow module behavior or integration.
GovOPlaN governed datasource contracts, catalogs, and integrations.
GovOPlaN formal Decisions module behavior or integration.
GovOPlaN Distribution Lists module behavior or integration.
GovOPlaN Dms module behavior or integration.
GovOPlaN Docs module behavior or integration.
GovOPlaN Encryption key custody, cryptographic policy, and E2EE integration.
GovOPlaN Erp module behavior or integration.
GovOPlaN Evaluation module behavior or integration.
GovOPlaN files module behavior or integration.
GovOPlaN Fit Connect module behavior or integration.
GovOPlaN Forms module behavior or integration.
GovOPlaN Forms Runtime module behavior or integration.
GovOPlaN Helpdesk module behavior or integration.
GovOPlaN Identity module behavior or integration.
GovOPlaN Identity Trust module behavior or integration.
GovOPlaN Idm module behavior or integration.
GovOPlaN Ledger module behavior or integration.
GovOPlaN mail module behavior or integration.
GovOPlaN Mandates, jurisdiction, responsibility, and authority behavior or integration.
GovOPlaN Notifications module behavior or integration.
GovOPlaN Ops module behavior or integration.
GovOPlaN Organizations module behavior or integration.
GovOPlaN procedure Parties, representation, and delivery-authority behavior or integration.
GovOPlaN Payments module behavior or integration.
GovOPlaN Permits module behavior or integration.
GovOPlaN Policy module behavior or integration.
GovOPlaN Poll module behavior or integration.
GovOPlaN Portal module behavior or integration.
GovOPlaN Postbox module behavior or integration.
GovOPlaN Projects module behavior or integration.
GovOPlaN configurable task-local Quick Access behavior and integrations.
GovOPlaN Records and eAkte lifecycle behavior or integration.
GovOPlaN Reporting module behavior or integration.
GovOPlaN Risk Compliance module behavior or integration.
GovOPlaN Scheduling module behavior or integration.
GovOPlaN Search module behavior or integration.
GovOPlaN versioned institutional Services behavior or integration.
GovOPlaN Tasks module behavior or integration.
GovOPlaN Templates module behavior or integration.
GovOPlaN Tenancy module behavior or integration.
GovOPlaN Tickets module behavior or integration.
GovOPlaN governed task views, interface projections, and workflow view integration.
GovOPlaN Voting module behavior or integration.
GovOPlaN Wiki module behavior or integration.
GovOPlaN Workflow module behavior or integration.
GovOPlaN Workflow Engine runtime, persistence, or integration.
GovOPlaN Xoev module behavior or integration.
GovOPlaN Xrechnung module behavior or integration.
GovOPlaN Xta Osci module behavior or integration.
priority
p0
Immediate stop-the-line priority.
priority
p1
High priority for the next focused work window.
priority
p2
Normal planned priority.
priority
p3
Low priority or opportunistic cleanup.
Imported from markdown backlog, roadmap, plan, or TODO files.
Created from a structured security or code-quality audit report.
Imported from inline TODO/FIXME/HACK markers by the Gitea TODO importer.
status
blocked
Cannot progress without a decision, dependency, credential, or external change.
status
in-progress
Currently being worked.
status
needs-info
Needs clarifying input before implementation can proceed safely.
status
ready
Ready for implementation.
status
triage
Needs review, ownership, priority, or acceptance criteria.
type
bug
A reproducible defect, regression, or incorrect behavior.
type
debt
Cleanup, refactoring, risk reduction, or deferred engineering work.
type
docs
Documentation, process, or developer workflow work.
type
feature
New user-visible behavior or platform capability.
type
task
Implementation, maintenance, migration, or operational work.
type
user-story
End-to-end user journey or real-world process story used to steer product slices.
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: GovOPlaN/govoplan-core#301
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Status and objective
Pending / not reviewed. This module track belongs to the product-wide UI review epic.
Apply the Core design principles using the shared review process. The current heading-help icon pass and any existing isolated fixes are preparation, not evidence that this whole module is complete. Source documents are being prepared in the current working tree; this issue does not claim they are released.
Prioritize usability defects, consistent interaction and shared-component fixes before broader features. Preserve permissions, security, optional-module boundaries and data integrity.
Source inventory to verify
This is a source-derived starting inventory, not a completed runtime audit. Verify nested routes, embedded dialogs and contributions in the installed module context; add missing surfaces to this issue.
Repository: govoplan-core.
Core/shared shell additionally owns navigation/rail/breadcrumbs, module routing, page/action archetypes, cards/tables/forms/dialogs, loading and error surfaces, help affordances, authentication and user settings. Review optional-module and permission contexts, not just standalone primitives.
Source entrypoint seed (111 TSX files; classification is heuristic)
Pages and navigation entrypoints (12):
Dialogs and embedded editing surfaces (7):
Settings and administrator surfaces (3):
Widgets, public/operator and contributed surfaces (1):
Shared components and other UI entrypoints (88):
Review and implementation TODO
Principle applicability / application / evidence / exceptions
Reviewed Core principle revision: not yet recorded. No exceptions approved.
When a principle changes after this review, re-check applicability and record current evidence. Reopen this issue or link an owned follow-up for outstanding work; notify the central epic. A past review must not silently remain green against an obsolete rule.
Findings / TODO / done ledger
Manual checks, decisions and closure evidence
Partial implementation evidence — UI-01 heading help
Implemented locally; uncommitted and unpushed. This review remains pending. No module review checkbox, principle matrix or issue state is being marked complete by this comment.
Core now provides a shared heading-help contract:
titleHelpon semantic page/card/dialog/admin/workspace headings andTextWithHelpfor smaller labelled contexts. Documentation books are associated with the text they explain instead of action rows. Widget help is attached to its enclosing card title rather than duplicated inner titles or footer-only icons.The shared implementation addresses heading accessible names, focusable help controls, heading wrapping and card collapse/loading behavior. Consumer migrations use the same primitives; permission checks and optional Docs fallback remain in place.
The new
docs/UI_DESIGN_PRINCIPLES.mdestablishes UI-01–UI-09, including display-first/scoped editing and retroactive checks when a principle changes. This is an initial shared-contract rollout, not an end-to-end Core usability review.Source scope in the local working tree
webui/src/components/ActionBlockerHint.tsxwebui/src/components/Card.tsxwebui/src/components/CredentialEnvelopeManager.tsxwebui/src/components/Dialog.tsxwebui/src/components/NavigationPreferenceEditor.tsxwebui/src/components/PageActionBar.tsxwebui/src/components/PageLayout.tsxwebui/src/components/PageTitle.tsxwebui/src/components/admin/AdminPageLayout.tsxwebui/src/components/help/TextWithHelp.tsxwebui/src/components/table/DataGrid.tsxwebui/src/components/table/dataGridSizing.tswebui/src/features/privacy/RetentionPolicyManagement.tsxwebui/src/features/settings/SettingsPage.tsxwebui/src/i18n/generatedTranslations.tswebui/src/i18n/navigationEditorTranslations.tswebui/src/index.tswebui/src/layout/BreadcrumbBar.tsxThese paths identify the current uncommitted source scope, not a released commit. Some listed files also contain earlier fixes; this comment claims only the UI-01 changes described above.
Verification
Verified rollout checks (shared evidence, not a complete manual review of this module):
Additional verified actual-module evidence: at a 3085 px viewport, Dashboard display, configuration and return-to-display each kept the documentation book 6 px from its associated heading. Clean Cancel worked. The diagnostic browser recorded zero errors and no business writes; only diagnostic login/logout occurred.
The rollout also added 18 missing heading translations across 14 modules. These are focused German-parity fixes, not a declaration that every module's UI review is complete.
Broader-gate limitation: the wider focused gate, including the 63 optional-module build matrix, was still running at this evidence snapshot. This comment does not claim that the entire focused gate passed.
Shared/rollout checks are partial evidence, not exhaustive manual review of this module. Record the actual surfaces and principle revision during the full review.
Still pending
Coordination: Meta review epic; authoritative rules: Core UI design principles. Reusable lessons must be checked against already-reviewed modules through linked follow-ups or reopened reviews.
Earlier related work — separate partial history
Earlier, separate partial history: Core #300 tracks the preceding DataGrid/navigation/layout work. Linking it does not close that issue or establish completion of this full Core review.
Verification addendum — partial UI-01 rollout
This updates the broader-gate status in the earlier partial-implementation evidence.
tools/checks/check-focused.shrun: passed (exit 0) — local verification log:/mnt/DATA/tmp/govoplan-ui-review-20260908-1EveCs/focused.log; trailing module checks also passed.git diff --checkloop: passed (exit 0).These checks verify the bounded implementation, not the complete usability of every module. All module reviews and their checkboxes remain pending. Source remains local, uncommitted and unpushed; no release or deployment is claimed. Campaign’s UI-02 compact settings overview/scoped edit dialogs remain a separate pending implementation and review slice.